Uh oh!
There was an error while loading. Please reload this page.
feat(swift-ios): add swipe-down command palette - #6146
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
| private static func threadItems(snapshot: FeatureSnapshot) -> [FeatureCommandPaletteItem] { | ||
| let projectsByID = Dictionary(uniqueKeysWithValues: snapshot.projects.map { ($0.id, $0) }) |
There was a problem hiding this comment.
🟠 HighWorkspace/FeatureCommandPaletteModel.swift:266
threadItems builds projectsByID with Dictionary(uniqueKeysWithValues:), which traps when the snapshot contains two projects with the same id. Legacy aggregate snapshots can include cloned projects from multiple environments sharing an unscoped id, so presenting or searching the command palette with such a cached snapshot crashes the app. Consider using a duplicate-tolerant lookup (e.g. Dictionary(_:uniquingKeysWith:) or scoping by environment) instead.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Workspace/FeatureCommandPaletteModel.swift around line 266:
`threadItems` builds `projectsByID` with `Dictionary(uniqueKeysWithValues:)`, which traps when the snapshot contains two projects with the same `id`. Legacy aggregate snapshots can include cloned projects from multiple environments sharing an unscoped `id`, so presenting or searching the command palette with such a cached snapshot crashes the app. Consider using a duplicate-tolerant lookup (e.g. `Dictionary(_:uniquingKeysWith:)` or scoping by environment) instead.
2293598 to
e9909d4Comparesaphid
commented
Aug 15, 2026
Closing this version while I rebuild the upstream contribution set from the latest base. Clean versions are coming soon. |
What
Adds a native swipe-down command palette with recent threads, projects, new-task, add-project, and settings actions.
Scope
This is the single extracted feature commit: the palette model, palette view, WorkspaceView presentation gesture, and its focused tests. It excludes the surrounding personal release history.
Verification
HomeThreadMetadataTestsfixture repair is the first commit in this chained head;FeatureCommandPaletteTests: 5 passed.4401D856-DE6C-4769-A649-468778C929F6): 10/10 passed (5 metadata tests plus 5 command-palette tests), with zero failures.e9909d4ae133c7ede5e09c3cb453d5ed45aea1a0built, installed, and launched successfully ascom.t3tools.t3code.swiftui.dev.claude --model claude-opus-5 --effort highlaunch exited 1 at the Claude session limit; a post-reset read-only launch produced no verdict after approximately six minutes and was interrupted with onlyExecution erroroutput. No independent model identity or findings are claimed.Dependencies and gate
#6130 → #6146; after test(swift-ios): use environment-scoped provider catalogs #6130 lands, drop the duplicate fixture parent when refreshing the chain.Note
Add swipe-down command palette to iOS workspace view
WorkspaceViewtriggered by a downward drag gesture starting within 88pt of the top edge with at least 72pt of vertical travel.FeatureCommandPaletteView) supports two modes: a root view with actions and search across projects and threads, and a project picker for "New task in…" navigation.>filters to actions only.WorkspaceView: opening a thread, switching to a project, starting a new task, or presenting the add-project or settings sheets.📊 Macroscope summarized 2293598. 3 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.
Delivery: chain
Validated against Theo commit: f98cab5
Depends on: #6130
Merge order: #6130 → #6146
Validation status: Current head
e9909d4ae133c7ede5e09c3cb453d5ed45aea1a0is mergeable and non-conflicting. Actionable checks are green: Contract fixtures and native tests, Test, Check, Mobile Native Static Analysis, Release Smoke, and Macroscope correctness. Keep #6146 behind #6130 until that dependency lands; then drop the duplicate fixture parent when refreshing the chain. The unrelated Vercel authorization failure remains a maintainer-side gate.