feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(clients): add thread auto-settle modes - #6192

Closed
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes
Closed

feat(clients): add thread auto-settle modes#6192
davidhu2000 wants to merge 7 commits into
pingdotgg:mainfrom
davidhu2000:feat/thread-auto-settle-modes

Conversation

@davidhu2000

@davidhu2000davidhu2000 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Often times, I work on issues that will end up having multiple PRs, so I'm constantly having to unsettled threads after each PR. This change adds more customization on settle behavior.

Never, Inactivity, PR merge/close, and combined modes.

Default behavior is maintained as PR merge/close + Inactivity

Screenshot 2026-08-11 at 9 13 30 AM

Testing

  • 6 focused test files, 272 tests passed
  • targeted typechecks, lint, formatting, and whitespace checks passed before rebase
  • focused tests passed again after rebasing onto latest upstream main

Generated by GPT-5.6 via the Codex harness.

Note

Add thread auto-settle modes (never, inactivity, PR merge/close, combined) to web and mobile

  • Introduces ThreadAutoSettleMode to packages/contracts/src/settings.ts with four modes: never, inactivity, pull-request, and inactivity-or-pull-request. Previously only an inactivity day threshold existed.
  • Updates effectiveSettled in packages/client-runtime/src/state/threadSettled.ts to accept a ThreadAutoSettlePolicy object instead of a raw day count, enabling PR-based and combined settling logic.
  • Adds web settings UI (apps/web/src/components/settings/SettingsPanels.tsx) with a Select control for mode and a conditionally shown days slider; includes legacy migration from days-only settings via resolveClientThreadAutoSettleMode.
  • Adds mobile settings UI (apps/mobile/src/features/settings/SettingsRouteScreen.tsx) with a ControlPillMenu for mode selection, stored device-locally in mobile preferences.
  • All thread list and sidebar components on both platforms now consume the resolved policy, so settled/active partitioning reflects the chosen mode.
  • Behavioral Change: PR-based auto-settle is now opt-in; existing users without a stored mode are migrated based on their current day threshold, but PR threads will no longer be auto-settled unless the mode includes PR.

Macroscope summarized 904dfc8.

@coderabbitai

coderabbitaiBot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bda496f7-5b60-43a3-829d-9fafb3fbeabc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 11, 2026
Comment threadapps/web/src/threadAutoSettleSettings.ts Outdated
@macroscopeapp

macroscopeappBot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature: configurable thread auto-settle modes across web and mobile. The changes modify core settling logic and add new settings UI, warranting human review for the new capability.

You can customize Macroscope's approvability policy. Learn more.

@davidhu2000
davidhu2000 marked this pull request as draft August 11, 2026 16:15
@davidhu2000
davidhu2000 marked this pull request as ready for review August 11, 2026 16:28
@nikuscs

nikuscs commented Aug 12, 2026

Copy link
Copy Markdown

I believe this should get in, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

I believe this should get int, its a regression in some sense :\ at company they usually PR from develop to main, so any new threads at develop instantly auto-settle :p

hi @nikuscs, yeah, we work mainly from a single main branch. for my use case, i use the same thread to finish up an entire feature, and usually there are more than 1 PRs involved with the feature. For example, 1 PR for db migration, 1 PR to update the API, and a last PR to update the PR. So right now, each time a PR lands on main, the thread resolves, and i have to reopen. When there are a lot of threads going on, it can be hard to find

@davidhu2000

Copy link
Copy Markdown
ContributorAuthor

looks like this was added in #5880 so closing this as not needed.

@davidhu2000
davidhu2000 deleted the feat/thread-auto-settle-modes branch August 15, 2026 06:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@davidhu2000@nikuscs