Uh oh!
There was an error while loading. Please reload this page.
feat(desktop): add local file mentions - #6203
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6df5f1c. Configure here.
| if (prepared.paths.length > 0) { | ||
| handled = true; | ||
| const mentions = prepared.paths.map(serializeComposerFileLink).join(" "); | ||
| insertedPaths = insertComposerTextAtEnd(`${mentions} `, { ensureLeadingBoundary: true }); |
There was a problem hiding this comment.
WSL primary gets host paths
High Severity
canUseDesktopFilePaths treats the primary environment as always able to use raw webUtils.getPathForFile results, but in wsl-only mode that primary backend runs inside WSL. Dropped/pasted mentions therefore keep Windows host paths (C:\... or \\wsl$\...) instead of Linux paths the agent can open. Folder picking already converts via windowsToWslPath for WSL targets; this path does not.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 6df5f1c. Configure here.
ApprovabilityVerdict: Needs human review This PR introduces a new user-facing feature (local file mentions for desktop) with new logic for file path handling. There is also a high-severity unresolved finding about WSL path compatibility that needs attention. You can customize Macroscope's approvability policy. Learn more. |
CDVolvik
left a comment
There was a problem hiding this comment.
composerFileUpload.test.ts + pierre-icons.test.ts on the PR files: 11/11.
Local file mentions belong in the composer, not as silent uploads. MERGEABLE. I did not drop a file on a live desktop composer; the unit suite is only the mention/upload helper.


What changed
Why
Plain absolute paths are noisy in the composer, but uploading arbitrary files would introduce remote-transfer and file-size concerns. Desktop-local file mentions keep the UI readable while giving the agent the exact path it needs. Remote environments reject these files because a path from the client computer would not exist on the host computer.
Screenshots
JAR
PDF
Validation
vp test run apps/web/src/components/chat/composerFileUpload.test.ts apps/web/src/pierre-icons.test.tsvp lintfor changed filespnpm --filter @t3tools/web typecheckpnpm --filter @t3tools/desktop typecheckpnpm --filter @t3tools/contracts typecheckgit diff --check origin/main...HEADBuilt with GPT-5.6-Sol using the Codex harness in T3 Code.
Note
Add local file path mentions to desktop chat composer via drag and paste
getPathForFiletoDesktopBridge(via Electron'swebUtils) and exposes it to the renderer in preload.ts.basenameOfPathin pierre-icons.ts to handle Windows backslash separators.Macroscope summarized 6df5f1c.
Note
Cursor Bugbot is generating a summary for commit 6df5f1c. Configure here.