Uh oh!
There was an error while loading. Please reload this page.
fix(web): hide archive confirmation in settings with new sidebar - #6226
fix(web): hide archive confirmation in settings with new sidebar#6226ipanasenko wants to merge 4 commits into
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Approved ab04868 This PR conditionally hides the archive confirmation setting when the new sidebar is enabled. The changes are limited to UI visibility and search filtering, with defensive index clamping and unit tests added. No runtime behavior changes beyond conditional display. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
One finding: hiding the archive-confirmation row leaves the behavior it controls active in the default (non-legacy) UI.
Posted via Macroscope — UI Consistency
| updateSettings({ | ||
| confirmThreadArchive: DEFAULT_UNIFIED_SETTINGS.confirmThreadArchive, | ||
| }) | ||
| {settings.legacySidebarEnabled ? ( |
There was a problem hiding this comment.
confirmThreadArchive is not legacy-sidebar-only: the default sidebar (Sidebar.tsx:1689 → archive case at :3150) and the chat header thread menu (useThreadActionMenu.ts:86 → :260, used by ChatHeader.tsx) both still gate archive on it. Hiding the row here (and filtering archive-confirmation out of the search index) leaves that confirmation dialog reachable but unconfigurable — a user who turned it on under the legacy sidebar and then switched back is stuck with it, with no row and no search hit to turn it off.
Smallest fix: either keep the row rendered unconditionally (and drop requiresLegacySidebar from the search item), or also scope the runtime behavior — make Sidebar.tsx and useThreadActionMenu ignore confirmThreadArchive when the legacy sidebar is off — so the control and the behavior are hidden together.
If the row does stay conditional, please gate it on the shared useLegacySidebarEnabled() hook rather than raw settings.legacySidebarEnabled; SettingsSidebarNav uses the hook, and its hydration guard exists precisely so this decision has one source of truth.
Posted via Macroscope — UI Consistency
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a8cb71. Configure here.
| /> | ||
| } | ||
| /> | ||
| ) : null} |
There was a problem hiding this comment.
Hidden archive setting still applies
Medium Severity
Hiding Archive confirmation when the legacy sidebar is off leaves confirmThreadArchive live on the default sidebar. Context-menu archive still shows a confirm dialog when the flag is on, with no remaining control to change it.
Reviewed by Cursor Bugbot for commit 9a8cb71. Configure here.
There was a problem hiding this comment.
There's no context menu archive in new sidebar
ipanasenko
commented
Aug 15, 2026
Closing as superseded by #6526, which restored Archive to the default sidebar and made Archive confirmation relevant there again. |
The Archive confirmation preference only controls the legacy sidebar’s inline archive action, but it remains visible and searchable while the default sidebar is active.
This renders the preference only when the legacy sidebar is enabled and filters the corresponding Settings search result under the same condition. Focused coverage verifies both visibility states.
Implemented with GPT-5.6-SOL through the T3 Code Codex harness.
Note
Hide archive confirmation setting when new sidebar is enabled
requiresLegacySidebarflag tosettingsSearch.tsitems and avisibleSettingsSearchItemsutility to filter the search catalog based on sidebar state.SettingsSidebarNavnow passes the filtered catalog to avoid surfacing hidden items.clampSettingsSearchResultIndexto prevent out-of-bounds active index when the result list shrinks after filtering.Macroscope summarized 9a8cb71.
Note
Low Risk
Settings visibility and search filtering only; archive behavior is unchanged and the stored preference is untouched.
Overview
Archive confirmation only applies to the legacy sidebar’s inline archive control, but the General setting and search entry stayed visible with the default sidebar.
The Archive confirmation row now renders only when
legacySidebarEnabledis true. Search uses arequiresLegacySidebarcatalog flag andvisibleSettingsSearchItems()so that item is omitted from results otherwise.clampSettingsSearchResultIndexkeeps keyboard/highlight selection valid when the filtered list is shorter.Reviewed by Cursor Bugbot for commit 9a8cb71. Bugbot is set up for automated code reviews on this repo. Configure here.