feat(server): Grok Build effort, auth, rewind, and usage [WIP - for content] by t3dotgg · Pull Request #6383 · pingdotgg/t3code

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg · 2026-08-12T21:42:47Z

Grok Build already exposes reasoning effort, login state, rewind, and token usage. T3 ignored all of that. You could not pick effort, a logged-out CLI still looked ready, and model changes forced a new thread.

T3 now reads the live Grok effort menu from ACP model _meta, sends session/set_model with _meta.reasoningEffort, and lets you change model or effort on the current thread. ACP login failures show as unauthenticated. Conversation rollback uses _x.ai/rewind. Prompt usage is emitted as thread.token-usage.updated. There is a Grok user guide.

Made with Grok 4.6.

Note

Medium Risk
Changes Grok session lifecycle (model/effort switching, rewind mutating provider and in-memory turns) and auth probing; scope is Grok-only but rollback and turn trimming affect conversation integrity if mis-targeted.

Overview
Wires Grok Build into capabilities the CLI already exposes but T3 previously ignored: reasoning effort, login state, conversation rewind, and per-prompt token usage.

Reasoning & models: Effort menus come from ACP model _meta; the composer gets a Reasoning option (with fallbacks when discovery is thin). Selection is applied via session/set_model with _meta.reasoningEffort, optional --reasoning-effort at spawn, and in-thread model/effort changes (requiresNewThreadForModelChange is now false). Effort is not carried across a model switch unless explicitly requested.

Runtime behavior: After each prompt, usage from Grok metadata is published as thread.token-usage.updated. rollbackThread calls _x.ai/rewind/points / _x.ai/rewind/execute and trims local turn history. Provider status distinguishes unauthenticated Grok from other ACP failures and surfaces API-key vs session auth when discovery succeeds.

Supporting changes:setSessionModel accepts optional _meta; the ACP mock agent simulates rewind, usage, and effort metadata for tests. User docs add providers-grok.md; default text model for Grok is grok-build.

^{Reviewed by Cursor Bugbot for commit 39ed592. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Adds reasoning effort selection to Grok sessions: the spawned CLI receives a --reasoning-effort flag, model capabilities expose a Reasoning selector, and applyGrokAcpModelSelection can switch effort without changing model.
Implements rollbackThread for Grok using the _x.ai/rewind ACP extension: fetches rewind points, selects a target by turn count, executes the rewind, and trims in-memory turns.
Extracts token usage from prompt _meta and publishes thread.token-usage.updated events after each turn.
Auth detection in checkGrokProviderStatus now distinguishes API key vs. session auth and surfaces unauthenticated on ACP auth failures via isGrokAcpAuthFailure.
Sets requiresNewThreadForModelChange to false and defaults the Grok provider model to grok-build.
Adds a user-facing providers-grok.md guide covering login, model selection, reasoning effort, and troubleshooting.

^{Macroscope summarized 39ed592.}

Grok already advertised reasoning effort and rewind over ACP. T3 dropped the metadata and forced a new thread for model changes. Map the live effort menu into composer options, send session/set_model _meta.reasoningEffort, probe login, roll back turns through _x.ai/rewind, and emit thread token usage. Made with Grok 4.6.

coderabbitai · 2026-08-12T21:42:55Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22ccb553-a164-4214-8cfb-1cc0715b492f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-12T21:48:31Z

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 39ed592.

This comment will update automatically after the next completed run.

exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeapp · 2026-08-12T21:53:22Z

+ if (advertised.includes(requested)) {
+ return requested;
+ }


🟡 Mediumacp/GrokAcpSupport.ts:266
requestedGrokReasoningEffort discards every requested effort when advertised is empty, so the UI's selected value is not passed to either the initial --reasoning-effort spawn or session/set_model. The adapter intentionally calls this with [] before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.
Suggested change
if(advertised.includes(requested)){
returnrequested;
}
if(advertised.length===0||advertised.includes(requested)){
returnrequested;
}
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around lines 266-268: `requestedGrokReasoningEffort` discards every requested effort when `advertised` is empty, so the UI's selected value is not passed to either the initial `--reasoning-effort` spawn or `session/set_model`. The adapter intentionally calls this with `[]` before discovery, and fallback capabilities can also be shown without a session menu; accept the requested value when the advertisement is empty, while still validating it when choices are available.

macroscopeapp · 2026-08-12T21:53:22Z

+ const choices = [...unique.values()];
+ const current = trimmedString(meta.reasoningEffort);
+ const defaultId = current ?? choices.find((choice) => choice.isDefault)?.id;
+ const supportsReasoningEffort = meta.supportsReasoningEffort === true || choices.length > 0;


🟡 Mediumacp/GrokAcpSupport.ts:205
parseGrokAcpModelMeta reports supportsReasoningEffort: true when _meta.supportsReasoningEffort is true but reasoningEfforts is empty, so GrokProvider calls grokReasoningEffortCapabilities([]) and exposes no Reasoning selector instead of using FALLBACK_CAPABILITIES. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.
Suggested change
constsupportsReasoningEffort=meta.supportsReasoningEffort===true||choices.length>0;
constsupportsReasoningEffort=choices.length>0;
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @apps/server/src/provider/acp/GrokAcpSupport.ts around line 205: `parseGrokAcpModelMeta` reports `supportsReasoningEffort: true` when `_meta.supportsReasoningEffort` is true but `reasoningEfforts` is empty, so `GrokProvider` calls `grokReasoningEffortCapabilities([])` and exposes no Reasoning selector instead of using `FALLBACK_CAPABILITIES`. Set this flag only when at least one effort choice was discovered so thin-discovery responses take the fallback path.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

cursor · 2026-08-12T21:55:33Z

+ if (!requested) {
+ return undefined;
+ }
+ if (advertised.includes(requested)) {


Spawn effort always dropped
Medium Severity
requestedGrokReasoningEffort now requires the value to appear in advertised, but startSession still calls it with an empty list before spawn. That makes requestedStartEffort always undefined, so --reasoning-effort is never passed to the Grok CLI. The same rule also drops composer effort whenever session menus are empty, even though the provider UI can still show fallback effort options.
Additional Locations (1)
apps/server/src/provider/Layers/GrokAdapter.ts#L569-L595
^{Reviewed by Cursor Bugbot for commit 39ed592. Configure here.}

macroscopeapp · 2026-08-12T21:57:00Z

Approvability

Verdict: Needs human review

2 blocking correctness issues found. This PR introduces multiple new Grok provider capabilities (reasoning effort, rewind, usage tracking, auth detection) with significant new logic across several files. Additionally, there are unresolved Medium-severity findings identifying bugs in the effort propagation logic that prevent the selected reasoning effort from reaching the Grok CLI.

^{You can customize Macroscope's approvability policy. Learn more.}

t3-code · 2026-08-20T21:52:22Z

closing as superseded. #7070 explicitly supersedes this PR and carries the useful Grok work forward on a newer base.

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

t3dotgg added the [WIP - for content] WIP pull request opened for content review label Aug 12, 2026

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Aug 12, 2026

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

Comment threadapps/server/src/provider/acp/GrokAcpSupport.ts
Comment threadapps/server/src/provider/Layers/GrokAdapter.ts Outdated
Comment threadapps/server/src/provider/acp/XAiAcpExtension.ts Outdated

t3dotgg added 2 commits August 12, 2026 14:49

fix(server): allow undefined Grok effort on session/set_model
5f56ea5
exactOptionalPropertyTypes rejected passing string | undefined into the optional effort fields, which also leaked unknown into the adapter Effect error channel. Made with Grok 4.6.

fix(server): keep Grok effort and rewind aligned with the live session
39ed592
Do not carry an old effort onto a new model. Count steered prompts when rewinding. Lock rollback against a replaced session. Keep one default effort in the composer menu. Made with Grok 4.6.

macroscopeappBot reviewed Aug 12, 2026
View reviewed changes

cursorBot reviewed Aug 12, 2026
View reviewed changes

SunkenInTime mentioned this pull request Aug 12, 2026
fix(grok): expose advertised reasoning levels #6386
Closed
4 tasks

t3dotgg mentioned this pull request Aug 13, 2026
feat(server): show Grok subagents in the Agents panel #6410
Closed

maslinedwin mentioned this pull request Aug 15, 2026
feat(grok): Grok Build workflows, usage, rewind — supersedes #6383 #7070
Closed

t3-codeBot closed this Aug 20, 2026

This was referenced Aug 27, 2026
[Bug]: Grok model switching is blocked after a thread starts even though ACP supports it #8385
Closed
fix(grok): allow model changes in existing threads #8392
Merged

-if(advertised.includes(requested)){
-returnrequested;
-}
+if(advertised.length===0||advertised.includes(requested)){
+returnrequested;
+}

	constsupportsReasoningEffort=meta.supportsReasoningEffort===true\|\|choices.length>0;
	constsupportsReasoningEffort=choices.length>0;

Uh oh!

Conversation

t3dotgg commented Aug 12, 2026• edited by macroscopeapp BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Uh oh!

coderabbitaiBot commented Aug 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Aug 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thread transfer impact

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeappBotAug 12, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeappBotAug 12, 2026

Choose a reason for hiding this comment

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

cursorBotAug 12, 2026

Choose a reason for hiding this comment

Spawn effort always dropped

Uh oh!

macroscopeappBot commented Aug 12, 2026

Approvability

Uh oh!

t3-codeBot commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

t3dotgg commented Aug 12, 2026• edited by macroscopeapp BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Grok Build reasoning effort, auth detection, rewind, and token usage support

Uh oh!

coderabbitaiBot commented Aug 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Aug 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thread transfer impact

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeappBotAug 12, 2026

Choose a reason for hiding this comment

Uh oh!

macroscopeappBotAug 12, 2026

Choose a reason for hiding this comment

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

t3dotgg commented Aug 12, 2026•
edited by macroscopeapp Bot
Loading

coderabbitaiBot commented Aug 12, 2026•
edited
Loading

github-actionsBot commented Aug 12, 2026•
edited
Loading

t3dotgg commented Aug 12, 2026•
edited by macroscopeapp Bot
Loading

coderabbitaiBot commented Aug 12, 2026•
edited
Loading

github-actionsBot commented Aug 12, 2026•
edited
Loading

t3dotgg commented Aug 12, 2026•
edited by macroscopeapp Bot
Loading

coderabbitaiBot commented Aug 12, 2026•
edited
Loading

github-actionsBot commented Aug 12, 2026•
edited
Loading