Uh oh!
There was an error while loading. Please reload this page.
fix(web): make file breadcrumbs navigable - #7145
Conversation
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
There was a problem hiding this comment.
UI consistency review
Two findings on the new breadcrumb reveal affordance.
FilePreviewPanel.tsx— the crumb was converted from<span>to a raw<button>withouttext-left, so the UAtext-align: centernow applies to atruncate max-w-40label. Long path segments lose their leading characters instead of ellipsizing at the end.FileBrowserPanel.tsx— the breadcrumb reveal effect closes the tree search (and probes focus) before it can abort, so a reveal that resolves to nothing still destroys the user's search/focus context, which the existing selected-path reveal deliberately avoids.
Both are inline below with the smallest expected fix.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Needs human review This PR introduces a new interactive feature (navigable breadcrumbs) with significant new state management logic, and modifies a You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
There was a problem hiding this comment.
One finding on the new breadcrumb reveal: the project-root crumb resolves its scroll/focus target from raw array position instead of the tree's visible projection, and clears selection with nothing to select. Directory/file crumbs and the text-left fix from the previous round look good.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 94a2fd8. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Two issues in the new breadcrumb reveal path, both around the project-root ("") reveal and the new suppression gate. See inline comments.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
There was a problem hiding this comment.
One finding in the new selected-path suppression branch in FileBrowserPanel.tsx. The earlier root-reveal acknowledgement gap is resolved.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
There was a problem hiding this comment.
One finding on the reveal-state scoping in FileBrowserPanel. Everything else in this revision (the deselect before select() in the suppressed branch, the text-left crumb button, acknowledging an exhausted root-reveal retry) looks right.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>

problem
The workspace file breadcrumbs looked navigable but were rendered as static text.
fix
verification
vp run --filter @t3tools/web typecheckvp run --filter @t3tools/web buildvp linton both changed componentsbefore
after
Created by GPT-5.6-sol in T3 Code via the Codex harness.
request provenance
Note
Make file breadcrumbs navigable in the file preview panel
FilePreviewPanelwith clickable buttons that trigger a reveal in the file explorer, opening it if closed.revealBreadcrumb, persists the explorer open state to local storage, and emits a reveal request with a unique id toFileBrowserPanel.FileBrowserPanelhandles the reveal by expanding ancestor directories, selecting the visible target (accounting for flattened single-child directory rows viavisibleDirectoryTreePath), and center-scrolling it into view.Macroscope summarized 692234a.
Note
Medium Risk
Adds non-trivial tree selection/scroll coordination in the virtualized file browser; behavior is localized to file preview/explorer UX with dedicated tests noted in the PR.
Overview
File preview breadcrumbs are now interactive buttons that open the file explorer and request a one-shot tree reveal for the clicked project, directory, or file path.
FilePreviewPanelissuesbreadcrumbRevealPath/breadcrumbRevealIdtoFileBrowserPaneland clears the request after handling.FileBrowserPanelexpands ancestors, resolves flattened directory rows viavisibleDirectoryTreePath, selects the visible target, and scrolls it into view. Project-root reveals scroll the virtualized tree viewport to the top without refocusing the open file; a suppressedselectedPathsync keeps the current file selected without stealing focus or closing search.The UI consistency agent doc adds guidance for path-driven tree actions and one-shot external reveal requests in virtualized trees.
Reviewed by Cursor Bugbot for commit 692234a. Bugbot is set up for automated code reviews on this repo. Configure here.