Uh oh!
There was an error while loading. Please reload this page.
fix(web): refresh pull request diff after updates - #7167
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Needs human review Introduces substantial new async coordination infrastructure ( You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
One finding on header rendering in PullRequestDetailPanel.tsx. Everything else in the diff keeps using the shared primitives (Button, Empty-based unavailable state, DiffPanelLoadingState) and preserves the existing class strings and accessibility attributes.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
One finding on the new Code-tab bootstrap states. The earlier header regression (branch pair / diff stat disappearing) is resolved by the codeTabDetail ?? detail fallback.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>
6e35c7c to
6a00946CompareThere was a problem hiding this comment.
Two findings in the new Code tab diff-refresh UI. Details inline.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6a00946. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
One finding on the new diff-refresh banner in PullRequestCodeTab.tsx. The earlier bootstrap-path and header-gating issues look resolved at this head.
Posted via Macroscope — UI Consistency
| return ( | ||
| <div | ||
| role="alert" | ||
| className="flex shrink-0 items-start gap-2 border-b border-amber-500/25 bg-amber-500/8 px-3 py-2 text-xs" | ||
| > | ||
| <TriangleAlertIcon | ||
| aria-hidden | ||
| className="mt-0.5 size-3.5 shrink-0 text-amber-600 dark:text-amber-500" | ||
| /> | ||
| <div className="min-w-0 flex-1"> | ||
| <p className="font-medium text-foreground">Could not refresh pull request diff</p> | ||
| <p className="mt-0.5 text-muted-foreground">Showing the last loaded version. {error}</p> | ||
| </div> | ||
| <Button size="xs" variant="outline" className="shrink-0" onClick={onRetry}> |
There was a problem hiding this comment.
The banner's Retry has no in-flight state, so pressing it looks inert. bootstrapError is only cleared once the whole invalidate → detail/activity reread → aggregate diff chain resolves (setFailure(null) in the coordinator), so for several round trips the reader sees the identical "Could not refresh…" text and a fully enabled button, and repeated presses just re-enqueue the same lane. The bootstrap branch of this same component already tracks bootstrapRetryPending and swaps to the loading state, so the two retry affordances for one action now behave differently.
Smallest fix: give PullRequestCodeRefreshFailure an optional pending prop, pass bootstrapRetryPending at both render sites (line 1394 and line 1490), and use it to disable the Button (e.g. disabled={pending}, optionally animate-spin on RefreshCwIcon) so the control reports the in-flight refresh like the rest of the panel's retries.
Posted via Macroscope — UI Consistency
t3dotgg
commented
Aug 23, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo Closing this PR after an automated pass over open pull requests. Pull-request detail and diff refresh already shipped in #7148. |
Problem
After a pull request receives new commits, the detail header can update while the Code tab's All commits diff remains on an older aggregate snapshot. Switching to a commit and back exposes the stale aggregate until the user explicitly refreshes it.
The detail panel keeps the aggregate diff query warm, but live refresh previously refreshed only detail and activity data. The aggregate diff query therefore remained mounted with stale data.
Fix
updatedAtrevisions and invalidate the host cache when the revision advances.Validation
@t3tools/webtypecheck passed.git diff --checkpassed.Built with GPT-5.6 in the Codex harness through T3 Code.
Note
Refresh pull request diff after updates using snapshot coordination
createPullRequestDiffRefreshCoordinatorinpullRequestDetail.logic.tsthat manages diff refresh with a latest-wins strategy, skipping redundant refreshes and surfacing failures via an alert banner.PullRequestDetailPanelnow drives diff refresh through the coordinator: builds aPullRequestCodeSnapshot(detail + first-page aggregate diff) and applies it coherently, replacing the previous eager warm-up andrefreshTokenapproach.PullRequestCodeTabboots from the snapshot, defers diff queries until the snapshot is available, handles aggregate pagination manually with per-cursor retry, and showsPullRequestCodeRefreshFailureon refresh errors without losing displayed content.diffRevision(base/head OIDs) on PR detail;PullRequestServiceuses these to separate aggregate diff cache invalidation from commit-scoped diff and detail invalidation viaresource: "diff".invalidatewithresource: "diff"now only busts the aggregate diff cache, leaving detail and commit diff caches intact. Aggregate diff cache keys now include a second epoch slot, so existing cached keys are structurally incompatible.Macroscope summarized 91a29c6.
Note
Medium Risk
Touches PR caching, multi-host detail decoding, and async refresh coordination; incorrect epoch or coordinator ordering could show stale diffs or skip updates, but behavior is heavily covered by new service and logic tests.
Overview
Fixes All commits staying stale after new pushes while the detail header updates, by tying aggregate diff freshness to immutable base/head OIDs and a dedicated refresh path.
Server & contracts: Optional
diffRevision(baseOid/headOid) is populated from GitHub (extragh apiafter detail), GitLab (diff_refs), and Bitbucket (source/destination commit hashes).invalidateacceptsresource: "diff"to bump only the aggregate diff epoch; commit-scoped diffs use a separate epoch and are not cleared on diff-only invalidation. Epoch maps advance a fallback on LRU eviction so evicted scopes cannot reuse stale cache keys.Web:
PullRequestDetailPaneldrops eager diff warm-up andrefreshToken; acreatePullRequestDiffRefreshCoordinatorinvalidates diff cache, re-reads detail+activity, fetches the first aggregate page, and applies a versioned snapshot.PullRequestCodeTabbootstraps from that snapshot, shows loading/error and stale diff + retry banners on refresh failure, and pages aggregate vs commit diffs separately (shouldRefreshAppliedCommitDifffor same-commit snapshot bumps).Reviewed by Cursor Bugbot for commit 91a29c6. Bugbot is set up for automated code reviews on this repo. Configure here.
Closes#7310