Uh oh!
There was an error while loading. Please reload this page.
fix(grok): stop Working after 10 minutes of silence - #7215
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
506133d to
2e51c81CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
2e51c81 to
8233044CompareUh oh!
There was an error while loading. Please reload this page.
8233044 to
e9e715bCompareApprovabilityVerdict: Needs human review This PR adds a watchdog mechanism that terminates stalled Grok ACP turns after configurable timeouts. While well-tested, it introduces significant runtime behavior changes to core session management and is authored by someone new to this file. You can customize Macroscope's approvability policy. Learn more. |
e9e715b to
a64f36aCompareUh oh!
There was an error while loading. Please reload this page.
a64f36a to
46cb578CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
46cb578 to
26f6529CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 26f6529. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
26f6529 to
fa5736cComparet3dotgg
commented
Aug 27, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo I am closing this because #8358 has landed in Thank you for putting this together. The closure is only because the work is now covered elsewhere, not because there was a problem with your contribution. |

Fixes#7210.
A Grok turn sat on Working for 74 minutes after the last tool finished. The stream died mid-reasoning. No
turn_ended. The UI never gave up.After ten minutes with no tokens, tools, or terminal events, the turn now fails and Working stops. The timer does not run during tools, approvals, or user input. Existing threads and other clients already share that turn state.
Most of the diff is the watchdog plus tests.
Validation:
vp test run apps/server/src/provider/Layers/GrokAdapter.test.ts(25 passed).Created with GPT-5.6 Luna via Codex CLI, reviewed and finalized in the T3 Code Codex harness.
Note
Fix stalled ACP turns in
GrokAdapterby adding a liveness watchdogGrokAdapter.tsthat monitors turn activity and fails stalled turns after an inactivity deadline, but only after ACP has emitted observable progress (content, plan update, tool activity, or user input resolution).acp-mock-agent.tswith env-controlled stall modes to simulate hangs after content, plan updates, active tools, orask_user_questionresponses for testing.Macroscope summarized fa5736c.