Uh oh!
There was an error while loading. Please reload this page.
fix(web): merged PR threads settle without polling delay - #7227
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved bd4c467 Small, self-contained UX fix that triggers an immediate VCS status refresh after merging a PR. The new utility function is trivial ( You can customize Macroscope's approvability policy. Learn more. |
Closes#7224.
Merging a pull request from the thread PR panel refreshed the panel and PR lists, but left the thread sidebar waiting for its next VCS status poll.
Pass the completed action back to ChatView and explicitly refresh the active thread's exact checkout after a successful merge. The existing VCS status stream then publishes the merged state and the existing auto-settle classification moves the thread immediately. Other PR actions keep their current refresh behavior.
Verification:
pnpm exec vp test run apps/web/src/components/pullRequest/pullRequestDetail.logic.test.tspnpm exec vp run --filter @t3tools/web typecheckBehavior-only change; there are no styling or layout changes.
Created by GPT-5.6-sol using the Codex harness in T3 Code.
Note
Low Risk
Behavior-only fix scoped to post-merge VCS refresh; no auth, data, or payment paths touched.
Overview
Merging a linked pull request from the thread panel no longer leaves the sidebar waiting for the next VCS poll before the thread moves to the settled list.
Adds
pullRequestActionNeedsVcsRefresh(true only formerge) and changesPullRequestDetailPanel'sonActedto pass the completedPullRequestAction. ChatView wires that intovcsEnvironment.refreshStatusfor the active thread's checkout when a merge succeeds, so the existing VCS status stream can reclassify the thread right away. Other PR actions keep the same refresh behavior as before.User docs note that merging a linked review updates the thread immediately.
Reviewed by Cursor Bugbot for commit bd4c467. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Trigger VCS status refresh immediately after merging a pull request
pullRequestActionNeedsVcsRefreshin pullRequestDetail.logic.ts that returnstrueonly for themergeaction.PullRequestDetailPanelto pass the executedPullRequestActionto itsonActedcallback instead of calling it with no arguments.ChatViewContent, the newonActedhandler callsvcsEnvironment.refreshStatuswhen the action requires a VCS refresh, so merged PR threads settle immediately without waiting for the next polling cycle.Macroscope summarized bd4c467.