fix(preview): name hidden, disabled, and ambiguous click failures

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990

[gbarros-dev]

preview_click identified hidden, disabled, and ambiguous targets in the desktop process, but Electron IPC did not preserve the custom error fields. The MCP caller then received a generic client failure.

This change sends a typed click outcome across Electron IPC. The web host returns only the exact lookup reason and optional match count. The broker combines that response with the selector kind and length from the original request, so the MCP error is useful without returning the locator text.

The desktop action timeline still records target lookup failures as failed clicks.

Related to #3714. Does not close it.

Tests:

• vp test run packages/contracts/src/ipc.test.ts
• vp test run apps/desktop/src/preview/Manager.test.ts apps/desktop/src/ipc/methods/preview.test.ts
• vp test run apps/web/src/components/preview/previewAutomationErrors.test.ts apps/web/src/components/preview/previewAutomationRequestConsumer.test.ts
• vp test run apps/server/src/mcp/PreviewAutomationBroker.test.ts apps/server/src/mcp/McpHttpServer.test.ts

Original implementation by @gbarros-dev with Grok 4.6 through Grok CLI.

Made with GPT-5.6 Sol using Codex for modernization.

---

Note

Medium Risk
Changes preview automation click semantics and error propagation across desktop IPC, web host, and MCP; callers that assumed silent success on lookup failure now get typed failures, but successful clicks still dispatch input as before.

Overview
Preview automation clicks now return a typed DesktopPreviewAutomationClickResult over Electron IPC (Dispatched or NotSent with reasons like target-missing, target-hidden, target-disabled, target-ambiguous) instead of void, so lookup failure details are not lost before they reach MCP callers.

On the desktop side, locator resolution uses all matches and classifies missing, hidden, disabled, and ambiguous targets; failed lookups yield NotSentwithout dispatching mouse input, while the action timeline still records failed clicks. New PreviewAutomationTargetLookupError types (contracts, desktop manager, web host) carry failureKind and optional matchCount, with messages that avoid leaking locator text.

The web preview host wraps IPC results with confirmPreviewAutomationClickTarget, turning target NotSent outcomes into PreviewAutomationTargetLookupHostError for the automation broker/MCP path. The server broker maps remote lookup errors from response detail.failureKind.

^{Reviewed by Cursor Bugbot for commit 30f017d. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Return typed click outcomes for preview automation clicks

• Preview automation clicks now return DesktopPreviewAutomationClickResult with Dispatched or NotSent variants (target-missing, target-hidden, target-disabled, target-ambiguous) instead of void
• PreviewManager locator lookup switches from single-element to all-matches query so ambiguous targets with multiple matches are detected; only a single visible enabled match is clicked
• New schema-backed error classes (PreviewAutomationTargetLookupError, PreviewAutomationTargetLookupHostError) carry the lookup failure kind and optional positive match count, with sanitized messages that omit selector/locator values
• The web preview host converts every NotSent click result into a named host automation error via confirmPreviewAutomationClickTarget
• Behavioral Change: DesktopPreviewBridge.automation.click return type changes from Promise<void> to Promise<DesktopPreviewAutomationClickResult | void>; callers that ignored the result are unaffected, but the broker and host layers now reject NotSent outcomes as errors rather than silently succeeding

^{Macroscope summarized 30f017d.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 438ef4e0-9982-4cbd-8b1f-40df040e76d7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

One finding on the desktop-side error construction. See the inline comment.

^{Posted via Macroscope — Effect Service Conventions}

[macroscopeapp]

Approvability

Verdict: Approved at a46cbf3

Macroscope's review found this PR approvable — This is a focused preview-click failure-handling fix that preserves successful click behavior while carrying missing, hidden, disabled, and ambiguous outcomes through the existing IPC, web, and MCP layers. The contract changes are additive and the new paths have targeted coverage, with locator text kept out of surfaced errors.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 698bda4

[macroscopeapp]

Reviewed the new preview automation lookup error classes against the Effect service conventions. The desktop-side classification is now a static factory next to the error type (PreviewAutomationTargetNotFoundError.fromLookupFailure), the new errors are structured Schema.TaggedErrorClass variants with messages derived from attributes, no selector text is leaked, and the host-side wrappers preserve cause. One finding: a redundant failureKind discriminator path on the web translation boundary that nothing produces.

^{Posted via Macroscope — Effect Service Conventions}

Dismissing prior approval to re-evaluate b322990