fix(web): collapse the composer when it is not focused by chrisdeeming · Pull Request #7446 · pingdotgg/t3code

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

chrisdeeming · 2026-08-18T23:03:35Z

What Changed

The composer collapses to a single ~50px row whenever it is not focused, instead of always reserving 144px.

A parked draft stays visible in that row, muted and truncated.
Staged attachments keep it expanded, since the row renders text only.
Narrow viewports already did this; the width gate is gone, so web, desktop and mobile now share one rule.

Why

The resting composer reserved a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, giving T3 Code a noticeably smaller transcript than comparable apps. Collapsing on blur returns ~94px to the thread.

UI Changes

Same thread at 1440x900, unfocused.

Before

Empty composer, then with a parked draft. Both 144px with the full toolbar.

After

Empty composer, then with a parked draft. Both 50px; the draft shows muted and truncated.

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
No video this time

Written by Claude Opus 5 via Claude Code.

Note

Medium Risk
Large interaction surface in ChatComposer (focus, blur, collapse, popups, stash, imperative focus APIs); regressions could affect typing, sending, and keyboard shortcuts across web/desktop/mobile.

Overview
The chat composer now collapses to a single resting row when unfocused on desktop as well as mobile, not only on narrow viewports. Parked draft text still shows truncated in that row; attachments, in-flight image compression, running turns (Stop/spinner), plan follow-up chrome, and transient UI (stash menu, model picker, stash pulse) keep the full composer open via new shouldCollapseRestingComposer in composerFooterLayout.ts.

Focus and expand behavior is reworked: expandComposerThenFocus retries editor focus across animation frames and reconciles collapse if focus never lands; blur into any Base UI floating layer (dialogs, sheets, menus, etc.) defers collapse and focusin/pointerdown listeners re-run the check when focus leaves popups. Stash (⌘S) and restore paths avoid stealing focus or flashing expand when the editor is disabled.

A shared ComposerSendButton (with composerSendButtonLabel) unifies send styling, busy spinner, and aria labels in the expanded footer and collapsed row; the collapsed send can submit without expanding the composer.

^{Reviewed by Cursor Bugbot for commit 49d0019. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Collapse the `ChatComposer` when it loses focus across all viewports

Generalizes the composer collapse/expand logic from mobile-only to all viewports, driven by focus, attachments, busy state, and transient/actionable chrome via the new shouldCollapseRestingComposer utility in composerFooterLayout.ts
Defers collapse while focus is inside any floating popup (dialog, sheet, command menu, etc.) by expanding FLOATING_LAYER_SELECTOR and the isInsideFloatingLayer check in ChatComposer.tsx; a global focusin/pointerdown capture re-runs the deferred check once focus settles outside all popups
expandComposerThenFocus retries editor focus up to 5 animation frames and skips expansion when the editor is disabled, avoiding premature collapse
Introduces a shared ComposerSendButton component in ComposerSendButton.tsx with correct busy indicator, backdrop styling, and accessible labeling; replaces the inline send button in ComposerPrimaryActions.tsx
Behavioral Change: data-chat-composer-mobile-collapsed is replaced by data-chat-composer-collapsed; in-flight image compressions now count as attachments for collapse gating, and stash-by-shortcut restores focus to the pre-stash element if it was outside the composer

^{Macroscope summarized 49d0019.}

coderabbitai · 2026-08-18T23:03:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f12ae3a-1591-4289-bc54-682cc3fd83a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp

Two findings on the resting-composer change. Extending the collapsed state from mobile to every viewport is fine in principle, but the editor is hidden with display:none while it stays mounted, and nothing in the imperative focus paths un-collapses it — so desktop focus entry points silently stop working. The collapsed draft text also now uses a token that is identical to the placeholder token in the shipped palettes.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-18T23:15:38Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR extends mobile composer collapse behavior to desktop, introducing new user-facing functionality with complex focus/blur reconciliation logic. Multiple review comments identified bugs in the implementation that required fixes. The scope and complexity warrant human review.

^{You can add or adjust custom eligibility rules. Learn more.}

macroscopeapp

Collapse now applies on desktop, so keyboard-driven composer surfaces that only exist inside the collapsed (hidden / unmounted) subtree lose their entry point. Two spots below.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The focus entry points now route through expandComposerThenFocus, which resolves the earlier "collapsed forever on desktop" problem. Two findings remain in the collapsed row, which is now the default resting state on desktop rather than a mobile-only view.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

UI consistency review: one issue found in the resting-composer collapse work. The earlier findings (menus opening against an unmounted subtree, and Tab entry into the collapsed row) look correctly addressed by hasOpenMenu and the onFocus/data-chat-composer-collapsed-controls split.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the desktop resting-composer change. The previously flagged issues (focus entry expanding the editor, keyboard Tab entry, draft vs. placeholder tone, sm:px-4 alignment, keybinding-opened menus and the stash pulse holding the composer open) all look resolved, and every editor focus entry point now routes through expandComposerThenFocus. One minor desktop affordance gap remains on the collapsed row.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T00:27:19Z

Now that this row is the resting state on desktop, hovering the composer shows the default arrow cursor: Tailwind v4's preflight sets no cursor on button, and the shared controls opt in explicitly (Button uses cursor-pointer, ComposerPrimaryActions uses enabled:cursor-pointer). The expanded composer shows a text caret over the same area, so the cursor flips on focus. cursor-text here keeps the resting row reading as an input.
Suggested change
"min-w-0 flex-1 cursor-text truncate rounded-sm bg-transparent p-0 text-left text-[14px] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

Reviewed the resting-composer collapse for UI consistency. The earlier gaps (imperative focus entry points, tab-in, menu/pulse hold-open, sm:px-4, draft vs placeholder tone, focus ring) all look resolved. Two remaining items are specific to the collapsed row now being the desktop resting state, where it was previously mobile-only: it drops the composer's typography settings, and its buttons have no pointer cursor.

^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding: the new isBusy term keeps the composer permanently expanded while an approval or pending user-input request is outstanding, which makes the collapsed approval / pending-input variants below unreachable and changes existing mobile behavior. Details inline.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T01:21:41Z

+ // Every in-flight signal, not just a running turn: the footer owns the
+ // Stop control, the send spinner and the "Preparing worktree" label.
+ isBusy: phase === "running" || isSendBusy || isConnecting || isPreparingWorktree,


isBusy folds in phase === "running", but the session status stays running for the whole time an approval or user-input request is outstanding — the server never dispatches a session change for request.opened / user-input.requested (and a provider waiting state is mapped to running), and derivePhase reads nothing but session.status. So whenever activePendingApproval or pendingUserInputs is non-empty, shouldCollapseRestingComposer returns false.
That contradicts the comment just above ("Approvals and pending inputs … render their own collapsed variants") and makes those variants dead: isComposerCollapsed && activePendingApproval (2870) and isComposerCollapsed && pendingUserInputs.length > 0 (2887) can no longer render. Those rows shipped on mobile before this PR, where the old rule (isMobileViewport && !forceExpandedOnMobile && !isComposerFocused) had no busy term — so a narrow viewport now keeps the full approval panel plus editor plus toolbar mounted at rest instead of the compact row, and showMobilePendingAnswerActions (1300) is pinned on for the same reason.
Excluding outstanding requests from the busy gate keeps the Stop/spinner rule for real in-flight turns while restoring the collapsed request rows:
Suggested change
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label.
isBusy: phase==="running"||isSendBusy||isConnecting||isPreparingWorktree,
// Every in-flight signal, not just a running turn: the footer owns the
// Stop control, the send spinner and the "Preparing worktree" label. A
// pending request is excluded: the session stays "running" while it waits,
// and it has its own collapsed row carrying the actions.
isBusy:
(phase==="running"||isSendBusy||isConnecting||isPreparingWorktree)&&
activePendingApproval===null&&
pendingUserInputs.length===0,
^{Posted via Macroscope — UI Consistency}

This was the best catch of the review — fixed in 09638f168 with your suggestion.
I verified the chain rather than taking it on trust: orchestrationSessionStatusFromRuntimeState maps waiting to running (ProviderRuntimeIngestion.ts:273-291), and derivePhase reads nothing but session.status (session-logic.ts:1710-1722). So phase really does stay running for the whole time a request is outstanding, and my isBusy term made the collapsed approval and pending-input rows unreachable — rows that shipped on mobile before this PR. That is a regression I introduced, and the comment above the flag was wrong as a result.
isBusy now excludes outstanding requests, so real in-flight turns still keep Stop and the spinner mounted while those variants render again.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency gap: the collapsed pending-user-input row now renders on desktop but did not get the pointer/focus treatment the sibling collapsed prompt row received in this PR.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:17:12Z

This collapsed "Write custom answer" row is now a desktop resting state too (gate at 2911 is isComposerCollapsed, and isBusy excludes pending inputs), but it kept the mobile-only styling while the sibling collapsed prompt row below gained cursor-pointer and a focus-visible ring. On a pointer device the row highlights on hover (hover:bg-background/80 on the wrapper) yet shows the default arrow — and in the multi-select branch the ComposerPrimaryActions button next to it carries enabled:cursor-pointer, so the cursor flips mid-row. Suggest matching the other collapsed expander:
- "min-w-0 flex-1 truncate bg-transparent py-1.5 text-left text-sm",+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

Fixed in 64abe7ebd as suggested — the "Write custom answer" row now carries cursor-pointer, rounded-sm and the focus-visible ring, matching the sibling collapsed expander. The cursor no longer flips mid-row against the adjacent ComposerPrimaryActions button.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One finding: the collapsed pending-answer row is now a desktop resting state but still renders composer prompt text in the interface font, unlike the sibling collapsed prompt row that was aligned to the editor's typography tokens.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T02:34:34Z

This row now renders at rest on desktop too (gate at 2946 is isComposerCollapsed), and it shows activePendingProgress.customAnswer — the exact value the editor renders (3241). The editor wrapper types that text with the appearance tokens ([font-family:var(--font-composer,…)] [font-size:var(--font-size-prompt,0.875rem)], ComposerPromptEditor.tsx:1751), which the Prompt font / Prompt font size settings write (12–20px, optional custom family). Hardcoding text-sm in the interface font means a parked custom answer is shown at the wrong size/family and re-typesets on expand for anyone who changed those settings — the same contract the sibling collapsed prompt row below now honours (3015). Suggest using the same tokens here.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left text-sm focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent py-1.5 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
^{Posted via Macroscope — UI Consistency}

macroscopeapp

One finding on the collapsed prompt row: it stays interactive in a state where the editor cannot take focus, so the new expand/reconcile handshake flashes the composer open and shut.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:00:30Z

+ "min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
 (activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
 ? "text-foreground"
 : "text-placeholder",
 )}
 onPointerDown={(event) => event.preventDefault()}
- onClick={expandMobileComposer}
+ onClick={expandComposer}
+ // Tabbing here is a request to start typing, so expand and let
+ // the caret land in the editor rather than parking on a button.
+ onFocus={expandComposer}
 aria-label="Expand composer"


When projectSelectionRequired is set (local draft with no project), the editor is rendered disabled (line 3271), so Lexical's root is contenteditable="false" and focusAt's rootElement.focus() is a no-op. Clicking this row now expands the composer, misses focus on all five attempts, and the release frame reconciles by collapsing it again — on desktop the resting composer flashes open and shuts and can't be opened at all (previously it just stayed expanded, and collapse never applied here outside mobile).
The sibling send button already opts out of that state through collapsedComposerPrimaryActionDisabled; disabling this button too keeps the row consistent with the disabled editor and with the opacity-75 the surface already shows.
Suggested change
"min-w-0 flex-1 cursor-pointer truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandMobileComposer}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
"min-w-0 flex-1 truncate rounded-sm bg-transparent p-0 text-left [font-family:var(--font-composer,var(--font-sans))] [font-size:var(--font-size-prompt,0.875rem)] [@media(max-width:39.999rem)_and_(pointer:coarse)]:[font-size:max(var(--font-size-prompt,1rem),16px)] enabled:cursor-pointer focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring",
(activePendingProgress ? activePendingProgress.customAnswer : prompt.trim())
? "text-foreground"
: "text-placeholder",
)}
disabled={projectSelectionRequired}
onPointerDown={(event)=>event.preventDefault()}
onClick={expandComposer}
// Tabbing here is a request to start typing, so expand and let
// the caret land in the editor rather than parking on a button.
onFocus={expandComposer}
aria-label="Expand composer"
^{Posted via Macroscope — UI Consistency}

Correct, and this was a regression from the retry loop I added for the previous finding — it turned "stays expanded" into "flashes open and shut", which is worse. Fixed in db1b04e2f.
Two layers, since the click path is not the only way in:
The expand button is now disabled under the same three conditions that disable the editor (isConnecting || isComposerApprovalState || projectSelectionRequired), with enabled:cursor-pointer so the affordance matches. That mirrors how the sibling send button already opts out.
expandComposerThenFocus bails before starting the handshake when the editor is disabled. There are six entry points into it (imperative handle, type-to-focus, prompt replacement, stash restore, context insertion), and any of them could otherwise hit the same flash — the guard covers all of them, not just the click.
Verified the happy path is unaffected: on a normal thread the row is enabled and still expands 50px → 144px with the caret landing in the editor.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

macroscopeapp

One consistency finding on the collapsed (resting) composer row, which this PR promotes from a mobile-only state to the desktop resting state.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-08-19T03:45:24Z

Now that the resting row is a desktop state, this hand-rolled send button occupies the same slot as the shared one but does not look like it. The send control in ComposerPrimaryActions.tsx:222-268 is the same 32px circle on desktop, yet it carries shadow-xs + enabled:shadow-message-action/24, enabled:inset-shadow-[0_1px_--theme(--color-white/16%)], hover:scale-105 and active: feedback, and draws a 14px glyph at strokeWidth="1.8"; this copy is flat with a 16px glyph at strokeWidth="2" (line 3075). Clicking the row swaps one for the other in place, so on desktop the send affordance visibly changes weight and gains a shadow/hover-scale the moment the composer expands. The aria-label also stays "Send message" where the shared button reports sendDisabledReason / "Environment disconnected".
Suggest lifting the shared send button's visual (classes + glyph) into one small component and rendering it here too, instead of maintaining a second divergent copy.
^{Posted via Macroscope — UI Consistency}

Agreed, and took the suggested route rather than patching the copy — fixed in 52f0e825f.
New ComposerSendButton component; both the expanded footer and the collapsed resting row render it, so there is no second divergent copy to drift. The label is derived by a shared composerSendButtonLabel() helper, so the collapsed button now reports sendDisabledReason / "Environment disconnected" / "Connecting" / "Preparing worktree" / "Sending" instead of a static "Send message". Extracting it also left Spinner, StageBackdropButtonArt, useSidebarStageBackdropVariant and useEnvironmentIdentificationMode unused in ComposerPrimaryActions, which are now removed.
Measured both states in the browser at 1440px and they are byte-identical: 32x32, 14px glyph at stroke-width 1.8, 0.15s transition, same shadow and same label. Clicking the row no longer changes the send affordance.
Note the two electronPasskeys.test.ts typecheck errors on this branch are pre-existing — I confirmed they reproduce on a clean upstream/main checkout.

Sorry, I'm unable to act on this request because you do not have permissions within this repository.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 52f0e825ff2663926e8bcc0e24dfed28b5e80440. Configure here.}

The resting composer reserved 144px on every thread: a 70px minimum editor that never shrank when empty, plus a 48px toolbar row. That chrome stayed mounted while you were only reading, leaving T3 Code with a noticeably smaller transcript than comparable apps. Collapse it to a single ~50px row whenever it is unfocused. A drafted message stays visible there, muted and truncated, and staged attachments keep the composer open since the row renders text only. Narrow viewports already behaved this way; this drops the width gate so web, desktop and mobile share one rule.

chrisdeeming · 2026-08-21T23:20:37Z

Superseded by #7855.

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 18, 2026

macroscopeappBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx
Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

cursorBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx
Comment threadapps/web/src/components/chat/ChatComposer.tsx
Comment threadapps/web/src/components/chat/ChatComposer.tsx

chrisdeeming force-pushed the fix/composer-resting-height branch from 164e54b to 690627cCompare August 18, 2026 23:39

macroscopeappBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated
Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

cursorBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

chrisdeeming force-pushed the fix/composer-resting-height branch from 690627c to 01ebc6bCompare August 18, 2026 23:48

macroscopeappBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated
Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

cursorBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

chrisdeeming force-pushed the fix/composer-resting-height branch from 01ebc6b to c84ebfdCompare August 18, 2026 23:51

macroscopeappBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated
Comment threadapps/web/src/components/chat/ChatComposer.tsx

macroscopeappBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx

cursorBot reviewed Aug 18, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

chrisdeeming force-pushed the fix/composer-resting-height branch from c84ebfd to 3e02768Compare August 19, 2026 00:05

cursorBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

chrisdeeming force-pushed the fix/composer-resting-height branch from 3e02768 to 6f1ab32Compare August 19, 2026 00:12

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

chrisdeeming force-pushed the fix/composer-resting-height branch from 6f1ab32 to f80fc34Compare August 19, 2026 00:31

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated
Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

chrisdeeming force-pushed the fix/composer-resting-height branch 2 times, most recently from 647ad5f to b1744d3Compare August 19, 2026 00:55

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx

chrisdeeming force-pushed the fix/composer-resting-height branch from b1744d3 to 4ce8dffCompare August 19, 2026 01:03

cursorBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

chrisdeeming force-pushed the fix/composer-resting-height branch from 4ce8dff to 09638f1Compare August 19, 2026 01:32

cursorBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

chrisdeeming force-pushed the fix/composer-resting-height branch from 09638f1 to a1d9c55Compare August 19, 2026 02:03

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

cursorBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx Outdated

chrisdeeming force-pushed the fix/composer-resting-height branch from a1d9c55 to 64abe7eCompare August 19, 2026 02:29

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

chrisdeeming force-pushed the fix/composer-resting-height branch from 64abe7e to 61d1cbeCompare August 19, 2026 02:53

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

chrisdeeming force-pushed the fix/composer-resting-height branch from 61d1cbe to db1b04eCompare August 19, 2026 03:02

cursorBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx

chrisdeeming force-pushed the fix/composer-resting-height branch from db1b04e to ae79b5fCompare August 19, 2026 03:13

macroscopeappBot reviewed Aug 19, 2026
View reviewed changes

chrisdeeming force-pushed the fix/composer-resting-height branch from ae79b5f to 52f0e82Compare August 19, 2026 23:43

github-actionsBot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Aug 19, 2026

cursorBot reviewed Aug 19, 2026
View reviewed changes

Comment threadapps/web/src/components/chat/ChatComposer.tsx

chrisdeeming force-pushed the fix/composer-resting-height branch from 52f0e82 to 49d0019Compare August 19, 2026 23:51

chrisdeeming closed this Aug 21, 2026