Uh oh!
There was an error while loading. Please reload this page.
feat(swift-ios): mark Dev and Test builds in the home title - #7453
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This adds a new configuration-controlled Dev/Test marker to the user-facing Home title while leaving ordinary builds and other runtime flows unchanged. The behavior is small and tested, but its core integration changes an existing shared WorkspaceView, so the bounded additive exception does not fully apply. You can add or adjust custom eligibility rules. Learn more. |
5127c40 to
39f2165CompareEvidence refreshed on current headThe earlier Permanent public media: https://github.com/saphid/t3code/releases/tag/pr-7453-evidence-0bb632164-20260830 |
Dismissing prior approval to re-evaluate 983164b
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 983164b024afda7537266604694c0bd7de0a1864. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Dismissing prior approval to re-evaluate 3bcdfec
Dismissing prior approval to re-evaluate 6737462
6737462 to
cc65bf2Comparecc65bf2 to
0bb6321Compare@t3dotgg Ready for human review. This is classified direct against live SwiftUI target |

1. Observed problem and reproduction
Install Dev, Test, and ordinary SwiftUI builds, then open Home. Before this change, the environments button always read
T3 Code, so Home did not distinguish Dev from Test.2. Cause
The SwiftUI client had no explicit build-channel presentation model. Inferring a channel from bundle identifiers would couple upstream UI to one fork and could mislabel unknown builds.
3. Change and ownership boundary
T3_BUILD_CHANNELsupplied by anxcodebuildargument or local xcconfig expands into the genericT3BuildChannelInfo.plist value. Supported values renderT3 Code Devin the existing number token orT3 Code Testin the existing keyword token. The environments button uses the same title in its accessibility label.The change stays at the SwiftUI Home presentation boundary. It adds one small value model, updates the existing environments button, expands one plist value, documents the setting, and adds focused tests. It does not add a project default or forward this contributor-owned overlay through
install-device.sh.4. Intentionally unchanged
Missing, empty, unexpanded,
upstream, and unknown declarations preserve the ordinaryT3 Codetitle. Offline and reconnecting environment status titles remain higher priority.Bundle identifiers, installed app names, signing and publication workflows, server behavior, providers, contracts, connection modes, web, desktop, and React Native mobile are unchanged. No adjacent cleanup is included.
5. Affected surfaces
T3 Code Dev. Manage environments,T3 Code Test. Manage environments, or the unchanged ordinary label.dev,test,upstream, missing, empty, whitespace, unexpanded, mixed-case, and unknown values.6. Validation on current head
Head
0bb6321643348ddba4efa68bd385c03961544398targets22b22f1463b83963d851bd0574a36a20f224a28dont3code/rebuild-mobile-app-swift.PersonalBuildChannelTests: 7 executed, 7 passed, 0 failed.xcrun swiftc -parse apps/swift-ios/Features/Workspace/PersonalBuildChannel.swift apps/swift-ios/Features/Workspace/WorkspaceView.swift: exit 0.plutil -lint apps/swift-ios/Resources/Info.plist: exit 0,OK.git diff --checkagainst the target: exit 0.T3GitCommitand passcodesign --verify --deep --strict.T3Code.debug.dylibSHA-256,6f0d7897114811bf685add8fdb7a496fbb96deddb817046b7b74626756af64e2. Only the declared build channel differs.An earlier focused-test attempt hit ENOSPC before any test ran. The retained retry on the same suite passed 7/7 after disposable build data was cleared.
7. Risks and limitations
T3_BUILD_CHANNEL. Ordinary upstream builds intentionally supply nothing and stay unmarked.8. UI evidence
All media below comes from fresh builds of current head
0bb632164. The fixture contains one sanitized project and no threads. Dark mode is first, tight title crops are primary, and full-window context is collapsed.Dark mode
Before, unmarked ordinary build
After, Dev build
After, Test build
Ordinary, Dev, and Test comparison
Live action sequence
Clean dark-mode MP4 | Annotated dark-mode MP4
Full-window context, dark mode
Ordinary
Dev
Test
Light mode evidence
Before, unmarked ordinary build
After, Dev build
After, Test build
Ordinary, Dev, and Test comparison
Live action sequence
Clean light-mode MP4 | Annotated light-mode MP4
Full-window context, light mode
Ordinary
Dev
Test
This section supersedes the earlier screenshot-only proof in the PR conversation.
9. Owning issue and target
Owning work item: saphid/t3code-personal#121. Authorized proof batch: saphid/t3code-personal#150. This PR targets
t3code/rebuild-mobile-app-swift.Vouched handoff checklist
0bb632164; the final independent review inspected that commit.Overall handoff: PASS, ready for maintainer review.
Checklist
Implementation: GPT-5.6 Sol high in the Codex harness. Independent review: Claude Opus 5 high, read-only, exit 0, no actionable findings.
Upstream delivery
Delivery: direct
Validated against Theo commit:
c49bcc5d8a56324eb0ad9cf1b19d5dcc6ca0caa0Depends on: none
Merge order: this PR only
Validation status: none of this PR's five changed paths overlaps Theo's new commit; a merge-tree simulation against the live target exited 0. Current head
0bb6321643348ddba4efa68bd385c03961544398has green required CI, 7/7 focused native tests, exact-head signed Simulator proof, a successful direct Claude Opus 5 high review with no actionable findings, successful CodeRabbit/Cursor/Macroscope correctness reviews, and no unresolved threads. All 20 linked proof assets returned HTTP 206 byte ranges on 2026-09-01.Dark mode evidence: yes
Clean screenshot: https://github.com/saphid/t3code/releases/download/pr-7453-evidence-0bb632164-20260830/dev-dark-tight.png
Annotated screenshot: https://github.com/saphid/t3code/releases/download/pr-7453-evidence-0bb632164-20260830/channel-identity-dark-action.gif
Clean video: https://github.com/saphid/t3code/releases/download/pr-7453-evidence-0bb632164-20260830/channel-identity-dark-clean.mp4
Annotated video: https://github.com/saphid/t3code/releases/download/pr-7453-evidence-0bb632164-20260830/channel-identity-dark-annotated.mp4