Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 5.3k
feat(swift-ios): paste images from the composer's native menu#7607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
t3dotgg
merged 7 commits into
pingdotgg:t3code/rebuild-mobile-app-swift
from
mackinleysmith:t3code/swift-ios-composer-pasteAug 20, 2026
+662
−72
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f2fe4d8
feat(swift-ios): paste images from the composer's native menu
mackinleysmith 2fc5997
fix(swift-ios): honor composer refocus after failure alerts
mackinleysmith 42411a6
chore(swift-ios): remove em dashes from composer comments
mackinleysmith ee88099
fix(swift-ios): stop interactive keyboard dismissal fighting draft sc…
mackinleysmith 886a096
fix(swift-ios): keep composer scrolling enabled at every draft size
mackinleysmith c46f7ea
fix(swift-ios): give the new-task composer the same drag-to-dismiss
mackinleysmith 1aef7e8
fix(swift-ios): harden native composer input
t3dotgg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
382 changes: 382 additions & 0 deletions
382 apps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,382 @@ | ||
| import SwiftUI | ||
| import UIKit | ||
| import UniformTypeIdentifiers | ||
| /// The composer's text entry is a UIKit text view because SwiftUI's text | ||
| /// inputs expose no paste hook on iOS: the long-press Paste menu can never | ||
| /// offer an image. Bridging `UITextView` buys the native paste menu, image | ||
| /// paste, and internal scrolling once the draft outgrows its viewport cap. | ||
| struct FeatureComposerTextInput: UIViewRepresentable { | ||
| @Binding var text: String | ||
| // A plain binding, not `FocusState`: SwiftUI ignores writes to a | ||
| // `FocusState` that no `.focused()` view registers with, and a | ||
| // representable cannot register. The UIKit responder state is the source | ||
| // of truth and this binding mirrors it for the hosts. | ||
| @Binding var focused: Bool | ||
| let placeholder: String | ||
| let acceptsImages: Bool | ||
| let selectionRequest: FeatureComposerTextSelectionRequest? | ||
| let onPasteImages: ([NSItemProvider]) -> Void | ||
| let onDismissKeyboard: (() -> Void)? | ||
| func makeCoordinator() -> Coordinator { | ||
| Coordinator(self) | ||
| } | ||
| func makeUIView(context: Context) -> FeatureComposerUITextView { | ||
| let textView = FeatureComposerUITextView() | ||
| textView.delegate = context.coordinator | ||
| textView.acceptsImages = acceptsImages | ||
| textView.onPasteImages = onPasteImages | ||
| textView.onDismissKeyboard = onDismissKeyboard | ||
| if onDismissKeyboard != nil { | ||
| textView.installDismissPanRecognizer() | ||
| } | ||
| textView.backgroundColor = .clear | ||
| textView.textColor = T3Colors.uiTextPrimary | ||
| textView.tintColor = T3Colors.uiAccent | ||
| textView.font = UIFont.preferredFont(forTextStyle: .body) | ||
| textView.adjustsFontForContentSizeCategory = true | ||
| // Match the metrics of the SwiftUI text field this view replaced so | ||
| // the swap is invisible: the surrounding paddings stay in SwiftUI. | ||
| textView.textContainerInset = .zero | ||
| textView.textContainer.lineFragmentPadding = 0 | ||
| textView.isScrollEnabled = true | ||
| // Deliberately not `keyboardDismissMode = .interactive`: the capped | ||
| // input sits directly above the keyboard, so scrolling up through a | ||
| // long draft drags into the keyboard's frame and yanks it around. | ||
| // Dismissal belongs to the pan recognizer below, which only fires | ||
| // for a drag that begins with the draft at its top. | ||
| textView.accessibilityIdentifier = "message-composer" | ||
| updateAccessibility(textView) | ||
| return textView | ||
| } | ||
| func updateUIView(_ textView: FeatureComposerUITextView, context: Context) { | ||
| context.coordinator.parent = self | ||
| textView.acceptsImages = acceptsImages | ||
| textView.onPasteImages = onPasteImages | ||
| textView.onDismissKeyboard = onDismissKeyboard | ||
| let shouldApplySelection = selectionRequest.map { | ||
| context.coordinator.lastAppliedSelectionRequestID != $0.id | ||
| } ?? false | ||
| if textView.text != text { | ||
| let previousText = textView.text ?? "" | ||
| let selectedRange = textView.selectedRange | ||
| textView.text = text | ||
| if !shouldApplySelection { | ||
| let location = FeatureComposerTextSelectionPolicy.cursorLocationAfterBindingUpdate( | ||
| previousText: previousText, | ||
| newText: text, | ||
| selectedLocation: selectedRange.location | ||
| ) | ||
| let length = previousText.isEmpty | ||
| ? 0 | ||
| : min(selectedRange.length, text.utf16.count - location) | ||
| textView.selectedRange = NSRange(location: location, length: length) | ||
| textView.scrollRangeToVisible(textView.selectedRange) | ||
| } | ||
| } | ||
| if shouldApplySelection, let selectionRequest { | ||
| let location = min(selectionRequest.location, textView.text.utf16.count) | ||
| textView.selectedRange = NSRange(location: location, length: 0) | ||
| textView.scrollRangeToVisible(textView.selectedRange) | ||
| context.coordinator.lastAppliedSelectionRequestID = selectionRequest.id | ||
| } | ||
| updateAccessibility(textView) | ||
| if context.coordinator.lastAppliedFocus != focused { | ||
| context.coordinator.lastAppliedFocus = focused | ||
| if focused, !textView.isFirstResponder { | ||
| textView.becomeFirstResponderWhenAttached() | ||
| } else if !focused { | ||
| textView.cancelPendingFirstResponder() | ||
| if textView.isFirstResponder { | ||
| textView.resignFirstResponder() | ||
| } | ||
| } | ||
| } | ||
cursor[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| } | ||
| func sizeThatFits( | ||
| _ proposal: ProposedViewSize, | ||
| uiView: FeatureComposerUITextView, | ||
| context: Context | ||
| ) -> CGSize? { | ||
| guard let width = proposal.width, width.isFinite else { return nil } | ||
| let fittingSize = uiView.sizeThatFits( | ||
| CGSize(width: width, height: .greatestFiniteMagnitude) | ||
| ) | ||
| return CGSize( | ||
| width: width, | ||
| height: FeatureComposerTextInputSizing.height( | ||
| fittingHeight: fittingSize.height, | ||
| lineHeight: uiView.font?.lineHeight ?? 22 | ||
| ) | ||
| ) | ||
| } | ||
| private func updateAccessibility(_ textView: FeatureComposerUITextView) { | ||
| textView.accessibilityLabel = "Message agent" | ||
| textView.accessibilityHint = acceptsImages | ||
| ? "Enter a message or paste images to attach them." | ||
| : "Enter a message." | ||
| textView.accessibilityValue = text.isEmpty ? placeholder : nil | ||
| } | ||
| final class Coordinator: NSObject, UITextViewDelegate { | ||
| var parent: FeatureComposerTextInput | ||
| var lastAppliedFocus: Bool? | ||
| var lastAppliedSelectionRequestID: UUID? | ||
| init(_ parent: FeatureComposerTextInput) { | ||
| self.parent = parent | ||
| } | ||
| func textViewDidChange(_ textView: UITextView) { | ||
| guard parent.text != textView.text else { return } | ||
| parent.text = textView.text | ||
| } | ||
| func textViewDidBeginEditing(_ textView: UITextView) { | ||
| lastAppliedFocus = true | ||
| if !parent.focused { | ||
| parent.focused = true | ||
| } | ||
| } | ||
| func textViewDidEndEditing(_ textView: UITextView) { | ||
| lastAppliedFocus = false | ||
| if parent.focused { | ||
| parent.focused = false | ||
| } | ||
| } | ||
| } | ||
| } | ||
| /// Advertises image support to the paste menu and routes image pastes out to | ||
| /// the attachment pipeline. Text-only pastes fall through to UIKit untouched. | ||
| final class FeatureComposerUITextView: UITextView { | ||
| var acceptsImages = false { | ||
| didSet { | ||
| guard oldValue != acceptsImages else { return } | ||
| pasteConfiguration = acceptsImages | ||
| ? UIPasteConfiguration( | ||
| acceptableTypeIdentifiers: [ | ||
| UTType.image.identifier, | ||
| UTType.text.identifier, | ||
| ] | ||
| ) | ||
| : nil | ||
| } | ||
| } | ||
| var onPasteImages: (([NSItemProvider]) -> Void)? | ||
| var onDismissKeyboard: (() -> Void)? | ||
| private var wantsFirstResponderOnAttach = false | ||
| /// Programmatic focus can arrive before the view joins a window (a host | ||
| /// refocusing right as the composer expands); retry once attached. The | ||
| /// pending request is cancelled if focus clears again before the view | ||
| /// attaches, so a stale request can never raise the keyboard. | ||
| func becomeFirstResponderWhenAttached() { | ||
| if window != nil { | ||
| becomeFirstResponder() | ||
| } else { | ||
| wantsFirstResponderOnAttach = true | ||
macroscopeapp[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| } | ||
| } | ||
| func cancelPendingFirstResponder() { | ||
| wantsFirstResponderOnAttach = false | ||
| } | ||
| override func didMoveToWindow() { | ||
| super.didMoveToWindow() | ||
| if window != nil, wantsFirstResponderOnAttach { | ||
| wantsFirstResponderOnAttach = false | ||
| becomeFirstResponder() | ||
| } | ||
| } | ||
| // A SwiftUI drag gesture on the composer never sees drags that start | ||
| // inside this view: the text interaction's own recognizers claim them at | ||
| // the UIKit level. This observing pan reproduces the host's | ||
| // drag-to-dismiss there: it recognizes alongside everything, cancels | ||
| // nothing, and dismisses a scrollable draft only when the drag begins at | ||
| // its top. | ||
| private let dismissPanDelegate = FeatureComposerDismissPanDelegate() | ||
| func installDismissPanRecognizer() { | ||
| let pan = UIPanGestureRecognizer(target: self, action: #selector(handleDismissPan)) | ||
| pan.cancelsTouchesInView = false | ||
| pan.delegate = dismissPanDelegate | ||
| addGestureRecognizer(pan) | ||
| } | ||
| private var dismissPanBeganAtTop = false | ||
| @objc private func handleDismissPan(_ recognizer: UIPanGestureRecognizer) { | ||
| // A fast flick can jump straight from .began to .ended without a | ||
| // .changed in between, so the end state is evaluated too. The at-top | ||
| // check is latched at .began: a drag that merely reaches the top | ||
| // mid-scroll only rubber-bands, instead of yanking the keyboard away | ||
| // the moment the offset crosses zero. | ||
| switch recognizer.state { | ||
| case .began: | ||
| dismissPanBeganAtTop = contentOffset.y <= 0 | ||
| return | ||
| case .changed, .ended: break | ||
| default: return | ||
| } | ||
| guard isFirstResponder else { return } | ||
| let translation = recognizer.translation(in: self) | ||
| guard FeatureComposerDragDismissPolicy.shouldDismiss( | ||
| translationX: translation.x, | ||
| translationY: translation.y, | ||
| isScrollable: contentOverflows, | ||
| isAtTop: dismissPanBeganAtTop | ||
| ) else { return } | ||
| onDismissKeyboard?() | ||
| } | ||
| // Scrolling stays enabled at every size: toggling `isScrollEnabled` off | ||
| // stops UITextView from maintaining `contentSize` on some OS versions, | ||
| // which left long drafts unscrollable on device. Overflow is computed | ||
| // fresh wherever it matters instead. A stale offset from a mid-resize | ||
| // selection change is still reset; with nothing to scroll, any offset | ||
| // clips the first line under the padding. | ||
| var contentOverflows: Bool { | ||
| contentSize.height > bounds.height + 0.5 | ||
| } | ||
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| if !contentOverflows, contentOffset.y != 0 { | ||
| contentOffset.y = 0 | ||
| } | ||
| } | ||
| override func canPerformAction(_ action: Selector, withSender sender: Any?) -> Bool { | ||
| if action == #selector(paste(_:)), | ||
| acceptsImages, | ||
| FeatureComposerPasteboardPolicy.containsImage(in: UIPasteboard.general) { | ||
| return true | ||
| } | ||
| return super.canPerformAction(action, withSender: sender) | ||
| } | ||
| // When the pasteboard holds images, only the images attach. Any text | ||
| // riding along (a copied web image usually brings its URL) is dropped on | ||
| // purpose: Slack and X do the same, and inserting a stray URL next to an | ||
| // attached screenshot reads as a bug. | ||
| override func paste(_ sender: Any?) { | ||
| guard acceptsImages else { | ||
| super.paste(sender) | ||
| return | ||
| } | ||
| let imageProviders = UIPasteboard.general.itemProviders.filter { | ||
| $0.hasItemConformingToTypeIdentifier(UTType.image.identifier) | ||
| } | ||
| guard !imageProviders.isEmpty else { | ||
| super.paste(sender) | ||
| return | ||
| } | ||
| onPasteImages?(imageProviders) | ||
| } | ||
| } | ||
| /// A standalone delegate (rather than the text view itself, whose scroll-view | ||
| /// superclass already takes part in gesture delegation) so the observing pan | ||
| /// reliably recognizes alongside the text interaction's own recognizers | ||
| /// instead of being cancelled by them. | ||
| private final class FeatureComposerDismissPanDelegate: NSObject, UIGestureRecognizerDelegate { | ||
| func gestureRecognizer( | ||
| _ gestureRecognizer: UIGestureRecognizer, | ||
| shouldRecognizeSimultaneouslyWith otherGestureRecognizer: UIGestureRecognizer | ||
| ) -> Bool { | ||
| true | ||
| } | ||
| } | ||
| /// Mirrors the thread view's composer drag-to-dismiss thresholds: a clearly | ||
| /// vertical downward drag. While the draft is scrollable, scrolling back | ||
| /// through it never drops the keyboard mid-read, but a drag that *begins* | ||
| /// with the draft at its top only rubber-bands, which is unambiguous | ||
| /// dismissal intent (and the composer's only escape hatch once it and the | ||
| /// keyboard cover the transcript). `isAtTop` is the position at drag start, | ||
| /// so a scroll that reaches the top never dismisses mid-gesture. | ||
| enum FeatureComposerDragDismissPolicy { | ||
| static func shouldDismiss( | ||
| translationX: CGFloat, | ||
| translationY: CGFloat, | ||
| isScrollable: Bool, | ||
| isAtTop: Bool | ||
| ) -> Bool { | ||
| (!isScrollable || isAtTop) | ||
| && translationY > 8 | ||
| && translationY > abs(translationX) | ||
| } | ||
| } | ||
| enum FeatureComposerPasteboardPolicy { | ||
| /// `UIPasteboard.hasImages` misses formats that merely conform to image | ||
| /// (HEIC screenshots among them), so detection goes through UTType | ||
| /// conformance instead. | ||
| static func containsImage(in pasteboard: UIPasteboard) -> Bool { | ||
| pasteboard.itemProviders.contains { | ||
| $0.hasItemConformingToTypeIdentifier(UTType.image.identifier) | ||
| } | ||
| } | ||
| } | ||
| /// A one-shot caret placement, applied by the text input exactly once per | ||
| /// request `id`. Command completion issues one so the caret lands after the | ||
| /// inserted text instead of wherever UIKit leaves it after a programmatic | ||
| /// text replacement. | ||
| struct FeatureComposerTextSelectionRequest: Equatable { | ||
| let id = UUID() | ||
| let location: Int | ||
| } | ||
| enum FeatureComposerTextSelectionPolicy { | ||
| /// UTF-16 caret location after `range` (character indices, as produced by | ||
| /// the trigger parser) is replaced with `replacement`. | ||
| static func cursorLocation( | ||
| afterReplacing range: Range<Int>, | ||
| in text: String, | ||
| with replacement: String | ||
| ) -> Int { | ||
| let lower = min(max(range.lowerBound, 0), text.count) | ||
| let lowerIndex = text.index(text.startIndex, offsetBy: lower) | ||
| return text[..<lowerIndex].utf16.count + replacement.utf16.count | ||
| } | ||
| /// Caret location after the binding changed underneath the text view. A | ||
| /// restored draft (previous text empty) puts the caret at the end; any | ||
| /// other external rewrite keeps the caret where it was, clamped into the | ||
| /// new text. | ||
| static func cursorLocationAfterBindingUpdate( | ||
| previousText: String, | ||
| newText: String, | ||
| selectedLocation: Int | ||
| ) -> Int { | ||
| previousText.isEmpty ? newText.utf16.count : min(selectedLocation, newText.utf16.count) | ||
| } | ||
| } | ||
| /// Cap-then-scroll, the way Messages and Slack grow their composers: the | ||
| /// input tracks its content until it reaches a fixed line cap, then holds | ||
| /// that height and scrolls internally. The cap deliberately ignores the | ||
| /// SwiftUI height proposal: proposals here derive from this view's own | ||
| /// previous answer, so scaling by them feeds back and collapses the input. | ||
| enum FeatureComposerTextInputSizing { | ||
| static let maximumLines: CGFloat = 12 | ||
| static func height( | ||
| fittingHeight: CGFloat, | ||
| lineHeight: CGFloat | ||
| ) -> CGFloat { | ||
| min(fittingHeight, lineHeight * maximumLines) | ||
| } | ||
| } | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.