feat(swift-ios): attach images dragged onto the composer

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[mackinleysmith]

Note

Stacked on #7607. GitHub cannot base a fork PR on another fork branch, so this diff includes #7607's commits until it merges, then collapses to the three commits from 68e62e3ee to eecebf4d2. Review those only.

Problem

The composer takes images from the photo picker and, with #7607, from the paste menu. Dragging an image from another app onto it does nothing.

Solution

Dropped images attach through the same intake path as paste. The design follows @saphid's #5610: the drop target registers only .image, so the drag session refuses non-images and a rejected PDF never needs an error dialog. An accent highlight marks the composer while a valid drop is over it. Two device-found details keep the session honest. The drop goes through an explicit DropDelegate that proposes a copy, since a system-sourced drag (the screenshot thumbnail, Photos) is refused under SwiftUI's default proposal. And the text view declines image drags in canPaste: while editing, UIKit offers it any drag its paste configuration (from #7607) says it can paste, and when it won the release it discarded the image through its text-only default while the surface's highlight stayed lit. Text drags and the image paste menu are unchanged.

The cap and ordinal math paste carried inline moved into FeatureComposerImageIntakePlan, now shared by paste and drop. Paste behavior is unchanged: eight-image cap, overflow message, and send stays blocked until preparation finishes. When the selected model does not accept images the drop is refused, so the drag shows the system's "not allowed" badge.

Verification

• Full Swift test suite on the iPhone 17 Pro simulator: 402 passed, 0 failed, 1 skipped.
• On an iPhone 14 Pro with the keyboard up: three screenshots dragged from their thumbnails onto the text area land in the attachment strip one after another, highlight clearing each time.
• New ComposerImageIntakeTests cover the cap, in-flight accounting, ordinal continuation, and overshoot truncation.

UI changes

Built with Claude Fable 5 in Claude Code.

---

Note

Medium Risk
Touches image attachment intake and UIKit drop/paste ownership, which can drop or mis-handle files if the session or cap accounting is wrong. No auth or backend changes.

Overview
Users can drag images from another app onto the iOS composer; they attach through the same pipeline as paste (eight-image cap, overflow alert, send blocked until preparation finishes).

The drop target accepts only .image and shows an accent highlight while targeted. It proposes a copy so system drags (screenshot thumbnails, Photos) actually land. The text view declines image drops so UIKit does not swallow them as text-only paste while the highlight stays lit.

Cap and ordinal math now live in FeatureComposerImageIntakePlan. Provider loads start inside the drop/paste callback so access remains valid after the session ends. Drops are refused when the model does not accept images.

^{Reviewed by Cursor Bugbot for commit 21c16ce. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add image drag-and-drop support to the iOS composer

• Introduces FeatureComposerImageDrop view modifier and FeatureComposerImageDropDelegate to highlight the composer surface during a valid image drag and forward dropped image NSItemProviders to the attach handler
• Adds FeatureComposerImageIntakePlan to compute how many incoming providers fit under the eight-image cap (including in-flight items) and what ordinal to start at, returning nil when capacity is exhausted
• Refactors FeatureImageItemProviderLoader so loads can start inside the drop/paste callback via start(from:) and be awaited later, sharing one intake path for both paste and drop
• Overrides FeatureComposerUITextView.canPaste(_:) to decline image items so the composer surface owns the drag session and its highlight; non-image pastes still pass through
• Updates user docs in composer.md to mention drag-to-attach alongside the existing paste flow
• Risk: canPaste override in FeatureComposerUITextView returns false whenever any NSItemProvider conforms to UTType.image; mixed image+text drops will not paste text into the text view

^{Macroscope summarized 21c16ce.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a6dca2c8-e58a-4249-a59f-9f3e62f24289

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 68e62e3ee00f4391b6c31fa90ab1ac3392b75c2e. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces new user-facing functionality (drag-and-drop image attachment) with new UI components and integration points. While well-tested and scoped to the composer feature, new capabilities of this type benefit from human review.

^{You can add or adjust custom eligibility rules. Learn more.}