feat(web): pull request files can be marked as viewed

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);

apps/server/package.json

@@ -30,6 +30,7 @@
  "@ff-labs/fff-node": "0.9.4",
  "@opencode-ai/sdk": "^1.3.15",
  "@pierre/diffs": "catalog:",
+ "diff": "8.0.3",
  "effect": "catalog:",
  "msgpackr-extract": "3.0.4",
  "node-pty": "^1.1.0",

apps/server/src/auth/RpcAuthorization.ts

@@ -58,6 +58,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
+ [WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,
  [WS_METHODS.pullRequestsRunAction]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsUpdate]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsComment]: AuthOrchestrationOperateScope,
@@ -66,6 +67,7 @@ export const RPC_REQUIRED_SCOPES = {
  [WS_METHODS.pullRequestsReplyToThread]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetThreadResolution]: AuthOrchestrationOperateScope,
  [WS_METHODS.pullRequestsSetReaction]: AuthOrchestrationOperateScope,
+ [WS_METHODS.pullRequestsSetFilesViewed]: AuthOrchestrationOperateScope,
  // Read scope like the reads it un-caches: refreshing is part of reading, and a read-only
  // client pressing refresh must not be told it may not look again.
  [WS_METHODS.pullRequestsInvalidate]: AuthOrchestrationReadScope,

apps/server/src/persistence/Errors.ts

@@ -134,5 +134,6 @@ export type OrchestrationCommandReceiptRepositoryError =
 export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
+export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
 
 export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

apps/server/src/persistence/Migrations.ts

@@ -56,6 +56,7 @@ import Migration0040 from "./Migrations/040_ProjectionProjectFaviconPath.ts";
 import Migration0041 from "./Migrations/041_AuthSessionClientConnection.ts";
 import Migration0042 from "./Migrations/042_ProjectionThreadLinkedPullRequest.ts";
 import Migration0043 from "./Migrations/043_ProjectionThreadsUnsettledAt.ts";
+import Migration0044 from "./Migrations/044_PullRequestFilesViewed.ts";
 
 /**
  * Migration loader with all migrations defined inline.
@@ -111,6 +112,7 @@ export const migrationEntries = [
  [41, "AuthSessionClientConnection", Migration0041],
  [42, "ProjectionThreadLinkedPullRequest", Migration0042],
  [43, "ProjectionThreadsUnsettledAt", Migration0043],
+ [44, "PullRequestFilesViewed", Migration0044],
 ] as const;
 
 export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

apps/server/src/persistence/Migrations/044_PullRequestFilesViewed.ts

@@ -0,0 +1,24 @@
+import * as Effect from "effect/Effect";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+
+export default Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ // One row per file a reader has cleared on a host that keeps no record of its own. `revision`
+ // is what the file was when it was cleared, so a push that changes it is reported as changed
+ // rather than silently left ticked. Unticking deletes the row: absent is the resting state, and
+ // a table of "not viewed" rows would grow with every diff anybody scrolled past.
+ yield* sql`
+ CREATE TABLE IF NOT EXISTS pull_request_files_viewed (
+ provider TEXT NOT NULL,
+ host TEXT NOT NULL,
+ repository TEXT NOT NULL,
+ number INTEGER NOT NULL,
+ viewer TEXT NOT NULL,
+ path TEXT NOT NULL,
+ revision TEXT NOT NULL,
+ viewed_at TEXT NOT NULL,
+ PRIMARY KEY (provider, host, repository, number, viewer, path)
+ ) WITHOUT ROWID
+ `;
+});

apps/server/src/persistence/PullRequestFilesViewed.ts

@@ -0,0 +1,156 @@
+import * as Context from "effect/Context";
+import * as Effect from "effect/Effect";
+import * as Layer from "effect/Layer";
+import * as Schema from "effect/Schema";
+import * as SqlClient from "effect/unstable/sql/SqlClient";
+import * as SqlSchema from "effect/unstable/sql/SqlSchema";
+
+import { SourceControlProviderKind } from "@t3tools/contracts";
+
+import {
+ PersistenceDecodeError,
+ PersistenceSqlError,
+ type PullRequestFilesViewedRepositoryError,
+} from "./Errors.ts";
+
+/**
+ * Which change request, on which host, for which reader.
+ *
+ * The host is part of it because a repository path is not unique across installs: the same
+ * `group/project` exists on gitlab.com and on a self-managed instance, and a mark made against one
+ * must not turn up on the other. The reader is part of it for the same reason the host's own
+ * record is per-account: signing in as somebody else must not inherit their ticks. A host that
+ * will not say who the reader is leaves it empty, which is one reader rather than none.
+ */
+export const PullRequestFilesViewedScope = Schema.Struct({
+ provider: SourceControlProviderKind,
+ host: Schema.String,
+ repository: Schema.String,
+ number: Schema.Int,
+ viewer: Schema.String,
+});
+export type PullRequestFilesViewedScope = typeof PullRequestFilesViewedScope.Type;
+
+/** A file this reader cleared, and what it was when they cleared it. */
+export const PullRequestFileViewedMark = Schema.Struct({
+ path: Schema.String,
+ /**
+ * The host's own name for that version of the file, opaque here. Empty where the host had none
+ * to give, which is its own answer rather than a missing one: a file with no version at the head
+ * is one the change request deletes, and it stays deleted.
+ */
+ revision: Schema.String,
+});
+export type PullRequestFileViewedMark = typeof PullRequestFileViewedMark.Type;
+
+export interface SetPullRequestFilesViewedInput extends PullRequestFilesViewedScope {
+ readonly files: ReadonlyArray<PullRequestFileViewedMark & { readonly viewed: boolean }>;
+ /** When the presses landed, as an ISO instant. */
+ readonly viewedAt: string;
+}
+
+/**
+ * The marks this environment keeps for hosts that keep none of their own.
+ *
+ * Only cleared files are rows. Unticking deletes rather than writing a "not viewed" row, so the
+ * table holds what a reader has done and not what they have merely scrolled past.
+ */
+export class PullRequestFilesViewedRepository extends Context.Service<
+ PullRequestFilesViewedRepository,
+ {
+ readonly list: (
+ input: PullRequestFilesViewedScope,
+ ) => Effect.Effect<
+ ReadonlyArray<PullRequestFileViewedMark>,
+ PullRequestFilesViewedRepositoryError
+ >;
+ readonly set: (
+ input: SetPullRequestFilesViewedInput,
+ ) => Effect.Effect<void, PullRequestFilesViewedRepositoryError>;
+ }
+>()("t3/persistence/PullRequestFilesViewed/PullRequestFilesViewedRepository") {}
+
+function toSqlOrDecodeError(sqlOperation: string, decodeOperation: string) {
+ return (cause: unknown): PullRequestFilesViewedRepositoryError =>
+ Schema.isSchemaError(cause)
+ ? PersistenceDecodeError.fromSchemaError(decodeOperation, cause)
+ : new PersistenceSqlError({ operation: sqlOperation, cause });
+}
+
+export const make = Effect.gen(function* () {
+ const sql = yield* SqlClient.SqlClient;
+
+ const listRows = SqlSchema.findAll({
+ Request: PullRequestFilesViewedScope,
+ Result: PullRequestFileViewedMark,
+ execute: ({ provider, host, repository, number, viewer }) =>
+ sql`
+ SELECT
+ path AS "path",
+ revision AS "revision"
+ FROM pull_request_files_viewed
+ WHERE provider = ${provider}
+ AND host = ${host}
+ AND repository = ${repository}
+ AND number = ${number}
+ AND viewer = ${viewer}
+ `,
+ });
+
+ return PullRequestFilesViewedRepository.of({
+ list: (input) =>
+ listRows(input).pipe(
+ Effect.mapError(toSqlOrDecodeError("listPullRequestFilesViewed", "PullRequestFileViewed")),
+ ),
+
+ // One statement per file rather than one for the batch: the batch is what a reader ticked in
+ // the last few hundred milliseconds, so it is a handful of rows on a local database, and a
+ // mixed batch of clears and un-clears has no single statement anyway.
+ set: (input) =>
+ Effect.forEach(
+ input.files,
+ (file) =>
+ file.viewed
+ ? sql`
+ INSERT INTO pull_request_files_viewed (
+ provider,
+ host,
+ repository,
+ number,
+ viewer,
+ path,
+ revision,
+ viewed_at
+ )
+ VALUES (
+ ${input.provider},
+ ${input.host},
+ ${input.repository},
+ ${input.number},
+ ${input.viewer},
+ ${file.path},
+ ${file.revision},
+ ${input.viewedAt}
+ )
+ ON CONFLICT (provider, host, repository, number, viewer, path)
+ DO UPDATE SET revision = excluded.revision, viewed_at = excluded.viewed_at
+ `
+ : sql`
+ DELETE FROM pull_request_files_viewed
+ WHERE provider = ${input.provider}
+ AND host = ${input.host}
+ AND repository = ${input.repository}
+ AND number = ${input.number}
+ AND viewer = ${input.viewer}
+ AND path = ${file.path}
+ `,
+ { discard: true },
+ ).pipe(
+ Effect.mapError(
+ (cause) => new PersistenceSqlError({ operation: "setPullRequestFilesViewed", cause }),
+ ),
+ ),
+ });
+});
+
+export const layer = Layer.effect(PullRequestFilesViewedRepository, make);