Uh oh!
There was an error while loading. Please reload this page.
fix(web): keep thread sidebar populated across Settings round-trips - #7864
fix(web): keep thread sidebar populated across Settings round-trips#7864Exotic209093 wants to merge 1 commit into
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Simple UX bug fix that adds a hook subscription to prevent thread sidebar flicker when navigating to/from Settings. Follows the existing pattern for project retention in the same component. You can add or adjust custom eligibility rules. Learn more. |
t3dotgg
commented
Aug 27, 2026
Note 🤖 GPT-5.6 Sol responding on behalf of Theo We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together. Closing this duplicate of #7744. Both keep the thread-shell subscription active while Settings replaces the sidebar. #5930 supplied the older project-retention foundation, but did not complete this thread-shell fix. #7744 remains open for review, so this closure does not mean the behavior has shipped. If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed. If GitHub does not let you reopen it, leave a comment here and we'll take another look. |
Problem
Opening Settings and pressing Back briefly renders the thread sidebar empty before rows fade back in. Settings replaces the sidebar in the React tree, which drops the thread-shell projection subscription (the project projection was already retained by #5930). On return, the remounted list replays its FormKit add-animation for rows the user already had.
Fix
Extended the existing projection-retention component in \AppSidebarLayout.tsx\ to keep \useThreadShells()\ subscribed alongside \useProjects(), renaming it to \SidebarProjectionRetention. With the projection kept warm, rows render immediately on Back, so no separate animation workaround is needed.
Fixes#7743
ox-alpha via opencode
Note
Low Risk
Small UI subscription change in sidebar layout only; no auth, data, or API behavior changes.
Overview
Fixes a flash of empty thread rows (and replayed add animations) when leaving Settings and returning to a draft.
Settings unmounts the thread sidebar, which dropped the
useThreadShells()subscription. The existing layout-level retention helper now also keeps that projection warm (renamed toSidebarProjectionRetention), so rows render immediately on Back.Reviewed by Cursor Bugbot for commit d1757da. Configure here.
Note
Retain thread shells in
SidebarProjectionRetentionto fix empty sidebarRenames
ProjectProjectionRetentiontoSidebarProjectionRetentionin AppSidebarLayout.tsx and adds auseThreadShells()subscription alongsideuseProjects(). This keeps thread-shell state cached during navigation to Settings, preventing the sidebar from emptying on return.Macroscope summarized d1757da.