feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(web): add toggle shortcut for settling threads - #7881

Closed
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut
Closed

feat(web): add toggle shortcut for settling threads#7881
UtkarshUsername wants to merge 16 commits into
pingdotgg:mainfrom
UtkarshUsername:feat/thread-settle-toggle-shortcut

Conversation

@UtkarshUsername

@UtkarshUsernameUtkarshUsername commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What Changed

Add shortcut to settle the active thread with default mod+shift+s (when: !terminalFocus). Dispatch in ChatRouteGlobalShortcuts (apps/web/src/routes/_chat.tsx) toggles the active thread using effectiveSettled classification (mirroring Sidebar partition) and calls settleThread/unsettleThread.

Why

Settling a thread had no keyboard shortcut. It was only available via sidebar hover, action menu, and header menu.

Video

settle.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Mutates thread settlement from a global shortcut using live VCS status and auto-settle settings; a stale or missing git status could toggle the opposite of the visible UI.

Overview
Adds a thread.settle.toggle shortcut (default mod+shift+s, when not in the terminal) so the active thread can be settled or un-settled from the keyboard, matching the banner/header menu.

The chat-route global handler classifies the thread with effectiveSettled using live VCS status plus change-request snapshots, then calls settleThread / unsettleThread. It no-ops without an active thread, on key repeat, or if the environment lacks threadSettlement, and toasts non-interrupted failures.

Reviewed by Cursor Bugbot for commit af57392. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add thread.settle.toggle shortcut bound to mod+shift+s in chat route

  • Registers the new thread.settle.toggle command in keybindings.ts and maps it to mod+shift+s when !terminalFocus in keybindings.ts
  • The handler in _chat.tsx resolves the displayed PR against live VCS status and snapshots, computes effectiveSettled with minute-quantized time and auto-settle settings, then calls settleThread or unsettleThread accordingly
  • Shows an error toast on non-interrupted command failure; no action when no active thread/shell, command repeats, or the environment lacks threadSettlement capability
  • Risk: the handler reads several reactive values (activeThreadShell, gitStatusQuery.data, serverConfigs, auto-settle settings) into the keydown effect's dependency array — stale or missing VCS status data could cause incorrect settle/unsettle decisions

Macroscope summarized af57392.

Settling a thread had no keyboard shortcut. Add thread.settle.toggle
(command ID thread.settle.toggle) with default mod+shift+s
(when: !terminalFocus) and dispatch in ChatRouteGlobalShortcuts. The
handler toggles the active thread via effectiveSettled classification
(mirroring Sidebar partition) and calls settleThread/unsettleThread.
No mobile changes; desktop inherits via web.
@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5165ec70-43f3-4fc5-a871-e031f5782a83

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
@macroscopeapp

macroscopeappBot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new global shortcut that performs persistent settle/un-settle mutations and relies on active-thread and PR/VCS state classification. The behavior is focused and reuses existing actions, but its user-facing lifecycle impact warrants human review.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

Sidebar partitions snoozed threads before settled ones, but the
toggle only excluded pinned threads. A snoozed thread that also
satisfies effectiveSettled was treated as settled and would be
unsettle-d instead of settled. Mirror the partition ordering by
checking effectiveSnoozed first.
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

Fixed: exclude snoozed threads from isSettled to match Sidebar partition ordering (snoozed outranks settled). Now checks effectiveSnoozed before effectiveSettled - a snoozed thread that also satisfies effectiveSettled will correctly settle instead of being incorrectly unsettled. See 6fe4f8a.

@UtkarshUsername
UtkarshUsername marked this pull request as draft August 22, 2026 09:35
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 22, 2026 15:14
Comment threadapps/web/src/routes/_chat.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new thread.settle.toggle shortcut classifies the open thread's settled state differently from the two surfaces that display that state for the same thread, so the shortcut can do the opposite of the visible affordance. Details inline on apps/web/src/routes/_chat.tsx.

No styling, primitive, or Tailwind/CSS ownership issues in this diff.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
The snoozed/pinned exclusions mirrored the sidebar list partition, but
the surfaces the user sees on the open thread (parked-thread banner,
header menu) classify with effectiveSettled alone. Classify the same
way so the shortcut never disagrees with the visible Un-settle button.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle toggle resolves its changeRequest input from a different source than the two surfaces it is documented to match, so the toggle direction can invert relative to what the user sees.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx
The snapshot map is only written by sidebar v2 rows, so on the legacy
sidebar (or before a row mounts) the shortcut classified with no PR
while the banner and menu used the live one. Resolve through
resolveDisplayedThreadPr over the same vcsEnvironment.status query
ChatView uses, so all three surfaces agree.
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Aug 22, 2026
Comment threadapps/web/src/routes/_chat.tsx Outdated
Comment threadapps/web/src/routes/_chat.tsx
Comment threadapps/web/src/routes/_chat.tsx Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c56333. Configure here.

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the new pending-state fallback makes the settle shortcut classify the open thread differently from the banner and header menu that render its settled state. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the settle-toggle's PR resolution can disagree with the settled state the same thread renders in ChatView's banner and the chat-header menu. Details inline.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/routes/_chat.tsx Outdated
UtkarshUsernameand others added 2 commits August 23, 2026 14:15
The pending-status snapshot fallback diverged from the banner and menu
(both resolve unconditionally) and could go stale on a failed status
query. Match ChatView's resolution exactly; the loading window behaves
the same as the surfaces the user already sees.
@UtkarshUsername
UtkarshUsername marked this pull request as draft August 23, 2026 18:21
@UtkarshUsername
UtkarshUsername marked this pull request as ready for review August 23, 2026 18:50
@UtkarshUsername

Copy link
Copy Markdown
ContributorAuthor

#8089

@UtkarshUsername
UtkarshUsername deleted the feat/thread-settle-toggle-shortcut branch August 25, 2026 05:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@UtkarshUsername