feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(web): open remote worktrees in Zed - #7900

Closed
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees
Closed

feat(web): open remote worktrees in Zed#7900
husseinraoouf wants to merge 2 commits into
pingdotgg:mainfrom
husseinraoouf:t3code/support-zed-remote-worktrees

Conversation

@husseinraoouf

@husseinraooufhusseinraoouf commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Closes#7899

Problem

The generalized remote editor links from #6572 only understand VS Code's vscode-remote URL shape. Zed therefore remains local-only even though #4361 was closed, while its older dedicated implementation in #4362 predates the generalized flow. Zed Preview was not tracked.

Fix

  • describe each remote-capable editor's URL shape in the shared editor registry
  • build Zed's official zed://ssh/<host>/<path> hotlinks while preserving the existing host/path encoding
  • include Zed in the desktop-side local editor probe
  • allow only structurally valid Zed SSH hotlinks through Electron's external URL boundary
  • document that stable Zed and Zed Preview share the zed:// handler, so users select Preview by registering the scheme from Preview

This follows Zed's documented remote-development URL format and its shared release-channel URL scheme. It avoids reviving the separate Zed-only IPC path from #4362.

Verification

  • vp test run apps/web/src/remoteOpen.test.ts apps/desktop/src/electron/ElectronShell.test.ts � 20 tests passed
  • vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheck
  • targeted vp lint for changed TypeScript files
  • targeted vp fmt --check for all changed files
  • git diff --check

UI changes

No layout or styling changes. Zed now appears in the existing remote Open picker when its local CLI is detected.

Implemented by Codex (gpt-5.6-sol) through the T3 Code Codex harness.


Note

Medium Risk
Changes Electron’s external URL allowlist and deep-link generation; mistakes could open unsafe custom schemes or break remote open for VS Code-family editors.

Overview
Adds Zed to the shared remote “Open in editor” flow using Zed’s zed://ssh/<host>/<path> hotlinks, alongside the existing VS Code-family vscode-remote shape.

The editor registry now declares a RemoteEditorUrlStyle per remote-capable editor; buildRemoteOpenUrl branches on that style (Zed vs VS Code forks). REMOTE_CAPABLE_EDITOR_IDS only includes editors with both scheme and style, so Zed shows up in the remote Open picker when its CLI is detected.

On desktop, ElectronShell validates editor deep links by style—allowing well-formed Zed SSH URLs while still blocking unrelated zed:// routes and URLs with userinfo. Tests and user docs cover Zed/Zed Preview scheme registration.

Reviewed by Cursor Bugbot for commit 4113f02. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Zed as a remote-capable editor with zed://ssh/ deep links

  • Introduces RemoteEditorUrlStyle union type and optional remoteUrlStyle on EditorDefinition in editor.ts, so each remote editor declares its deep-link shape
  • Adds remoteScheme: 'zed' and remoteUrlStyle: 'zed-ssh' to the Zed editor entry; VS Code-family editors now explicitly declare remoteUrlStyle: 'vscode-remote'"- buildRemoteOpenUrl builds zed://ssh/<host>/<path> for Zed and continues to build <scheme>://vscode-remote/ssh-remote+<host><path> for VS Code-family; returns undefined when either scheme or style is missing
  • isRemoteEditorUrl in ElectronShell.ts replaces the flat protocol allowlist with a protocol→style Map and validates URL shape per style: Zed links require host ssh plus non-empty host and path segments; VS Code links require host vscode-remote and a /ssh-remote+ prefix
  • Behavioral Change: REMOTE_CAPABLE_EDITOR_IDS now requires both remoteScheme and remoteUrlStyle; editors missing either are excluded from remote-capable listings. Malformed Zed URLs (non-remote or missing path) are now rejected

Macroscope summarized 4113f02.

@coderabbitai

coderabbitaiBot commented Aug 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c8d7816-d8b4-4997-8cfc-1093235c01c7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 22, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Skipped

Macroscope did not run approvability analysis for this PR. Macroscope could not determine whether this PR modifies its approvability configuration, so the PR was not approved automatically. A PR that may change the rules that govern approval is never approved automatically.

@husseinraoouf

Copy link
Copy Markdown
ContributorAuthor

@juliusmarminge i know you have alot on your plate, but i would appreciate if you could get this into nightly it would be a huge un-blocker for me

@kaladivo

kaladivo commented Aug 30, 2026

Copy link
Copy Markdown

+1. I would also love this feature to be merged!

@juliusmarminge

Copy link
Copy Markdown
Member

Closing in favor of #8866, which covers the same Zed SSH links and adds browser support and desktop protocol-handler detection. Please carry over the note here about registering the shared zed:// scheme from Zed Preview.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open remote worktrees in local Zed or Zed Preview

3 participants

@husseinraoouf@kaladivo@juliusmarminge