Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/mobile/src/features/threads/ThreadComposer.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -552,7 +552,10 @@ export const ThreadComposer = memo(function ThreadComposer(props: ThreadComposer
if (inFlightThreadIdsRef.current.has(threadKey)) return;
inFlightThreadIdsRef.current.add(threadKey);
try {
await onSendMessage();
const messageId = await onSendMessage();
if (messageId === null) {
return;
}
// Sending a prompt starts agent work: arm the lock-screen card while the
// app is foregrounded and the activity token can be registered. Armed
// after the send so its preference read and native Activity start don't
Expand Down
67 changes: 67 additions & 0 deletions apps/mobile/src/lib/threadActivity.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import { describe, expect, it } from "vite-plus/test";
import { codexFeedbackMessage } from "@t3tools/client-runtime/state/threads";

import {
EventId,
Expand All@@ -22,6 +23,34 @@ import {
type ThreadFeedEntry,
} from "./threadActivity";

describe("Codex feedback pseudo-messages", () => {
it("keeps pending and completed feedback messages in the mobile thread body", () => {
const pending = {
id: MessageId.make("feedback-command"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:00.000Z",
status: "uploading" as const,
};
const entries = [codexFeedbackMessage(pending), codexFeedbackMessage(pending, "assistant")].map(
(message) => ({
type: "message" as const,
id: message.id,
createdAt: message.createdAt,
message,
}),
);

expect(deriveThreadFeedPresentation(entries, null, new Set())).toEqual(entries);
expect(entries[1]?.message.text).toBe("Sending feedback to OpenAI...");

const completed = codexFeedbackMessage(
{ ...pending, status: "sent", feedbackId: "codex-thread-1" },
"assistant",
);
expect(completed.text).toContain("codex-thread-1");
});
});

const singleSelectQuestion = {
id: "runtime",
header: "Runtime",
Expand DownExpand Up@@ -151,6 +180,44 @@ function makeThread(
}

describe("buildThreadFeed", () => {
it("keeps older local feedback before newer messages returned by the server", () => {
const submission = {
id: MessageId.make("feedback-command-ordering"),
command: "/feedback The agent stopped early.",
createdAt: "2026-08-23T00:00:01.000Z",
status: "sent" as const,
feedbackId: "codex-thread-1",
};
const laterMessage = {
id: MessageId.make("later-server-message"),
role: "assistant" as const,
text: "Newer server response",
turnId: null,
createdAt: "2026-08-23T00:00:02.000Z",
updatedAt: "2026-08-23T00:00:02.000Z",
streaming: false,
};
const thread = makeThread({
id: ThreadId.make("thread-feedback-ordering"),
projectId: ProjectId.make("project-1"),
title: "Feedback ordering",
messages: [laterMessage],
});

const feed = buildThreadFeed(thread, {
localMessages: [
codexFeedbackMessage(submission),
codexFeedbackMessage(submission, "assistant"),
],
});

expect(feed.map((entry) => entry.id)).toEqual([
"feedback-command-ordering",
"feedback-command-ordering:feedback",
"later-server-message",
]);
});

it("keeps historic work entries attributed to their turns", () => {
const thread = makeThread({
id: ThreadId.make("thread-1"),
Expand Down
6 changes: 5 additions & 1 deletion apps/mobile/src/lib/threadActivity.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -1526,15 +1526,19 @@ export function buildThreadFeed(
thread: OrchestrationThread,
options?: {
readonly loadedMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
readonly localMessages?: ReadonlyArray<OrchestrationThread["messages"][number]>;
},
): ThreadFeedEntry[] {
const loadedMessages = options?.loadedMessages ?? thread.messages;
const messages = options?.localMessages
? [...loadedMessages, ...options.localMessages]
: loadedMessages;
const oldestLoadedMessageCreatedAt =
options?.loadedMessages !== undefined ? (loadedMessages[0]?.createdAt ?? null) : null;
const workLogEntries = deriveWorkLogEntries(thread.activities);
const entries = Arr.sortWith(
[
...loadedMessages.map<RawThreadFeedEntry>((message) => ({
...messages.map<RawThreadFeedEntry>((message) => ({
type: "message",
id: message.id,
createdAt: message.createdAt,
Expand Down
112 changes: 105 additions & 7 deletions apps/mobile/src/state/use-thread-composer-state.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
import { useAtomValue } from "@effect/atom-react";
import { useCallback, useEffect, useMemo } from "react";
import { useCallback, useEffect, useMemo, useState } from "react";
import { Alert } from "react-native";
import * as Cause from "effect/Cause";

import {
CommandId,
Expand All@@ -11,6 +13,13 @@ import {
type ThreadId,
} from "@t3tools/contracts";
import { safeErrorLogAttributes } from "@t3tools/client-runtime/errors";
import {
codexFeedbackMessage,
parseCodexFeedbackCommand,
submitCodexFeedback,
type CodexFeedbackSubmission,
} from "@t3tools/client-runtime/state/threads";
import { isAtomCommandInterrupted } from "@t3tools/client-runtime/state/runtime";
import { deriveActiveWorkStartedAt } from "@t3tools/shared/orchestrationTiming";

import { makeQueuedMessageMetadata } from "../lib/commandMetadata";
Expand All@@ -21,6 +30,7 @@ import {
} from "../lib/composerImages";
import type { DraftComposerImageAttachment } from "../lib/composerImages";
import { scopedThreadKey } from "../lib/scopedEntities";
import { copyTextWithHaptic } from "../lib/copyTextWithHaptic";
import { buildThreadFeed } from "../lib/threadActivity";
import { appAtomRegistry } from "../state/atom-registry";
import {
Expand All@@ -41,6 +51,8 @@ import { useSelectedThreadDetail } from "../state/use-thread-detail";
import { useThreadSelection } from "../state/use-thread-selection";
import { enqueueThreadOutboxMessage } from "./thread-outbox";
import { useThreadOutboxMessages } from "./use-thread-outbox";
import { threadEnvironment } from "./threads";
import { useAtomCommand } from "./use-atom-command";

export function appendReviewCommentToDraft(input: {
readonly environmentId: EnvironmentId;
Expand DownExpand Up@@ -74,10 +86,16 @@ export function useThreadDraftForThread(input: {
}

export function useThreadComposerState() {
const { selectedThread: selectedThreadShell } = useThreadSelection();
const { selectedThread: selectedThreadShell, selectedEnvironmentRuntime } = useThreadSelection();
const selectedThreadDetail = useSelectedThreadDetail();
const composerDrafts = useAtomValue(composerDraftsAtom);
const queuedMessagesByThreadKey = useThreadOutboxMessages();
const [feedbackSubmissionsByThreadKey, setFeedbackSubmissionsByThreadKey] = useState<
Record<string, ReadonlyArray<CodexFeedbackSubmission>>
>({});
const uploadThreadFeedback = useAtomCommand(threadEnvironment.uploadFeedback, {
reportFailure: false,
});

useEffect(() => {
ensureComposerDraftsLoaded();
Expand All@@ -90,10 +108,21 @@ export function useThreadComposerState() {
() => (selectedThreadKey ? (queuedMessagesByThreadKey[selectedThreadKey] ?? []) : []),
[queuedMessagesByThreadKey, selectedThreadKey],
);
const selectedThreadFeed = useMemo(
() => (selectedThreadDetail ? buildThreadFeed(selectedThreadDetail) : []),
[selectedThreadDetail],
);
const selectedThreadFeed = useMemo(() => {
if (!selectedThreadDetail) {
return [];
}
const submissions = selectedThreadKey
? (feedbackSubmissionsByThreadKey[selectedThreadKey] ?? [])
: [];
return buildThreadFeed(selectedThreadDetail, {
localMessages: submissions.flatMap((submission) =>
submission.status === "interrupted"
? []
: [codexFeedbackMessage(submission), codexFeedbackMessage(submission, "assistant")],
),
});
}, [feedbackSubmissionsByThreadKey, selectedThreadDetail, selectedThreadKey]);

const selectedDraft = selectedThreadKey ? composerDrafts[selectedThreadKey] : null;
const draftMessage = selectedDraft?.text ?? "";
Expand DownExpand Up@@ -143,6 +172,70 @@ export function useThreadComposerState() {
return null;
}

const provider = selectedEnvironmentRuntime?.serverConfig?.providers.find(
(entry) => entry.instanceId === thread.modelSelection.instanceId,
);
const feedbackCommand =
attachments.length === 0 &&
(provider?.driver === "codex" || thread.session?.providerName === "codex")
? parseCodexFeedbackCommand(text)
: null;
if (feedbackCommand) {
if (thread.session === null) {
Alert.alert("Start a Codex thread first", "Send a message before you submit feedback.");
return null;
}
const metadata = makeQueuedMessageMetadata();
const result = await submitCodexFeedback({
submission: {
id: MessageId.make(metadata.messageId),
command: text,
createdAt: metadata.createdAt,
},
clearDraft: () => clearComposerDraftContent(threadKey),
onUpdate: (submission) => {
setFeedbackSubmissionsByThreadKey((current) => {
const existing = current[threadKey] ?? [];
const found = existing.some((entry) => entry.id === submission.id);
return {
...current,
[threadKey]: found
? existing.map((entry) => (entry.id === submission.id ? submission : entry))
: [...existing, submission],
};
});
},
upload: () =>
uploadThreadFeedback({
environmentId: selectedThreadShell.environmentId,
input: {
threadId: selectedThreadShell.id,
...feedbackCommand,
},
}),
});
if (result._tag === "Failure") {
if (isAtomCommandInterrupted(result)) {
return null;
}
const error = Cause.squash(result.cause);
Alert.alert(
"Could not send feedback to OpenAI",
error instanceof Error ? error.message : "An error occurred.",
);
return null;
Comment thread
cursor[bot] marked this conversation as resolved.
}
const feedbackId = result.value.feedbackId;
Alert.alert("Feedback sent to OpenAI", `Thread ID: ${feedbackId}`, [
{ text: "OK", style: "cancel" },
{
text: "Copy ID",
onPress: () => copyTextWithHaptic(feedbackId, { target: "Codex feedback thread ID" }),
},
]);
return null;
}

const metadata = makeQueuedMessageMetadata();
const messageId = MessageId.make(metadata.messageId);
// Enqueue publishes the queued atom synchronously (the durable write
Expand DownExpand Up@@ -175,7 +268,12 @@ export function useThreadComposerState() {
);
});
return messageId;
}, [selectedThreadDetail, selectedThreadShell]);
}, [
selectedEnvironmentRuntime?.serverConfig?.providers,
selectedThreadDetail,
selectedThreadShell,
uploadThreadFeedback,
]);

const onChangeDraftMessage = useCallback(
(value: string) => {
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -116,6 +116,7 @@ const startupDependencies = Layer.mergeAll(
getCapabilities: () => Effect.die("unused"),
getInstanceInfo: () => Effect.die("unused"),
rollbackConversation: () => Effect.die("unused"),
uploadFeedback: () => Effect.die("unused"),
streamEvents: Stream.empty,
}),
);
Expand Down
6 changes: 6 additions & 0 deletions apps/server/src/auth/RpcAuthorization.test.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,6 +37,12 @@ describe("RPC authorization scopes", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.cloudInstallRelayClient)).toBe(AuthRelayWriteScope);
});

it("requires permission to operate on a thread before uploading feedback", () => {
expect(requiredScopeForRpcMethod(WS_METHODS.providerUploadFeedback)).toBe(
AuthOrchestrationOperateScope,
);
});

it("reads the reviewer menu under the same scope as the pull request it belongs to", () => {
// The candidate list is a read like the detail beside it, and asking somebody for a review is
// a write like every other pull request operation.
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/auth/RpcAuthorization.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,6 +84,7 @@ export const RPC_REQUIRED_SCOPES = {
[WS_METHODS.shellOpenInEditor]: AuthOrchestrationOperateScope,
[WS_METHODS.filesystemBrowse]: AuthOrchestrationReadScope,
[WS_METHODS.assetsCreateUrl]: AuthOrchestrationReadScope,
[WS_METHODS.providerUploadFeedback]: AuthOrchestrationOperateScope,
[WS_METHODS.subscribeVcsStatus]: AuthOrchestrationReadScope,
[WS_METHODS.subscribeResourceTelemetry]: AuthOrchestrationReadScope,
[WS_METHODS.vcsRefreshStatus]: AuthOrchestrationReadScope,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness(
},
}),
rollbackConversation,
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -340,6 +340,7 @@ describe("ProviderCommandReactor", () => {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -125,6 +125,7 @@ function createProviderServiceHarness() {
});
},
rollbackConversation: () => unsupported(),
uploadFeedback: () => unsupported(),
get streamEvents() {
return Stream.fromPubSub(runtimeEventPubSub);
},
Expand Down
Loading
Loading