Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before:mask-nonedisables the attachment-seam mask that the shared drawer surface owns, which looks like it will worsen the overlap rather than fix it.:is(.chat-composer-drawer-surface, .chat-composer-top-drawer)::before(index.css:887) draws the banner's glass fill, 1px outline (border-radius: 16px 16px 0 0, so a square bottom edge) and shadow, then masks away the bottom--chat-composer-attachment-overlap(calc(1rem + 1px)). That masked strip is exactly the region the composer is pulled into by.chat-composer-drawer-slot { margin-bottom: calc(-1 * var(--chat-composer-attachment-overlap)) }, and the call site still reserves it viapb-[calc(var(--chat-composer-attachment-overlap)_+_0.375rem)]. With the mask off, the pseudo-element paints in that strip again: a translucent glass fill plusbackdrop-filterstacked underneath the composer's own translucent shell (a darker band across the composer's top ~17px), the pseudo-element's bottom border as a stray 1px line, and its square bottom corners peeking outside the composer's 22px top radius. The Tailwind utility also only overridesmask-image; the rule sets-webkit-mask-imagetoo, which this file's surrounding CSS consistently treats as a separate declaration, so the emitted result can differ between engines.It also applies to every attached front banner, not only the server-update one. If there is a real gap/overlap for that banner, please fix it in the shared drawer contract (overlap variable or the
.chat-composer-drawer-slot + .chat-composer-drawer-slot::beforeseam rule) so all attached drawers —ThreadSyncStatusPill,ComposerCommandMenu,ComposerStashMenu— stay consistent, and drop the matching assertion atComposerBannerStack.test.tsx:56.Posted via Macroscope — UI Consistency