feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(web): drag sidebar threads between categories - #8001

Closed
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream
Closed

feat(web): drag sidebar threads between categories#8001
tarik02 wants to merge 30 commits into
pingdotgg:mainfrom
tarik02:feature/sidebar-dnd-upstream

Conversation

@tarik02

@tarik02tarik02 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • Allow dragging threads between Pinned, Regular, Snoozed, and Settled on web and desktop.
  • Apply the destination state on drop. Pinned preserves the chosen position; other categories use their normal sort order. Dropping into Snoozed opens the existing duration menu.
  • Replace the pinned-only sorter with one flat dnd-kit board. dnd-kit handles sortable transforms, auto-scroll compensation, the drag overlay, and drop animation.
  • Keep the source slot and viewport stable while category geometry changes.
  • Use the existing lifecycle commands. Their deciders clear conflicting pinned, settled, and snoozed state atomically, without adding a command or event.
  • Keep mobile lifecycle menus consistent with the category rules.

Why

The sidebar previously allowed reordering only inside Pinned.

The diff is larger than a normal UI patch because the old pinned-only implementation lived inside Sidebar.tsx. This PR moves drag state, collision handling, pinned ordering, viewport anchoring, and board rendering into focused modules. The resulting design is documented in docs/internals/sidebar-thread-dnd.md.

UI Changes

Before: drag and drop only reordered threads within Pinned.

After:

recording-a377fc69-049a-472c-9a65-b0a7aa970521.mp4

The recording covers pinned reorder, moves between every category, the snooze menu, card-to-compact morphing, auto-scroll, and viewport stability.

Verification

  • Targeted lint passed.
  • @t3tools/web typecheck passed.
  • 128 focused sidebar and lifecycle tests passed.
  • Manually tested pinned reorder, pin/unpin, settle/unsettle, snooze selection and cancellation, collapsed categories, auto-scroll, and drop animations.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Model: GPT-5.6-sol
Harness: Codex in T3 Code


Note

High Risk
Changes orchestration event emission for pin/settle/snooze (companion cleanup events) and re-pin order-key behavior, plus a large interactive sidebar rewrite. Event consumers and racey pin reorders can behave differently.

Overview
Lets users drag threads between Pinned, Regular, Snoozed, and Settled on web. Dropping applies the destination lifecycle command; Pinned keeps the chosen slot, other sections snap to their normal sort. Dropping into Snoozed opens the duration menu. The old pinned-only sorter is replaced by a single dnd-kit board with overlay morphing, auto-scroll, and viewport anchoring.

Server lifecycle commands now treat those categories as exclusive. Pin, settle, snooze, and their reverses emit companion cleanup events so a thread lands in one shelf. Re-pinning with an orderKey now applies that placement instead of ignoring it. Snooze toasts/menus say Wake rather than Undo, matching that Wake no longer restores a previous category.

Mobile row menus follow the same rules: snooze is offered from the rendered category, and snoozed rows only Wake.

Reviewed by Cursor Bugbot for commit 8e613a3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add drag-and-drop support for sidebar threads across categories

  • Introduces a new sidebar DnD system via SidebarThreadBoard, SidebarThreadDndShell, and useSidebarThreadDnd that lets users move threads between Pinned, Regular, Snoozed, and Settled sections.
  • Adds optimistic pinned reordering and cross-section insertion logic in useSidebarPinnedDnd, with scroll stabilization via useSidebarDndLayout.
  • Updates server orchestration in decider.ts so lifecycle commands emit companion cleanup events (e.g., thread.unsettled, thread.unsnoozed) to normalize threads to a single category.
  • Modifies mobile thread row menus in thread-list-v2-items.tsx to show "Wake" instead of "Undo" and conditionally includes snooze actions.
  • Risk: decider.ts now emits additional events for lifecycle commands, which may break out-of-tree consumers expecting a single event per command. Re-pinning with an orderKey now overwrites an existing pinOrderKey.

Macroscope summarized 8e613a3.

@tarik02tarik02 changed the title Feature/sidebar dnd upstreamfeat(web): drag sidebar threads between categoriesAug 23, 2026
@coderabbitai

coderabbitaiBot commented Aug 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f93bb2-aec6-4fa7-9cb2-e8e7fd60ba7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 23, 2026
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the new sidebar drag-and-drop surfaces. Two findings, both in newly added web UI code; everything else (primitive reuse, ScrollArea/SidebarContentviewportRef contract, Tailwind ownership, reduced-motion handling, drag-preview geometry vs. contain-intrinsic-size) looks consistent with the existing system.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated
Comment threadapps/web/src/components/sidebar/SidebarThreadDnd.tsx Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:399a71d142

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts Outdated
Comment threadapps/server/src/orchestration/decider.ts
@macroscopeapp

macroscopeappBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a large new cross-category drag-and-drop system with custom collision handling, optimistic persistence, viewport management, and server lifecycle/event changes. Its scope and unresolved risks around compatibility and multi-step state updates warrant human review.

Not approved because:

  • 2 blocking correctness issues found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Comment threadapps/web/src/hooks/useSidebarThreadDnd.ts
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new sidebar drag board: the empty-section drop rail is missing for Snoozed, so an empty Snoozed section presents differently from the other three sections during a drag.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx
Comment threadapps/web/src/hooks/useSidebarPinnedDnd.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the latest commit's removal of the empty Regular drop rail. The previously reported empty-Snoozed rail inconsistency (SidebarThreadBoard.tsx, snoozed boundary) is unchanged and still stands — not re-commented.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI consistency review of the sidebar drag-and-drop rework. The two items I raised on the previous head were addressed (aria-expanded now tracks the real shelf state via a separate dropActive presentation flag, and the grab cursor now lands on the [data-thread-row] surface). One earlier finding is still open (empty Snoozed renders a shelf header instead of the dashed EmptySectionRail the other three sections get — see the existing thread on SidebarThreadBoard.tsx), plus one new note below on coverage for the newly extracted pure drag logic.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.dnd.logic.ts
Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx Outdated

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the sidebar drag-and-drop UI for shared-primitive usage, Tailwind ownership, and interaction/accessibility preservation. The Regular boundary droppable and the missing pure-logic tests flagged earlier are addressed. One accessibility regression remains in the new board structure.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/sidebar/SidebarThreadBoard.tsx

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding: the sidebar un-settle affordance loses its shared Tooltip, reverting a recently merged fix and diverging from the sibling icon buttons in the same row.

Posted via Macroscope — UI Consistency

Comment threadapps/web/src/components/Sidebar.tsx Outdated
Comment threadapps/server/src/orchestration/decider.ts
Comment threadapps/server/src/orchestration/decider.ts Outdated

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

const pinnedPlan = current.action === "pin" ? planPinnedInsertion(current) : null;
if (current.action === "pin" && pinnedPlan === null) {
finishTransaction();
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent pin drop abort

Medium Severity

Dropping a thread into Pinned can abort after the drop animation with no error toast when planPinnedInsertion returns null. That happens when neighbor key rematerialization includes a global pinned row (including settled-but-still-pinned) whose environment lacks threadPinReorder, even though the dragged thread itself can pin. The row snaps back and the pin never commits.

Additional Locations (1)
Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8e613a3. Configure here.

tarik02 added a commit to tarik02-org/t3code that referenced this pull request Aug 24, 2026
@t3dotgg

Copy link
Copy Markdown
Member

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

We're closing this PR as we clean up the T3 Code backlog. Thank you for taking the time to put this together.

This adds another sidebar drag path across web behavior, server orchestration, and mobile thread-list code. Existing thread actions already move items between categories, so the interaction gain does not justify the cross-surface state.

If you believe we closed this in error, please reopen the PR and leave a comment explaining what we missed.

@t3dotggt3dotgg closed this Aug 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tarik02@t3dotgg