Uh oh!
There was an error while loading. Please reload this page.
fix(web): pull request surface offers the checkout's PR - #8273
fix(web): pull request surface offers the checkout's PR#8273StiensWout wants to merge 3 commits into
Conversation
The right panel's Pull request card only offered the thread's own PR, which requires the recorded thread branch to match the checkout. On a shared checkout that branch stays strict, so an agent that branches and opens a PR mid-thread left the card saying "No pull request on this branch yet" while the git menu's View PR opened that same PR in the panel. Fall back to the checkout's PR with the same gate View PR uses. Closespingdotgg#8265 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 856c3cd. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Mirrors the git menu's View PR gate so a merged or closed PR on the checkout does not enable the card while the menu offers Create PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
One finding on the new checkout-PR fallback for the pull-request surface. Details inline.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
A linked PR is the thread's own even while its detail is loading, so the surface card must not open the checkout's PR in that window. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped web bug fix that makes the Pull request surface match the existing git-menu behavior for open checkout PRs. Existing thread PR handling remains prioritized, while the second file only updates explanatory copy. You can add or adjust custom eligibility rules. Learn more. |

Problem
On a thread whose checkout has an open pull request, the git menu shows View PR and opens that PR in the right panel, yet the right panel's own Pull request card is disabled with "No pull request on this branch yet." Two entry points to the same panel disagree about whether a PR exists.
The card only offered the thread's own PR, which requires the recorded thread branch to match the checkout. On a shared (non-worktree) checkout that recorded branch deliberately stays strict (#4460), so the common flow of an agent running
git checkout -bandgh pr createmid-thread leaves the thread without an attributed PR while the checkout clearly has one.Closes#8265
Solution
The card now falls back to the checkout's PR, opened against the project repository with the same gate View PR already uses. The thread's own PR still wins when it has one, and thread attribution (sidebar badge, composer footer, auto-settle) is unchanged. The menu's disabled reason now reads "This branch has no pull request yet." to match.
Before
Reporter's screenshot: View PR enabled, Pull request card disabled.
After
The card is enabled whenever View PR would open a PR in the panel, and opens the same one.
Verification
vp run typecheckforapps/webvp lintandvp fmt --checkon the two changed filesvp test run apps/web/src/components/RightPanelTabs.test.tsxMade with Claude Fable 5 in T3 Code.
Note
Low Risk
UI-only fallback for opening an existing checkout PR in the right panel; thread PR resolution and attribution logic are unchanged.
Overview
Aligns the right panel Pull request card with the git menu View PR when a thread has no attributed PR but the checkout has an open one.
ChatView now derives
checkoutPrfrom git status (open PR only, and only when there is no linked thread PR) and enables the surface when either the thread PR or that checkout PR exists. Opening the surface prefers the thread PR viaopenThreadPullRequest; otherwise it opens the checkout PR withopenProjectPullRequest, matching View PR.RightPanelTabs updates the disabled copy to "This branch has no pull request yet." so it is not thread-specific when the fallback applies. Thread attribution elsewhere is unchanged.
Reviewed by Cursor Bugbot for commit 21d2dc7. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Offer checkout PR on Pull Request surface when thread has no PR
checkoutPrfromgitStatusQueryinChatViewContentso the PR surface shows an open checkout PR even when the thread has no linked PRopenProjectPullRequestpullRequestSurfaceAvailableis now true when either the thread has a PR andthreadRepositoryis present, or the checkout has an open PR andactiveProjectRepositoryis presentMacroscope summarized 21d2dc7.