Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 5.2k
fix(web): keep long task drawers usable on small screens#8313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shivamhwp
merged 7 commits into
pingdotgg:main
from
shivamhwp:fix/composer-task-drawer-heightAug 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
21426a7
fix(web): keep long task drawers usable on small screens
shivamhwp 61c139f
fix(web): make task drawer scroll region keyboard accessible
shivamhwp ba1b5dc
fix(web): name the task drawer scroll region
shivamhwp c77e87f
Merge branch 'main' into fix/composer-task-drawer-height
shivamhwp 0d0968b
Merge remote-tracking branch 'upstream/main' into codex/review-pr-8313
shivamhwp 1007255
fix(web): keep task drawer focus from expanding mobile composer
shivamhwp 942aa7e
Merge remote-tracking branch 'upstream/main' into codex/review-pr-8313
shivamhwp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import { ListTodoIcon, XIcon } from "lucide-react"; | ||
| import { ChevronDownIcon, ListTodoIcon, XIcon } from "lucide-react"; | ||
| import { memo } from "react"; | ||
| import { formatDuration } from "../../session-logic"; | ||
| @@ -174,11 +174,16 @@ export const ComposerTasksDrawer = memo(function ComposerTasksDrawer({ | ||
| readonly steps: readonly ComposerTaskStep[]; | ||
| }) { | ||
| return ( | ||
| <div className="chat-composer-top-drawer" data-chat-composer-tasks-drawer="true"> | ||
| <div | ||
| className="chat-composer-top-drawer" | ||
| data-chat-composer-collapsed-controls="true" | ||
| data-chat-composer-tasks-drawer="true" | ||
| > | ||
| <div className="flex items-center gap-1 px-3 py-1.5 sm:px-4"> | ||
| <button | ||
| type="button" | ||
| aria-expanded="true" | ||
| aria-label={`Collapse tasks. ${progress.completedSteps} of ${progress.totalSteps} complete.`} | ||
| className="flex min-w-0 flex-1 cursor-pointer items-center gap-2 self-stretch text-left text-xs text-muted-foreground hover:text-foreground" | ||
| onClick={onCollapse} | ||
| onPointerDown={(event) => event.preventDefault()} | ||
| @@ -188,6 +193,7 @@ export const ComposerTasksDrawer = memo(function ComposerTasksDrawer({ | ||
| <span className="tabular-nums"> | ||
| {progress.completedSteps}/{progress.totalSteps} | ||
| </span> | ||
| <ChevronDownIcon aria-hidden className="ml-auto size-3.5 shrink-0" /> | ||
| </button> | ||
| <Button | ||
| size="icon-micro" | ||
| @@ -200,7 +206,13 @@ export const ComposerTasksDrawer = memo(function ComposerTasksDrawer({ | ||
| <XIcon aria-hidden className="size-3" /> | ||
| </Button> | ||
| </div> | ||
| <div className="space-y-px px-3 pb-4 sm:px-4" role="list"> | ||
| <div | ||
| aria-label={`Task list. ${progress.completedSteps} of ${progress.totalSteps} complete.`} | ||
| className="max-h-[min(24rem,40dvh)] space-y-px overflow-y-auto overscroll-contain px-3 pb-4 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-ring/70 sm:px-4" | ||
| data-composer-tasks-list="true" | ||
| role="list" | ||
| tabIndex={0} | ||
| > | ||
macroscopeapp[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. cursor[bot] marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| {keyedTaskSteps(steps).map(({ key, step }) => ( | ||
| <div key={key} className="flex items-baseline gap-2 text-xs leading-5" role="listitem"> | ||
| <span | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.