feat(grok): show Grok subagents in the Agents panel

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.

[charindithjaindu]

Problem

Claude Task and Codex collab children already emit task.* events that the right-hand Agents panel folds into a live roster. Grok Build streams the same child work over ACP (subagent_spawned / subagent_progress / subagent_finished, plus workflow_updated), but T3 dropped those notifications. Grok threads showed an empty Agents panel.

Fix

Map Grok's x.ai session notifications onto the existing task.started / task.progress / task.completed path. Complexity stays at the adapter.

• Standalone agent() children become taskType: "subagent" rows with timelineBypass, so they list in the Agents panel like Claude Task.
• Workflow members use Claude/Codex linkage: parentAgentId + timelineBypass + a stable :wf: slot. The parent ACP session id is not used as parentAgentId (that would mis-classify a direct spawn as a workflow member).
• First-seen terminal updates still emit task.started then task.completed. Unchanged member ticks are fingerprinted and skipped. Child tokens stay on typedUsage.
• No new UI, contracts, or usage/rewind work. Web, desktop, and mobile already render this stream through client-runtime.

Tests

vp test run apps/server/src/provider/acp/GrokAcpSubagents.test.ts apps/server/src/provider/Layers/GrokAdapter.test.ts — 48 passed.

Made with Grok 4.6.

---

Note

Medium Risk
Non-trivial Grok adapter changes (notification buffering, semaphore ordering, and turn-liveness interaction) could drop or mis-time events at session startup, though scope stays within existing task.* ingestion with no contract or auth changes.

Overview
Grok Build child work (subagent_* and workflow_updated) was invisible in the Agents panel because those private ACP notifications were never translated into the shared task.* runtime events Claude Task and Codex collab already use.

This PR adds GrokAcpSubagents to parse flexible x.ai envelopes and emit task.started / task.progress / task.completed with the same linkage rules as other drivers: standalone agent() rows as subagent with timelineBypass (no fake parentAgentId), workflow members under a local_workflow parent with stable runId:wf:agentId slots. GrokAdapter registers four notification methods, queues early notifications until the session context exists, then flushes them under a lock and refreshes turn liveness when subagent ticks arrive so long quiet parent streams do not stall the watchdog.

The ACP mock agent can emit a sample subagent lifecycle when T3_ACP_EMIT_XAI_SUBAGENT=1; unit and adapter tests cover parsing, dedupe, and end-to-end streaming.

^{Reviewed by Cursor Bugbot for commit 468a4bf. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Show Grok subagents in the Agents panel by mapping session notifications to task.* events

• GrokAdapter now listens to _x.ai/session/update notifications and parses them as workflow or subagent updates via GrokAcpSubagents.ts, emitting canonical task.started/task.progress/task.completed events with stable RuntimeTaskIds
• Added buffering for early session notifications so they replay after session start, and notifications now refresh turn liveness to avoid inadvertent watchdog timeouts
• Added a mock flag T3_ACP_EMIT_XAI_SUBAGENT in acp-mock-agent.ts to simulate subagent lifecycle notifications for testing
• Documented the mapping in providers.md
• Risk: early notifications are queued via pending + readiness flag in GrokSessionContext; if the session-start handshake does not flip the readiness flag, buffered workflow/subagent events may be dropped silently

^{Macroscope summarized 468a4bf.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 62d2ac96-5ae7-472e-9eaf-dba2d00349ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 2c8a9e0. Configure here.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a substantial production capability for surfacing Grok subagents and workflows, including new event mapping, startup buffering, and turn-liveness behavior. The resulting changes affect existing Grok request paths and shared Agents-panel state, so the scope merits human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[charindithjaindu]

Addressed the Macroscope and Bugbot findings in 468a4bf:

• Subagent/workflow ACP ticks now stamp lastTurnActivityAtNanos before waking the watchdog, so a quiet parent stream is not cancelled while children are still working.
• Spawn-time token counts are kept in usageByTaskId, so a later tools-or-duration tick cannot publish totalTokens: 0.
• Workflow member fingerprints include the wire state, so start → running still emits progress.

Mapper + adapter tests: 49 passed.