fix(web): assistant images open in preview

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.

[RakshithBhat03]

Assistant-rendered Markdown images appeared inline, but clicking them did nothing. Prompt attachments already opened the image dialog, so the two image paths behaved differently.

Standalone assistant images now use that existing dialog. Linked images remain links, and keyboard users can open the preview with Enter and return focus to the image after dismissing it.

Tests: 41 focused tests, web typecheck, targeted lint and formatting.

Inline image	Expanded preview

assistant-image-preview.mp4

---

Built by GPT-5.6 Sol in T3 Code through the Codex harness.

---

Note

Low Risk
UI-only chat markdown and dialog behavior with no auth or data-path changes; main regression surface is focus/keyboard dismissal in the image dialog and accidental zoom on linked images.

Overview
Standalone images in assistant (and other) markdown now open the existing expanded image preview when onImageExpand is wired—matching prompt attachments instead of dead inline clicks.

ChatMarkdown adds optional onImageExpand and wraps image rendering in a small context. Direct and workspace images go through ChatMarkdownResolvedImage, which renders a zoom button (data-chat-markdown-image-expand, accessible labels, focus ring) when expansion is enabled. Images inside explicit links stay plain <img>s: a new rehypeMarkLinkedImages pass tags nested images so zoom is not nested inside <a>.

ExpandedImageDialog is rebuilt on @base-ui/react/dialog with initial/final focus (close button and restore to the triggering control), overlay close via DialogPrimitive.Close, and arrow keys still handled for multi-image navigation (Escape now follows the dialog primitive instead of a custom window listener).

MessagesTimeline passes ctx.onImageExpand into assistant ChatMarkdown. Tests cover zoom buttons, linked-image behavior, and timeline markup.

^{Reviewed by Cursor Bugbot for commit 549f89f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Make assistant markdown images open in expanded preview dialog

• Adds onImageExpand callback to ChatMarkdown so standalone images render as clickable zoom buttons; images wrapped in links stay plain
• Introduces a rehype plugin rehypeMarkLinkedImages that flags <img> nodes inside <a> tags via node.data.t3LinkedImage\n- Rewrites ExpandedImageDialog with @base-ui/react dialog primitives, adding managed focus and overlay/Close-button dismissal while retaining arrow-key navigation
• Wires ctx.onImageExpand through AssistantTimelineRow so assistant message images can expand
• Risk: custom Escape handling removed from ExpandedImageDialog keydown listener; Escape now relies on the dialog primitive's default behavior

^{Macroscope summarized 549f89f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 69400e8b-5168-457e-a531-65664b9f16ca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

UI Consistency review

Two findings in the changed UI code:

1. ExpandedImageDialog close button now builds its class string with buttonVariants(...) instead of the Button primitive, so the recipe's base relative is no longer merged away by cn/tailwind-merge and defeats the call-site absolute positioning.
2. The new markdown zoom wrapper leaves the wrapped image inline, so the hover/focus ring box is taller than the image for the remote-image path.

Details inline.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding: the new zoom-button wrapper tries to force its image to block with [&>img]:block, but that utility loses to the unlayered .chat-markdown img { display: inline-block } rule, so the remote-image path still gets baseline descender space inside the button while the workspace path (which carries block!) stays tight.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces a new assistant-image preview workflow across the production chat timeline and substantially changes the shared image dialog’s focus and dismissal behavior. The scope spans core rendering, timeline wiring, and modal interaction rather than a small isolated fix.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 059188f. Configure here.}

[RakshithBhat03]

Closing as superseded by #8807. The related markdown image and preview changes have also landed in #8501, #8688, and #8811.