Uh oh!
There was an error while loading. Please reload this page.
fix(web,mobile): snooze menu no longer offers the same wake time twice - #8741
Merged
maria-rcks merged 2 commits intoAug 30, 2026
Merged
Conversation
On Sundays "Tomorrow" and "Next week" both resolve to Monday 9:00 AM, so the snooze menu listed the same wake time as two rows. "Next week" is now only offered when it lands on a different instant than "Tomorrow", in the shared resolveSnoozePresets builder that feeds the web popover, context menus, the chat-header menu, and mobile menus. Created with z-ai/glm-5.3-flash via the opencode harness in T3 Code.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a localized, tested bug fix that removes a redundant Sunday snooze option while preserving all other web and mobile behavior. It changes no product defaults, APIs, schemas, infrastructure, or sensitive code. You can add or adjust custom eligibility rules. Learn more. |
…s doc Created with z-ai/glm-5.3-flash via the opencode harness in T3 Code.
CDVolvik
commented
Aug 30, 2026
Contributor
Verified fix(web,mobile): snooze menu duplicate wake time at 4776f84 as CDVolvik. resolveSnoozePresets now guards next-week with nextWeek.getTime() != tomorrow.getTime(), so on Sundays menu collapses 5 to 4 (both Monday 9am). Tested pnpm exec vitest run threadSnoozed.test.ts 26/26 passed including new Sunday case 2026-08-30. CI green. Revert safe. LGTM. |
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Aug 30, 2026
## What's Changed * feat(mobile): update tool summaries and chat transitions by @juliusmarminge in pingdotgg/t3code#8793 * feat(web): play video attachments in chat by @Bil0000 in pingdotgg/t3code#8688 * fix(web,mobile): snooze menu no longer offers the same wake time twice by @vitalyiegorov in pingdotgg/t3code#8741 * fix(grok): allow model changes in existing threads by @ahmed-besic in pingdotgg/t3code#8392 * feat(mobile): pick, share, and receive files in threads by @t3dotgg in pingdotgg/t3code#8237 ## New Contributors * @ahmed-besic made their first contribution in pingdotgg/t3code#8392 **Full Changelog**: pingdotgg/t3code@v0.0.37-nightly.20260830.1227...v0.0.37-nightly.20260830.1232 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.37-nightly.20260830.1232
github-actionsBot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Aug 31, 2026
## What's Changed * Remove Messages Glass Lab experiment by @juliusmarminge in pingdotgg/t3code#8599 * Require human review for pull requests changing product defaults by @juliusmarminge in pingdotgg/t3code#8603 * fix(codex): avoid quadratic app-server input buffering by @juliusmarminge in pingdotgg/t3code#8605 * fix(mobile): stabilize iOS header item transitions by @juliusmarminge in pingdotgg/t3code#8607 * chore(mobile): upgrade to Expo SDK 57 by @juliusmarminge in pingdotgg/t3code#8609 * fix(mobile): harden native header toolbar items by @juliusmarminge in pingdotgg/t3code#8611 * fix(server): stop querying Claude context usage after turns by @t3dotgg in pingdotgg/t3code#8610 * chore: vouch ryanrhughes by @t3dotgg in pingdotgg/t3code#8613 * feat(web): attach PDFs, ZIPs, and other files to a turn by @t3dotgg in pingdotgg/t3code#8236 * feat(web): keybinding settings as settings rows by @StiensWout in pingdotgg/t3code#8532 * feat: let an environment publish themes as a file by @ryanrhughes in pingdotgg/t3code#8569 * fix(web): clean up provider settings list and editor by @StiensWout in pingdotgg/t3code#8504 * fix(web): keep project picker popup inside the sidebar by @SunkenInTime in pingdotgg/t3code#8627 * fix(mobile): prevent header overflow and back-button artifacts by @juliusmarminge in pingdotgg/t3code#8624 * fix(server): retry automatic thread title generation by @Bil0000 in pingdotgg/t3code#8087 * fix(client-runtime): refresh edited pull request comments by @Bil0000 in pingdotgg/t3code#8094 * fix(web): four composer spacing defects by @Bil0000 in pingdotgg/t3code#8090 * perf(desktop): skip duplicate browser updates by @Bil0000 in pingdotgg/t3code#8018 * fix(web): render nested markdown images correctly by @flamboh in pingdotgg/t3code#8501 * fix(web): unify activity logs and composer banners by @juliusmarminge in pingdotgg/t3code#8693 * fix(mobile): reduce dev-client reload and Metro startup cost by @juliusmarminge in pingdotgg/t3code#8694 * revert(web): restore previous composer banners by @t3dotgg in pingdotgg/t3code#8733 * test(web): remove tests for unreachable helpers by @t3-code[bot] in pingdotgg/t3code#8738 * feat(mobile): update tool summaries and chat transitions by @juliusmarminge in pingdotgg/t3code#8793 * feat(web): play video attachments in chat by @Bil0000 in pingdotgg/t3code#8688 * fix(web,mobile): snooze menu no longer offers the same wake time twice by @vitalyiegorov in pingdotgg/t3code#8741 * fix(grok): allow model changes in existing threads by @ahmed-besic in pingdotgg/t3code#8392 * feat(mobile): pick, share, and receive files in threads by @t3dotgg in pingdotgg/t3code#8237 * fix(web): reduce title bar scroll fade height by @maria-rcks in pingdotgg/t3code#8799 * fix(windows): strip quotes from repaired PATH by @UtkarshUsername in pingdotgg/t3code#8746 * fix(web): open agent images in expanded preview by @maria-rcks in pingdotgg/t3code#8807 * fix(git): follow repository instructions in generated source control text by @maria-rcks in pingdotgg/t3code#8804 * fix(server): stop overpricing cached Claude tokens by @SunkenInTime in pingdotgg/t3code#8806 * fix(web): keep image preview above sidebar control by @maria-rcks in pingdotgg/t3code#8811 * fix(web): keep right panel synced with agent edits by @maria-rcks in pingdotgg/t3code#8803 * fix(web,mobile): render Codex citations and artifact templates by @Yash-Singh1 in pingdotgg/t3code#8584 * chore: add Windows setup script to t3.json by @UtkarshUsername in pingdotgg/t3code#8814 * fix(web): fold interim turn responses by @maria-rcks in pingdotgg/t3code#8828 * fix(web): use circle alert for failed tool calls by @maria-rcks in pingdotgg/t3code#8840 * feat(mobile): add offline iPhone voice input by @t3dotgg in pingdotgg/t3code#8614 * fix(web): prevent pull request metadata overlap by @MatthewFeroz in pingdotgg/t3code#8790 ## New Contributors * @ryanrhughes made their first contribution in pingdotgg/t3code#8569 * @ahmed-besic made their first contribution in pingdotgg/t3code#8392 * @MatthewFeroz made their first contribution in pingdotgg/t3code#8790 **Full Changelog**: pingdotgg/t3code@v0.0.36...v0.0.37 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on a Sunday, fixed on a Sunday — for the ones who work on Sundays only!
Fixes#8740
What Changed
resolveSnoozePresets(the shared snooze-preset builder inpackages/client-runtime) now only offers "Next week" when it lands on a different instant than "Tomorrow".threadSnoozed.test.ts.Why
"Next week" is next Monday 9:00 AM — and on a Sunday, tomorrow is Monday. Every client (web sidebar popover, web context menus, chat-header menu, mobile native snooze menus) renders the same shared preset list, so the menu offered two rows with identical wake targets one day a week. The guard lives in the one shared builder, so no per-client duplication and every surface inherits the fix.
UI Changes
Before (Sunday): five options — "Tomorrow 9:00 AM" and "Next week Mon 9:00 AM" are the same instant:
After (Sunday): four options, duplicate gone:
No motion or timing changes, so no video.
Testing
vp test run packages/client-runtime/src/state/threadSnoozed.test.ts— new Sunday test asserts the four-option list and that what remains lands on Monday.Checklist
Created with z-ai/glm-5.3-flash via the opencode harness in T3 Code.
Note
Low Risk
Small calendar-edge guard in shared snooze preset generation with no auth, data, or server contract changes.
Overview
Fixes duplicate snooze options on Sundays by tightening the shared
resolveSnoozePresetsbuilder in client-runtime.The "Next week" preset is only added when its wake instant differs from "Tomorrow". On Sundays both resolve to Monday morning (9:00), so the menu drops the redundant row and every surface that uses this list (web and mobile snooze menus) shows four choices instead of two identical wake times.
A unit test locks Sunday 2026-08-30 to assert
next-weekis omitted while Tomorrow still targets Monday.Reviewed by Cursor Bugbot for commit 4776f84. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix
resolveSnoozePresetsduplicating the same wake time on SundaysOn Sundays, the "Tomorrow" and "Next week" snooze presets both resolve to Monday morning, causing the menu to show the same wake time twice.
resolveSnoozePresetsnow compares the computed "next-week" Date against "tomorrow" and omits "next-week" when they are equal. A test in threadSnoozed.test.ts verifies the Sunday edge case.Macroscope summarized 4776f84.