fix(server): forget a deleted thread's provider binding

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.

[willsheldon]

Refs #8794.

Problem

Deleting a thread stopped its provider session and closed its terminals, but left the row in provider_session_runtime. Nothing else prunes that table: ProviderSessionDirectory had no delete method and nothing called the repository's deleteByThreadId. The rows accumulated for the life of the install, including rows for threads the user had deleted.

Fix

Add remove to the session directory and call it from the thread deletion cleanup, alongside the existing session stop and terminal close. It uses the same cleanup-failure logging as its neighbours, so a persistence failure does not abort the rest of the deletion.

Verification

• vp test run apps/server/src/orchestration/Layers/ThreadDeletionReactor.test.ts — 4 passed
• vp test run apps/server/src/serverRuntimeStartup.reconcile.test.ts apps/server/src/provider/Layers/CodexAdapter.test.ts apps/server/src/provider/Layers/OpenCodeAdapter.test.ts — 117 passed (test doubles updated for the new method)
• tsgo --noEmit -p apps/server/tsconfig.json — clean
• vp lint on the changed files — clean

Written by Claude Opus 5 in Claude Code.

---

Note

Low Risk
Localized cleanup on thread delete with existing non-fatal error handling; no change to session start or reconciliation behavior beyond pruning stale bindings.

Overview
Thread deletion previously stopped the provider session and closed terminals but left rows in provider_session_runtime, so bindings for deleted threads could accumulate indefinitely.

This PR adds ProviderSessionDirectory.remove, implemented via the repository’s deleteByThreadId, and wires ThreadDeletionReactor to call it after stopping the session and before closing terminals. Failures use the same logCleanupCauseUnlessInterrupted path as the other cleanup steps so a persistence error does not block the rest of deletion.

Test doubles gain a no-op remove, and ThreadDeletionReactor gains a test that asserts the deleted thread id is passed to remove.

^{Reviewed by Cursor Bugbot for commit 9e24e03. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove provider binding for deleted threads in ThreadDeletionReactor

• Adds remove to the ProviderSessionDirectory service interface and implementation; it calls the runtime repository's deleteByThreadId and maps failures to ProviderSessionDirectoryPersistenceError.
• ThreadDeletionReactor now invokes directory.remove after stopping the provider session and before closing terminals for each thread.deleted event.
• All affected test fixtures and doubles receive a no-op or stub remove implementation.
• Risk: ProviderSessionDirectory.remove failures during non-interrupt cleanup flow through the existing cleanup logging path rather than aborting deletion.

^{Macroscope summarized 9e24e03.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4cd8d3ea-3a0b-464f-9d2b-63a4491899fd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This localized fix removes persisted provider bindings during thread deletion, but the asynchronous cleanup may race with a recreated thread using the same ID and delete its replacement binding. The current test covers only the normal deletion path, so the ordering risk requires human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

[cursor]

Retry can lose new provider binding

Medium Severity

Draft retries reuse a soft-deleted thread id. forgetProviderBinding always calls remove on the async deletion worker and does not check for a later thread.created. If the retry upserts a binding before that worker finishes, the new provider_session_runtime row is deleted and later routing cannot find a session.

^{Reviewed by Cursor Bugbot for commit 4fe4855. Configure here.}

Dismissing prior approval to re-evaluate f857df8

[willsheldon]

The Release Smoke failure is inherited from current main: expo-sharing now resolves past the version targeted by its required patch. The root fix is #9250, which pins the patched version and passes Release Smoke. This PR can be refreshed after #9250 merges.