Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(cli): open projects in the running desktop app by t3dotgg · Pull Request #8824 · pingdotgg/t3code · GitHub
Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cli): open projects in the running desktop app by t3dotgg · Pull Request #8824 · pingdotgg/t3code · GitHub
Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cli): open projects in the running desktop app by t3dotgg · Pull Request #8824 · pingdotgg/t3code · GitHub
Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(cli): open projects in the running desktop app by t3dotgg · Pull Request #8824 · pingdotgg/t3code · GitHub
Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cli): open projects in the running desktop app by t3dotgg · Pull Request #8824 · pingdotgg/t3code · GitHub
Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(cli): open projects in the running desktop app by t3dotgg · Pull Request #8824 · pingdotgg/t3code · GitHub
Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(cli): open projects in the running desktop app by t3dotgg · Pull Request #8824 · pingdotgg/t3code · GitHub
Skip to content

feat(cli): open projects in the running desktop app - #8824

Open
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command
Open

feat(cli): open projects in the running desktop app#8824
t3dotgg wants to merge 4 commits into
mainfrom
t3code/audit-app-project-command

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 30, 2026

Copy link
Copy Markdown
Member

Opening a project from a terminal required finding the directory again in the desktop app.

npx t3 app [path] now opens the current directory or a given path in a running local desktop app. It adds or reuses the project, focuses the window, and follows the normal New Thread flow.

The command reports an error over SSH, when the app is not running, or when the desktop environment cannot use the path. It does not launch the app, open a browser, start a server, or change state when no app is available.

Verified with 43 tests in 7 files, type checks for all five affected packages, and targeted lint and format checks. The local socket was tested. Native Electron window focus was not tested.

Implemented by GPT-5.6 Sol using Codex in T3 Code.

Note

Add t3 app CLI command to open projects in running desktop app

  • Adds a local control socket (startDesktopAppControlServer) in the desktop main process that accepts JSON-lines requests, focuses the window, and queues requests until the renderer is ready
  • Adds the t3 app CLI subcommand that connects to the control socket, sends an activation request with a workspace path and platform, and reports structured errors for SSH, unsupported platforms, or unreachable apps
  • Adds a renderer-side DesktopAppActivationCoordinator component and handleDesktopAppActivationRequest logic to find or create a project, wait for availability, and open a new thread
  • Defines shared activation contracts in packages/contracts/src/desktopAppActivation.ts and a cross-platform address resolver in packages/shared/src/desktopAppControl.ts
  • Risk: useNewThreadHandler in useHandleNewThread.ts now reads projects lazily via readProjects() instead of subscribing; callers that relied on reactive project state in the hook closure may behave differently

Macroscope summarized 9562278.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). labels Aug 30, 2026
@coderabbitai

coderabbitaiBot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f80e0e05-9f95-418a-ad38-c4e2ce89b4af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actionsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−86 B (−0.6%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−6 B (−0.1%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−80 B (−1.2%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.5 KiB−88 B (−0.2%)66.4 KiB
CodexLive turn messages119−2 (−18.2%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−4 B (−0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.4 KiB6.4 KiB−3 B (−0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: e4f7b14 · PR result: 9562278 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effect service conventions review of the new DesktopAppActivation service and the t3 app CLI command. Three findings, all in apps/desktop/src/app/DesktopAppActivation.ts and apps/server/src/cli/app.ts. The contracts schemas, the broker, and the renderer coordinator follow the conventions (namespace subpath imports, inline Context.Service interface, structured Schema.TaggedErrorClass with address + cause, Effect.acquireRelease for socket ownership).

Posted via Macroscope — Effect Service Conventions

Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/desktop/src/app/DesktopAppActivation.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/server/src/cli/app.ts Outdated
Comment threadapps/desktop/src/preload.ts

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f5f18e2. Configure here.

Comment threadapps/server/src/cli/app.ts Outdated
Comment threadpackages/shared/src/desktopAppControl.ts
@macroscopeapp

macroscopeappBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This introduces a substantial end-to-end capability across the CLI, desktop process, renderer, shared protocol, and project/thread state, including a new local IPC control surface and state-mutating workflow. The breadth of integration and runtime side effects merits human review despite the accompanying tests and backward-compatible interfaces.

Notes:

  • No code objects were reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

@macroscopeappmacroscopeappBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding on the new t3 app CLI error modeling. The earlier comments on DesktopAppActivation.make/HostProcessUserId and the discarded socket cause are resolved.

Posted via Macroscope — Effect Service Conventions

Comment threadapps/server/src/cli/app.ts Outdated
Michaelihc pushed a commit to Michaelihc/t3code that referenced this pull request Aug 31, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (pingdotgg#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (pingdotgg#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (pingdotgg#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (pingdotgg#7454) and
un-settle re-anchor (pingdotgg#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's pingdotgg#7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's pingdotgg#7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the pingdotgg#7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (pingdotgg#8048) and client-connection analytics recording are wired;
providerUploadFeedback (pingdotgg#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (pingdotgg#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added the 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. label Aug 31, 2026
juliusmarminge added a commit that referenced this pull request Sep 1, 2026
Ten days of main (194 commits, 640 files) re-integrated with the v2
re-architecture. The headline mechanics:
- migrations: main added 041-043 (AuthSessionClientConnection,
ProjectionThreadLinkedPullRequest, ProjectionThreadsUnsettledAt), so the
v2 block renumbers 041-049 → 044-052 with the migration tests shifted to
match
- contracts: OrchestrationClientOrigin (#7774) and the origin metadata
field live in applicationEvent.ts and re-export through the legacy
path; ProviderApprovalOption + acceptAlways + mcp-elicitation (#8058)
land in providerPolicy.ts; OrchestrationDispatchCommandError (#8824)
added; the send-turn image-mime home stays chatAttachment.ts
- threadSettled: main's settle-once-on-merge semantics (#7454) and
un-settle re-anchor (#8231) hand-merged onto the v2 duck-typed shells
(latestRun ?? latestTurn reads); web callers pass the new
ChangeRequestSettleSource shape
- timeline anchoring: main's #7897 (follow-up sends no longer push to the
top) ported by scanning user rows only; the branch test now encodes the
new semantics, as does mobile's #7969 settled-pinned shelf behavior
- vcs: branch's deleteLocalBranch coexists with main's pruneWorktrees and
the #7674 submodule checkout tests
- ws: v2 RPC surface keeps its dispatch path; main's attachment upload
RPCs (#8048) and client-connection analytics recording are wired;
providerUploadFeedback (#7949) fails explicitly pending a v2 route
- approvals: main's option-driven approval buttons (#8058) render through
the v2 canRespond gate on web and mobile
- ChatView/ChatComposer/MessagesTimeline/Sidebar/session-logic/
threadActivity keep the branch's v2 architecture; main's v1-coupled
deltas to those files are recorded for follow-up rather than
force-fitted
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg