fix(web): open toast View PR in-app when possible

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.

[MeGaurav4]

Closes#9004

The View PR action in the Git actions control opens in the in-app
panel via onOpenPullRequest when available, with modifier-click
preserved for external. The success toast for Push & create PR
always called api.shell.openExternal, so a plain click always left
the app.

Make the toast's open_pr CTA try onOpenPullRequest for plain
clicks (parsing the PR number from toastCta.url) and fall back to
openPullRequestLink, matching the regular action's routing.

---

Note

Low Risk
Small UX routing change in Git toast CTAs; no auth, data, or server behavior changes.

Overview
After Push & create PR (and similar actions), the success toast View PR button no longer always opens the browser. It now follows the same rules as the main Git View PR action.

On a normal click, when onOpenPullRequest is available and the toast URL parses to a PR number, the change request opens in-app beside the thread. Modifier clicks still open externally via shouldOpenPullRequestExternally. Otherwise the handler uses openPullRequestLink instead of calling api.shell.openExternal directly, and link failures show an error toast instead of failing quietly.

^{Reviewed by Cursor Bugbot for commit 5b3d1db. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Open toast 'View PR' in-app when URL parses and event is not external

Updates the open_pr toast CTA in GitActionsControl.tsx to attempt in-app navigation via onOpenPullRequest when shouldOpenPullRequestExternally(event) is false and parseChangeRequestUrl succeeds. Falls back to openPullRequestLink, with a new error toast on rejection. Closes the result toast before opening.

^{Macroscope summarized 5b3d1db.}

[macroscopeapp]

Both findings are in apps/web/src/components/GitActionsControl.tsx; the in-app open path itself (explicit onOpenPullRequest scope from the owning surface, toast closed before navigating) looks right.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Approved at 5b3d1db

Macroscope's review found this PR approvable — This is a focused one-file web UX fix that aligns the toast’s existing View PR action with the established in-app routing while preserving external modifier-click behavior. External-link failures are now surfaced through the existing error-toast pattern, with no changes to server, data, auth, billing, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5ff345e. Configure here.}

[juliusmarminge]

Closing as a duplicate of #9006. Both fix the View PR success-toast action; #9006 uses the existing shared link handler and keeps modifier-click behavior. Thanks for the fix.