Uh oh!
There was an error while loading. Please reload this page.
fix(web): prevent two-digit list markers from being clipped - #9101
Merged
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, localized web rendering fix that widens ordered-list gutters only when markers exceed one character, leaving single-digit lists unchanged. The associated tests are updated, and the CSS changes are comment-only with no broader product, API, security, or infrastructure impact. You can add or adjust custom eligibility rules. Learn more. |
shivamhwp
enabled auto-merge (squash)
September 2, 2026 09:13
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 2, 2026
## What's Changed * feat(updates): continue active threads across server restarts by @maria-rcks in pingdotgg/t3code#9167 * fix(mobile): prevent message and composer overlap by @juliusmarminge in pingdotgg/t3code#9195 * fix(web): preserve composer draft during worktree setup by @maria-rcks in pingdotgg/t3code#9197 * fix(web): prevent two-digit list markers from being clipped by @G-R3 in pingdotgg/t3code#9101 ## New Contributors * @G-R3 made their first contribution in pingdotgg/t3code#9101 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1256...v0.0.39-nightly.20260902.1257 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260902.1257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsed user messages can clip the leading digit from ordered-list markers 10 through 99 because the default
1.25remgutter is narrower than the rendered marker.Apply the existing dynamic gutter sizing to two-character markers instead of starting at three characters. Single-digit lists keep the default gutter, while wider markers continue scaling based on their width.
This replaces #7339. The issue was reconfirmed on current
main, and a replacement PR was requested in this follow-up.Testing
vp test run apps/web/src/components/ChatMarkdown.test.tsxvp lint apps/web/src/components/ChatMarkdown.tsx apps/web/src/components/ChatMarkdown.test.tsxvp fmt apps/web/src/components/ChatMarkdown.tsx apps/web/src/components/ChatMarkdown.test.tsx apps/web/src/index.css --checkcd apps/web && vp run typecheckBuilt with GPT-5.6 Sol using the Codex harness in T3 Code.
Note
Low Risk
Localized chat markdown layout change with unit tests; no auth, data, or API impact. Minor risk of extra left indent on some nested lists that still use numeric marker sizing.
Overview
Fixes clipped 10–99 (and similar two-character) ordered-list markers in collapsed chat messages by widening the list gutter sooner.
orderedListGutterStylenow applies dynamic--list-gutterwhen the widest marker is two or more characters (thresholdmarkerWidth <= 1instead of<= 2). Single-digit lists still use the default1.25remgutter; wider markers keep scaling via(markerWidth + 1)ch, including negativestartvalues.Tests in
ChatMarkdown.test.tsxwere updated for two-digit and-5cases;index.csscomments were aligned with the new behavior.Reviewed by Cursor Bugbot for commit bcb112f. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix clipping of two-digit list markers in
orderedListGutterStyleChanges the threshold in
orderedListGutterStylefrommarkerWidth <= 2tomarkerWidth <= 1so two-character markers (e.g. items 10–99 or negative starts like -5) get an explicit--list-gutterwidth of3chinstead of falling back to the default. Updates tests in ChatMarkdown.test.tsx to expect the widened gutter and clarifies comments in index.css.📊 Macroscope summarized bcb112f. 2 files reviewed, 1 issue evaluated, 1 issue filtered, 0 comments posted
🗂️ Filtered Issues
apps/web/src/components/ChatMarkdown.tsx — 0 comments posted, 1 evaluated, 1 filtered
.chat-markdown ol olrenderslower-alphamarkers. A nested list with 10–26 items has single-character markers (athroughz), yetitemCountmakes this function return--list-gutter: 3ch; it therefore gains a substantially unnecessary left indent compared with the unchanged default gutter. Base the width calculation on the active marker style or avoid numeric widening for nested alphabetic lists. [ Out of scope (post-validation triage) ]