fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(server): heal skipped 045 and warn on migration slot collisions - #9312

Open
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull
Open

fix(server): heal skipped 045 and warn on migration slot collisions#9312
ImBIOS wants to merge 1 commit into
pingdotgg:mainfrom
ImBIOS:fix/migration-047-ensure-auto-pull

Conversation

@ImBIOS

@ImBIOSImBIOS commented Sep 3, 2026

Copy link
Copy Markdown

Databases whose journal already occupied ID 45 (forks, nightlies, renumbered branches) silently skip 045_ProjectionProjectsAutoPull: effect's Migrator only runs IDs above the highest recorded one and never compares names. Every project query then fails with no such column: auto_pull and the backend crash-loops at startup without opening a window — the migrator half of #8896, reproduced again by nightly 0.0.39 after #9277.

This adds idempotent repair migration 047 (047_EnsureProjectionProjectsAutoPull) that adds the column only when absent, so it heals affected databases and is a no-op everywhere else. It also logs a loud non-fatal warning naming collided slots on every runMigrations — the production counterpart of the hard failure in scripts/migrate-dev-db.ts. Deliberately non-fatal: refusing to start would brick databases that are otherwise healed (e.g. by this repair migration).

Tests: new 047_EnsureProjectionProjectsAutoPull.test.ts encodes the collision (journal claims 45 under another name, column absent) plus the healthy no-op case; neighboring migration tests (027, 040–042, 046) still pass, typecheck and lint/fmt clean.

Built and verified with OpenCode + Muse Spark.


Note

Medium Risk
Changes SQLite schema repair at startup and migration journal behavior; low blast radius (one column, idempotent) but affects every database boot and could mask other slot collisions via warnings only.

Overview
Addresses startup crash-loops when projection_projects.auto_pull is missing because migration 045 was never applied: Effect’s migrator treats any journal row at ID 45 as “done,” so a fork/nightly that claimed slot 45 under another name permanently skips the real ProjectionProjectsAutoPull migration (#8896).

Adds 047_EnsureProjectionProjectsAutoPull, an idempotent repair that adds auto_pull only when absent (no-op on healthy DBs). Registers it in the migration manifest and wires warnOnMigrationSlotCollisions into runMigrations so production logs a non-fatal warning listing slots where the journal name disagrees with this checkout—loud visibility without refusing startup, since repair migrations can still heal the schema.

New tests simulate the collision (fake journal row at 45, column missing) and confirm healing plus repeat-run safety, plus the healthy no-op path.

Reviewed by Cursor Bugbot for commit 7464886. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add migration 047 to heal skipped 045 and warn on slot collisions

  • Adds migration 047 to idempotently add the auto_pull column with NOT NULL DEFAULT 0 to projection_projects if it is absent, repairing databases that skipped migration 045.
  • Introduces warnOnMigrationSlotCollisions which compares journal entries in effect_sql_migrations against the current manifest and emits a non-fatal warning if slot names differ.
  • Behavioral Change: runMigrations now logs a warning when existing migration journal rows use different names for the same numeric slot.
📊 Macroscope summarized 7464886. 2 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

Databases whose journal already occupied ID 45 (forks, nightlies,
renumbered branches) silently skip 045_ProjectionProjectsAutoPull because
effect's Migrator only compares the highest applied ID, never names. Every
project query then fails with 'no such column: auto_pull' and the backend
crash-loops at startup without opening a window.
Add idempotent repair migration 047 that adds the column when absent, and
log a loud non-fatal warning naming collided slots on every run (fatal
would brick otherwise-healed databases). Production counterpart of the
dev-db slot check in scripts/migrate-dev-db.ts.
Fixes the migrator half of pingdotgg#8896.
Built and verified with OpenCode + Muse Spark.
@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
[44, "ClearAutomaticProjectModelDefaults", Migration0044],
[45, "ProjectionProjectsAutoPull", Migration0045],
[46, "RepairAutomaticSettlementTimestamps", Migration0046],
[47, "EnsureProjectionProjectsAutoPull", Migration0047],

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Highpersistence/Migrations.ts:121

Databases whose journal already has migration ID 47 or a later foreign migration never execute Migration0047, leaving projection_projects.auto_pull absent and causing project queries to fail at startup. Because Migrator.make skips every loader entry with currentId <= latestMigrationId, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/server/src/persistence/Migrations.ts around line 121:
Databases whose journal already has migration ID `47` or a later foreign migration never execute `Migration0047`, leaving `projection_projects.auto_pull` absent and causing project queries to fail at startup. Because `Migrator.make` skips every loader entry with `currentId <= latestMigrationId`, this repair must run outside the max-ID-gated migrator path (or otherwise explicitly handle collided journals).

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Would Approve

Macroscope's review found this PR approvable — This is a focused, self-contained migration bug fix that restores the already-defined auto_pull column, adds collision diagnostics, and includes targeted tests without introducing a new capability or product-default policy. An unresolved high-severity finding identifies a separate edge case involving journals at migration ID 47 or later; that correctness risk is handled independently from this eligibility assessment.

Not approved because:

  • 1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M30-99 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ImBIOS