Uh oh!
There was an error while loading. Please reload this page.
fix(web): collapse oldest pull request comments - #9323
Merged
maria-rcks merged 2 commits intoSep 3, 2026
Conversation
Newest-first already hid the oldest remainder, but the expander sat at the top and said "earlier". Name it oldest and put it on the oldest end of the list. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused one-file UI correction that moves the existing oldest-comment expander to the appropriate chronological edge and updates its wording. Comment loading, pagination, API behavior, and default ordering remain unchanged. You can add or adjust custom eligibility rules. Learn more. |
The change is a label and button placement in the summary tab; the extracted windowing helpers existed only to unit-test that. Co-authored-by: Cursor <cursoragent@cursor.com>
macroscopeappBot
dismissed
their stale reviewSeptember 3, 2026 05:36
Dismissing prior approval to re-evaluate f845773
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newest-first already hid the oldest comments, but the expander sat at the top of the list and said "earlier". It now says "oldest" and sits at the bottom in newest-first (or the top in oldest-first), where those comments belong.
Verified in the running web app on a 49-comment PR: newest comments stay at the top, and "Show 19 oldest comments" is at the bottom of the list.
Before
After
Note
Fix placement of oldest pull request comments button in
PullRequestSummaryTabRenames the hidden-comment pagination label from "earlier" to "oldest" and renders the button before visible comments when sorted by
oldestand after them when sorted bynewest. The button still expands the comment window byCOMMENT_PAGEand caps the displayed count at the hidden count orCOMMENT_PAGE.Macroscope summarized f845773.
Note
Low Risk
UI-only change to comment list layout and button copy in the pull request summary tab; no API or data handling changes.
Overview
Pull request summary comments now place the hidden-comment expander at the chronological edge of the list and label it “oldest” instead of “earlier”.
In
PullRequestSummaryTab, the reveal control is built once asshowOldestCommentsButton(same paging viaCOMMENT_PAGE). With newest first, it renders below the visible comments so newest stay at the top and older thread is loaded from the bottom. With oldest first, it stays above the list. Button text is “Show N oldest comment(s)” rather than “earlier”.Reviewed by Cursor Bugbot for commit f845773. Bugbot is set up for automated code reviews on this repo. Configure here.