Uh oh!
There was an error while loading. Please reload this page.
feat(web): suggest ssh hosts in a dropdown under the host field - #9345
Closed
flamboh wants to merge 2 commits into
Closed
feat(web): suggest ssh hosts in a dropdown under the host field#9345flamboh wants to merge 2 commits into
flamboh wants to merge 2 commits into
Conversation
flamboh
commented
Sep 3, 2026
ContributorAuthor
FABLE IS SO DUMB |
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a cross-layer SSH UX feature that replaces the existing suggestions panel with an autocomplete and adds a desktop IPC path running You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Fable 5.1 on behalf of Oliver
Problem
The SSH tab lists discovered hosts in a fixed panel below the form. Finding one means scrolling that panel, and it takes up the dialog even when you already know the alias. Picking a host there also skipped the form, so you never saw which user or port would be used.
Fix
Suggestions now drop down from the "SSH host or alias" field as you type, ranked with the prefix-then-substring filter from #9171. The first nine rows carry ⌘1 to ⌘9 shortcuts, the same keybindings the command palette uses for "New thread in project", and the rest scroll.
Picking a row by click, shortcut, or arrow keys and Enter resolves the alias with
ssh -Gthrough a newresolveSshHostdesktop bridge method, fills Username and Port with the resolved values, and connects through the same path as the Add environment button. The dropdown is built on the base-ui autocomplete primitive so it overflows the dialog instead of being clipped by its scroll area.Host discovery re-runs each time the SSH tab is shown, which replaces the old Refresh button and lets a failed first discovery recover.
Includes the commit from #9171 and supersedes it.
UI changes
Before
After
Verification
vp test run apps/web/src/state/desktopSshHosts.test.ts, 9 tests passedvp lint <changed files> --report-unused-disable-directivesvp fmt --check <changed files>vp run --filter @t3tools/web typecheckvp run --filter @t3tools/contracts typecheckvp run --filter @t3tools/desktop typecheckgit diff --check origin/main...HEADChanges prepared by GPT-5.6 Sol through Codex, orchestrated by Fable 5.1 in T3 Code.
Note
Add SSH host autocomplete dropdown to desktop SSH connection form
resolveSshHostdesktop IPC to populate username and port.filterDiscoveredSshHostsin desktopSshHosts.ts to rank case-insensitive prefix matches ahead of substring matches, preserving input order within each tier.RESOLVE_SSH_HOST_CHANNELIPC channel andresolveSshHostmethod in sshEnvironment.ts, backed byDesktopSshEnvironment.resolveHostwhich trims the alias before resolving.ConnectionsSettingswhenresolveSshHostrejects.Macroscope summarized e576fda.