fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(mobile): pressed and disabled styles no longer apply unconditionally - #9355

Merged
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants
Sep 3, 2026
Merged

fix(mobile): pressed and disabled styles no longer apply unconditionally#9355
juliusmarminge merged 1 commit into
mainfrom
fix/mobile-uniwind-pseudo-variants

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

After #9331 pinned the monorepo to tailwindcss@4.3.3, every active:, disabled:, theme, data-* and rtl: variant on mobile compiled as if it had no condition. The visible symptom (reported in #mobile-ios) was the Appearance screen: each theme card's active:bg-subtle press overlay rendered permanently, so every card was tinted pink on T3 Chat. The same applies to every other active: press state in the app.

Tailwind 4.3.3 stopped nesting variants under the utility class and emits compound selectors instead:

/* <= 4.3.2 *//* 4.3.3 */
.active\:bg-subtle { &:active {…} } .active\:bg-subtle:active {…}

Uniwind 1.11.0 only reads variant tokens from nested rules, so on the flattened form it never sets the active/disabled/theme flag.

Fix

Extend the existing patches/uniwind@1.11.0.patch so the processor also reads variant tokens that follow the leading class token. Compound selectors the runtime cannot express ([aria-disabled="true"]) are dropped instead of treated as unconditional, which matches what the nested form compiled to before. Both the four dist bundles and the TypeScript source in the patch are updated.

Verified by running Uniwind's ProcessorBuilder on both selector shapes and on the real apps/mobile/global.css: active:* entries now carry active: true, disabled:* carry disabled: true, plain utilities are unchanged.

No screenshots: this was fixed on a Linux box without an iOS simulator. The before is in the Discord thread; a TestFlight build off this branch should show the theme cards back to bg-card.

Written by Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Medium Risk
Changes vendored Uniwind CSS compilation and native style reinit behavior; incorrect variant parsing could still mis-apply press/theme/disabled styles app-wide on mobile.

Overview
Extends the uniwind@1.11.0 patch so mobile styling works again after Tailwind 4.3.3 started emitting flat compound selectors (e.g. .active\:bg-subtle:active) instead of nested &:active rules. Uniwind’s ProcessorBuilder now pulls active, disabled, focus, theme, RTL, and data-* variant flags from tokens after the utility class via readSelectorVariants / withSelectorVariants, and ignores trailing selector parts the native runtime cannot represent so they are not applied unconditionally.

The Metro transformer also computes a SHA-256 fingerprint of compiled styles plus themes and passes it into Uniwind.__reinit; in __DEV__, native config skips full reinit when the fingerprint is unchanged (avoids redundant work on hot reload). pnpm-lock.yaml updates the patch hash for the enlarged patch.

Reviewed by Cursor Bugbot for commit ff068fe. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix pressed and disabled styles applying unconditionally in mobile CSS processor

Patches uniwind@1.11.0 to fix selector-variant parsing so pressed and disabled styles only apply when their conditions match. Updates bundled outputs, Metro transformer sections, and native configuration to stay consistent with the patched parser.

Macroscope summarized ff068fe.

Tailwind 4.3.3 stopped nesting variants under the utility class
(`.active\:x { &:active {} }`) and emits compound selectors instead
(`.active\:x:active {}`). Uniwind 1.11.0 only reads variant tokens from
nested rules, so after #9331 pinned the monorepo to 4.3.3 every `active:`,
`disabled:`, theme, data-* and rtl variant on mobile compiled as if it had
no condition. The visible symptom was the appearance screen: each theme
card's `active:bg-subtle` press overlay rendered permanently.
Extend the existing uniwind patch so the processor also reads variant
tokens that follow the leading class token, and drop compound selectors it
cannot express (`[aria-disabled="true"]`) instead of treating them as
unconditional, which matches what the nested form compiled to before.
Co-Authored-By: Claude Code <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.8 KiB13.7 KiB−7 B (−0.0%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB−2 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.7 KiB−5 B (−0.1%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB58.5 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.6 KiB13.6 KiB−8 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB−7 B (−0.1%)7.8 KiB
ClaudeLive turn WebSocket decoded57.9 KiB57.9 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 854541a · PR result: ff068fe · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at ff068fe

Macroscope's review found this PR approvable — This is a focused mobile CSS-processor compatibility fix that restores active, disabled, theme, RTL, and data-attribute conditions while dropping selectors the native runtime cannot represent. The accompanying lockfile change only updates the patch integrity reference, with no product-default or static-analysis configuration changes.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 1f7a3c1 into mainSep 3, 2026
21 checks passed
@juliusmarminge
juliusmarminge deleted the fix/mobile-uniwind-pseudo-variants branch September 3, 2026 06:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL500-999 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge