feat(web): mod+w closes the active right panel tab before the window by juliusmarminge · Pull Request #9363 · pingdotgg/t3code

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}

juliusmarminge · 2026-09-03T06:05:39Z

Problem

Mod+W only closed a focused terminal. Anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs (diff, files, browser, PR) meant reaching for the mouse — or losing the window by accident.

Fix

Add a rightPanel.close keybinding command, bound by default to mod+w when the terminal is not focused (the existing terminal.close rule keeps winning while it is).

Closes the active right-panel tab, one per press, through the existing closeRightPanelSurface path so terminal-close and agent-controlled-browser confirmations still apply.
With nothing open the keydown is left alone, so the shortcut keeps its native meaning (close window on desktop). Key repeat is ignored so a held key doesn't chew through every tab and then the window.
The pull-requests page's shared panel handles the command itself since it renders no ChatView.
Works while the in-app preview has focus: the preview WebContentsView already forwards mod+W to the main window.

Browsers reserve mod+w and never deliver it to the page; that was already true of terminal.close. Docs note the rebind.

Testing

apps/web/src/keybindings.test.ts: mod+w resolves to terminal.close with terminal focus and rightPanel.close otherwise.
apps/server/src/keybindings.test.ts: default binding present.
apps/web typecheck clean; targeted lint has no new findings.

Model: Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

Note

Low Risk
Keyboard UX and default bindings only; behavior is gated on panel/terminal focus and falls through to native close when nothing is open.

Overview
Adds a rightPanel.close keybinding (default mod+w when the terminal is not focused) so users can dismiss right-panel tabs from the keyboard without immediately triggering close-window.

mod+w now resolves to terminal.close with terminal focus and rightPanel.close otherwise. ChatView handles the command by closing the active right-panel surface through the existing close path, skipping key repeat, and leaving the event untouched when no panel is open so desktop mod+w still closes the window. The pull-requests route registers the same shortcut locally because it does not mount ChatView.

Contracts, shared defaults, server/web tests, and user keybinding docs are updated (including browser mod+w rebind guidance).

^{Reviewed by Cursor Bugbot for commit 14e8bb0. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add `rightPanel.close` command bound to `mod+w` with terminal-focus precedence

Adds rightPanel.close to the static keybinding command registry and maps it to mod+w with a context gate so it only applies when terminalFocus is false; the existing terminal.close rule keeps terminal precedence
Wires the new command into ChatView.tsx and the pull-requests route pull-requests.tsx; an active right-panel surface closes on the first matching keydown, with repeated keydowns ignored
Native browser behavior is preserved when no right-panel surface is active; the docs note users may want an alternate binding to avoid the browser closing the window
Risk: the pull-requests route installs its own window keydown listener outside ChatView; if rightPanel.close is not the resolved command it leaves the event untouched, so check the terminal-focus context resolution in pull-requests.tsx for regressions

^{Macroscope summarized 14e8bb0.}

Mod+W only closed a focused terminal; anywhere else it fell straight through to the desktop close-window accelerator, so closing a stack of right-panel tabs meant reaching for the mouse. Add a `rightPanel.close` command bound to `mod+w` when the terminal is not focused. It closes the active right-panel tab through the existing close path (so terminal and agent-browser confirmations still apply), one tab per press, and leaves the event alone once nothing is open so the shortcut keeps its native meaning. The pull-requests page's shared panel handles the command itself since it renders no ChatView. Co-Authored-By: Claude Code <noreply@anthropic.com>

github-actions · 2026-09-03T06:08:00Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.7 KiB	13.7 KiB	+2 B (+0.0%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	−14 B (−0.2%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.7 KiB	6.7 KiB	+16 B (+0.2%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	58.5 KiB	58.5 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.6 KiB	13.7 KiB	+161 B (+1.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	−5 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.6 KiB	6.7 KiB	+166 B (+2.5%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.9 KiB	59.3 KiB	+1.4 KiB (+2.5%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 9f9359b · PR result: 14e8bb0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 113.8 KiB
Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp · 2026-09-03T06:14:28Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR adds a new default mod+w action that changes shipped keyboard behavior and can be backfilled into users' persisted keybinding configurations. Although the implementation is contained, product-default changes require human review.

^{You can add or adjust custom eligibility rules. Learn more.}