Uh oh!
There was an error while loading. Please reload this page.
test(web): remove static markup-only component tests - #9364
Conversation
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR only removes six static-markup web unit tests; production components, runtime paths, and product defaults remain unchanged. The impact is limited to reduced brittle test coverage in CI, with no customer-facing behavior change. Notes:
You can add or adjust custom eligibility rules. Learn more. |
problem
six web component test files rendered components to static html and asserted copied class names, serialized props, or text. they did not exercise layout, tooltips, browser input state, or user interaction, so they could pass while the behavior named by the tests was broken.
change
command.test.tsxandProjectScriptsControl.test.tsx, which only pinned tailwind strings in server-rendered markupPreviewChromeRow.test.tsxandPanelLayoutControls.test.tsx, which only confirmed that input props were serialized into html and could not exercise the focus or tooltip behavior they claimedComposerPendingTerminalContexts.test.tsx, whose only non-style assertions duplicateterminalContext.test.tscoverage for expiration and label formattingComposerPromptLengthValidation.test.tsx, whose message and rejection path are already covered by the strongercomposerSubmission.test.tsproduction code is unchanged.
evidence
before removal:
vp test runon the six removed files pluscomposerSubmission.test.tsandterminalContext.test.ts: 8 files passed, 34 tests passedafter removal:
vp test run apps/web/src/components/chat/composerSubmission.test.ts apps/web/src/lib/terminalContext.test.ts apps/web/src/components/preview/PreviewView.test.tsx: 3 files passed, 36 tests passedvp run --filter @t3tools/web typecheck: passedgit diff --check: passedcreated by gpt-5.6-sol with hermes agent.
Note
Low Risk
Test-only deletions with no runtime changes; risk is reduced brittle coverage, not user-facing regressions if the cited unit tests stay green.
Overview
Removes six web component tests that only used
renderToStaticMarkupand asserted Tailwind classes, serialized HTML attributes, or duplicated strings—without covering focus, tooltips, layout, or interaction.Deleted files:
ProjectScriptsControl.test.tsx,ComposerPendingTerminalContexts.test.tsx,ComposerPromptLengthValidation.test.tsx,PanelLayoutControls.test.tsx,PreviewChromeRow.test.tsx, andui/command.test.tsx. No production code changes.Behavior those tests hinted at remains covered elsewhere (e.g.
composerSubmission.test.tsfor prompt length limits,terminalContext.test.tsfor terminal context labels/formatting).Reviewed by Cursor Bugbot for commit f4fa531. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove static markup-only component tests from web app
ProjectScriptsControl,ComposerPendingTerminalContextChip,ComposerPromptLengthValidation,PanelLayoutControls,PreviewChromeRow, andcommandshell geometry.Macroscope summarized f4fa531.