fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(environments): draw the machine icon everywhere an environment is named - #9365

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites
Sep 3, 2026
Merged

fix(environments): draw the machine icon everywhere an environment is named#9365
juliusmarminge merged 1 commit into
mainfrom
t3code/environment-icons-remaining-sites

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

#9299 gave each environment a machine icon, but several surfaces kept drawing a generic server, cloud, or desktop for an environment. Two were spotted right away: the command palette project rows (server glyph) and the desktop composer's "Run on" selector (clouds for everything). An audit of every place an environment is named turned up more.

Fix

Every site below now resolves the same resolveEnvironmentMachineKind(serverConfig) as the sidebar, so an environment wears one icon everywhere.

Web

  • Desktop composer "Run on" selector (BranchToolbarEnvironmentSelector): trigger, locked label, and menu items. The mobile-width menu was already done.
  • Command palette: project row descriptions ("nucbox-1 · /home/julius/…") and the trailing indicator on thread rows. The thread indicator also now shows whenever the thread's environment is not the primary, matching the sidebar, so the hosted app gets it too.
  • Provider settings device tabs, which drew a transport icon (monitor / cloud / terminal / laptop) per connection type. The tab's detail text already says "SSH" or "T3 Connect", so the icon is now the machine.

Mobile

  • New-task environment picker and the composer's "on <environment>" control.
  • Add project → Environments list.
  • Archive: the environment label on each project group header.
  • Settings → Client storage rows.

Left as-is on purpose: the sidebar project-header cloud, which stands for "this project has members on several remote environments" rather than one machine; the T3 Connect sign-in and empty-state glyphs, which are about the service, not an environment; and the Settings → Environments row icon, which is a section label.

Verification

Typecheck passes for web and mobile. Lint is clean on every changed file. Existing CommandPalette, ProviderSettingsPanel, ThreadStatusIndicators, BranchToolbar, mobile archive, and mobile projects suites pass (155 tests). No new logic was added, only icon resolution wired to existing data, so no new tests.

Built with Claude Fable 5 in Claude Code.

🤖 Generated with Claude Code


Note

Low Risk
UI-only icon swaps using existing resolveEnvironmentMachineKind; thread remote-indicator visibility is slightly broader on hosted web but behavior matches the sidebar.

Overview
Replaces generic server/cloud/desktop glyphs with the shared machine icon resolved via resolveEnvironmentMachineKind(serverConfig) across web and mobile, so each environment looks the same as in the sidebar.

Web: Composer Run on selector (locked label, trigger, menu items), command palette project descriptions and thread trailing status, and provider settings device tabs now use EnvironmentMachineIcon instead of monitor/cloud/terminal icons. Thread rows show the remote-environment indicator whenever the thread’s environment is not primary (including hosted web, where every environment is remote).

Mobile: Archive project headers, add-project environment list, new-task environment picker and composer on … control, and Settings → client storage rows use EnvironmentMachineSymbol with server config lookup.

User docs expand where environment icons appear. Presentation-only wiring; no new resolution logic.

Reviewed by Cursor Bugbot for commit 8156788. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Draw environment machine icon across all surfaces that name an environment

  • Replaces fixed server-rack, desktop, cloud, and target-type icons with a shared EnvironmentMachineIcon resolved from each environment's server configuration, falling back to server when the kind is missing.
  • Updates web surfaces: branch toolbar selector, command palette remote results, thread row trailing status, and provider settings device tabs.
  • Updates mobile surfaces: archived threads project headers, add-project environment selector, new-task environment picker, new-task draft composer, and client-storage environment rows.
  • In ThreadRowTrailingStatus, remote-thread detection now compares directly against the primary environment ID; when no primary ID exists (hosted-app case) every thread is treated as remote.
  • Removes the target-type-based providerEnvironmentIcon utility from ProviderSettingsPanel.
  • Risk: environments whose server configuration lacks a machine kind silently fall back to the generic server icon; reviewers should confirm useServerConfigMachineKind (or equivalent resolver) returns a sensible default for all connection types.

Macroscope summarized 8156788.

… named
The last pass covered the sidebar, the composer's mobile Run on menu, and
the pull request pages, but several surfaces still drew a generic server,
cloud, or desktop for an environment: the desktop Run on selector, command
palette project rows and thread indicators, the provider settings device
tabs, and on mobile the add-project and new-task environment pickers, the
composer environment control, the archive, and the storage settings rows.
All of them now resolve the same machine kind as everything else.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.7 KiB13.6 KiB−122 B (−0.9%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+2 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.7 KiB6.6 KiB−124 B (−1.8%)7.8 KiB
CodexLive turn WebSocket decoded58.5 KiB57.1 KiB−1.4 KiB (−2.4%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.5 KiB+12 B (+0.1%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−1 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.5 KiB+13 B (+0.2%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages880 (0.0%)21

Baseline: d4bd892 · PR result: 8156788 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 8156788

Macroscope's review found this PR approvable — The changes are limited to rendering existing machine metadata consistently across web and mobile environment labels, with no changes to workflows, data, APIs, or deployment behavior. The hosted-thread indicator is slightly more visible, but remains a small presentation-only adjustment.

You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit 829c3db into mainSep 3, 2026
22 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/environment-icons-remaining-sites branch September 3, 2026 06:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge