fix(desktop): restore second-press quit fallback

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Hold mode lost its quick second-press escape hatch when quit confirmation modes were split, so retrying Cmd/Ctrl+Q could only start another hold. This restores the existing 500 ms second-press path in hold mode while keeping direct and dedicated double-press modes unchanged. Verified with all 25 quit-handler tests, desktop typecheck, and targeted lint and formatting. Implemented with gpt-5.6-sol in the Codex harness.

---

Note

Low Risk
Localized change to desktop quit shortcut handling with updated unit tests; restores prior user-facing behavior rather than new quit paths.

Overview
Hold mode again treats a second Cmd/Ctrl+Q within 500 ms as quit, not only when confirmation mode is double-click. That path was the escape hatch when macOS drops key events and a hold never completes.

In QuitHold.ts, the quick second-press check runs for any non-direct mode after settings resolve; direct still quits on the first press. Dedicated double-click behavior (hints, slow presses as separate attempts) stays covered by existing tests; one hold-mode test now expects quit on a quick second press.

^{Reviewed by Cursor Bugbot for commit 18a9e40. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Restore second-press quit fallback for hold mode in makeQuitShortcutHandler

Removes the restriction in makeQuitShortcutHandler that limited the quick-second-press quit path to double-click mode. A second press within QUIT_DOUBLE_PRESS_MS now quits regardless of the resolved confirmation mode, including hold mode. This handles missed completion events on macOS. Test in QuitHold.test.ts updated to expect a quit call without a second hold notification.

^{Macroscope summarized 18a9e40.}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The change alters the default hold-to-quit interaction so a second Cmd/Ctrl+Q within 500 ms quits instead of starting another hold attempt. Although the implementation is small and tested, this user-visible default behavior change warrants deliberate review.

^{You can add or adjust custom eligibility rules. Learn more.}