fix(web): dont collapse composer when interacting with bottom row by extoci · Pull Request #9490 · pingdotgg/t3code

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}

extoci · 2026-09-03T22:03:21Z

What Changed

Keep the composer open while interacting with branch and environment controls in the bottom row, including their portaled popups.

Why

Those controls render outside the composer DOM and were treated as outside interactions, so the composer collapsed during the interaction. The controls and their floating layers now participate in the composer event scope, with a focused regression test.

UI Changes

Before:

Screen.Recording.2026-09-04.at.1.15.57.AM.mov

After:

Screen.Recording.2026-09-04.at.1.21.44.AM.mov

Tests

vp test run src/components/chat/composerEventScope.test.ts src/components/composerFooterLayout.test.ts src/components/BranchToolbar.logic.test.ts --project unit (101 passed)
vp run --filter @t3tools/web typecheck

Model: 5.6
Harness: Codex

Note

Low Risk
Focused composer focus/blur UX change in the web app with a targeted regression test; no auth, data, or API impact.

Overview
Fixes the chat composer collapsing while users interact with branch, environment, and workspace controls on the bottom context strip, including their portaled menus and dropdowns.

Those controls sit outside the composer DOM, so blur/focus handling treated them as outside clicks. isInsideRestingComposerControlScope now treats [data-composer-context-control] as in-scope, and branch toolbar Select/Menu/Combobox popups spread composerFloatingLayerProps so portaled layers count too. ChatComposer uses the unified scope helper instead of only isInsideComposerFloatingLayer. A unit test covers context-strip controls.

^{Reviewed by Cursor Bugbot for commit a81045f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix composer closing on focus of bottom-row `BranchToolbar` controls

Marks the run-context, branch-reference, environment-mode, and environment-select popups in BranchToolbar as composer-owned floating layers by passing shared composer floating-layer props to each popup.
Updates ChatComposer desktop blur cleanup and focus-in containment checks to use the broader resting composer control scope instead of checking only for composer-owned floating layers.
Extends composerEventScope.isInsideRestingComposerControlScope to recognize composer context-control elements, so focus stays in the composer when interacting with context-strip controls, resting images, or floating layers.
Adds a unit test verifying that composer context-control elements belong to the resting composer control scope.

^{Macroscope summarized a81045f.}

macroscopeapp · 2026-09-03T22:09:15Z

Approvability

Verdict: Approved at a81045f

Macroscope's review found this PR approvable — This is a focused, self-contained web UX fix that keeps the existing composer open while users interact with bottom-row controls and their portaled popups. It includes targeted regression coverage and does not affect APIs, data, security-sensitive code, product defaults, or deployment behavior.

^{You can add or adjust custom eligibility rules. Learn more.}