Skip to content

fix(mobile): resolve Antigravity provider icon and normalize driver matching - #9495

Merged
t3dotgg merged 2 commits into
pingdotgg:mainfrom
Invictine:fix/mobile-antigravity-icon
Sep 3, 2026
Merged

fix(mobile): resolve Antigravity provider icon and normalize driver matching#9495
t3dotgg merged 2 commits into
pingdotgg:mainfrom
Invictine:fix/mobile-antigravity-icon

Conversation

@Invictine

@InvictineInvictine commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes an issue where the Antigravity section header in the mobile model picker sheet (ThreadSettingsSheet) displays the fallback Codex swirl icon instead of the Antigravity logo.

Problem & Root Cause

  1. Strict equality in ProviderIcon: ProviderIcon.tsx checked props.provider === "antigravity" using strict case-sensitive equality. If passed uppercase or mixed-case strings ("ANTIGRAVITY", "Antigravity"), it fell through to the default Codex swirl SVG.
  2. Driver resolution fallback in ThreadSettingsSheet: In useThreadSettingsCatalogItems (ThreadSettingsSheet.tsx), driver was resolved from group.models[0]?.providerDriver. If group.models[0] was not yet populated or lacked providerDriver, driver evaluated to undefined, immediately falling through to the Codex swirl.

Changes

  • apps/mobile/src/components/ProviderIcon.tsx: Case-insensitive and trimmed check for "antigravity" (props.provider?.trim().toLowerCase() === "antigravity").
  • apps/mobile/src/features/threads/ThreadSettingsSheet.tsx: Add group.providerKey fallback when group.models[0]?.providerDriver is absent.

Note

Low Risk
Localized mobile UI/icon resolution with no auth, data, or routing changes.

Overview
Fixes the mobile model picker showing the default Codex swirl instead of the Antigravity logo for some provider groups.

ProviderIcon now matches Antigravity after trimming and lowercasing props.provider, so variant casing or stray whitespace no longer miss the dedicated asset.

useThreadSettingsCatalogItems in ThreadSettingsSheet resolves the header driver from the first model’s providerDriver, and falls back to group.providerKey when that field is missing so icon selection still runs before models are fully populated.

Reviewed by Cursor Bugbot for commit d1f930a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix Antigravity provider icon matching and normalize driver fallback in useThreadSettingsCatalogItems

  • Makes the antigravity provider check in ProviderIcon trim whitespace and compare case-insensitively so the correct icon displays despite minor value variations
  • Adds a fallback in useThreadSettingsCatalogItems to use the provider group key when the first model in a catalog group has no provider driver, so primary-provider status is still determined correctly
  • Risk: groups whose first model lacks a driver now derive driver identity from the group key rather than leaving it unset, which may change which groups are treated as primary providers

Macroscope summarized d1f930a.

@github-actionsgithub-actionsBot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 3, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:4898a038b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadapps/mobile/src/components/ProviderIcon.tsx Outdated
@macroscopeapp

macroscopeappBot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at d1f930a

Macroscope's review found this PR approvable — This is a two-line, mobile-only bug fix with bounded effects: canonical Antigravity driver variants receive the correct icon, while unrelated drivers remain distinct, and incomplete catalog metadata gets a safe fallback. It introduces no schema, deployment, security, billing, or static-analysis changes.

You can add or adjust custom eligibility rules. Learn more.

@Invictine

Copy link
Copy Markdown
ContributorAuthor

Updated to address Macroscope review feedback:

  • Reverted all changes to fallback provider labels (\modelOptions.ts).
  • Removed all \google\ / \gemini\ alias mappings, scoping the fix strictly to case-insensitive and whitespace-tolerant matching of the official \�ntigravity\ driver identifier.
  • Retained the \group.providerKey\ fallback in \ThreadSettingsSheet.tsx\ for robust driver resolution.

@github-actionsgithub-actionsBot added size:XS 0-9 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Sep 3, 2026
@t3dotgg
t3dotgg merged commit ef4cc60 into pingdotgg:mainSep 3, 2026
26 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS0-9 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Invictine@t3dotgg