remove self from redis_object from _add_vector in RedisStorage - #89
Open
sarthakTUM wants to merge 2 commits into
Open
remove self from redis_object from _add_vector in RedisStorage#89sarthakTUM wants to merge 2 commits into
sarthakTUM wants to merge 2 commits into
Conversation
sarthakTUM
commented
Feb 16, 2020
CollaboratorAuthor
looks like CI is broken? |
amorgun
commented
Feb 18, 2020
Collaborator
LGTM |
sarthakTUM
commented
Feb 20, 2020
CollaboratorAuthor
Any updates on this PR? |
sarthakTUM
commented
Feb 26, 2020
CollaboratorAuthor
@amorgun do you have to rights to merge? |
amorgun
commented
Feb 26, 2020
Collaborator
No, I cannot merge requests. We have to wait for @pixelogik. |
pixelogik
commented
Jan 21, 2021
Owner
@amorgun@sarthakTUM Sorry for the long silence. Last year was crazy because of Covid, work and family. I do not have much time for this project anymore. Are you interested in joining the project so that you can also accept pull requests? |
sarthakTUM
commented
Jan 21, 2021
CollaboratorAuthor
no problem, I hope you are doing fine @pixelogik. Sure, I am happy to join this project. |
amorgun
commented
Jan 21, 2021
Collaborator
@pixelogik Yes, I would like to join the project. |
pixelogik
commented
Feb 16, 2021
Owner
@amorgun@sarthakTUM I invited you both as contributors. Looking forward to working together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #88