Skip to content

refactor: updates to comments and code per feedback - #101

Merged
bcoe merged 4 commits into
pkgjs:mainfrom
shadowspawn:feature/pr-nits
Apr 11, 2022
Merged

refactor: updates to comments and code per feedback#101
bcoe merged 4 commits into
pkgjs:mainfrom
shadowspawn:feature/pr-nits

Conversation

@shadowspawn

@shadowspawnshadowspawn commented Apr 11, 2022

Copy link
Copy Markdown
Collaborator

Did a second pass through applying suggestions so far from node PR

  • improving comments
  • more arrow functions

@shadowspawnshadowspawn changed the title refactor: fix types and the like based on PR feedbackdocs: fix typos in comments and the like based on PR feedbackApr 11, 2022
@shadowspawnshadowspawn changed the title docs: fix typos in comments and the like based on PR feedbackdocs: fix typos in comments based on PR feedbackApr 11, 2022
@shadowspawnshadowspawn changed the title docs: fix typos in comments based on PR feedbackrefactor: minor updates to comments and code per feedbackApr 11, 2022
@shadowspawnshadowspawn changed the title refactor: minor updates to comments and code per feedbackrefactor: updates to comments and code per feedbackApr 11, 2022
@shadowspawn
shadowspawn marked this pull request as ready for review April 11, 2022 09:50
@bcoe
bcoe merged commit 95536a0 into pkgjs:mainApr 11, 2022
@shadowspawn
shadowspawn deleted the feature/pr-nits branch June 5, 2022 03:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shadowspawn@bcoe