Problem Using curl -Ssf https://pkgx.sh to Install pkgx

[harrisg0]

Hi. Just noticed this error when using an Ubuntu image ubuntu-2204:2024.01.2 and macOS 14.6. It looks like curl https://pkgx.sh returns a Windows script now? The Ubuntu command below worked for months, now it doesn't.

On Ubuntu

curl -fsS https://pkgx.sh | /bin/bash
/bin/bash: line 3: =: command not found
/bin/bash: line 6: =: command not found
/bin/bash: line 9: syntax error near unexpected token {' /bin/bash: line 9: if (!(Test-Path $installDir)) {'

On macOS

curl https://pkgx.sh | sh
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 892 100 892 0 0 6288 0 --:--:-- --:--:-- --:--:-- 6326
sh: line 3: =: command not found
sh: line 6: =: command not found
sh: line 9: syntax error near unexpected token {' sh: line 9: if (!(Test-Path $installDir)) {'

[olekristensen]

ditto here

[tannevaled]

same problem here.
even using a versioned source.

3.0.0

PKGX_INSTALLER_VERSION='3.0.0'
PKGX_INSTALLER_URL="https://github.com/pkgxdev/setup/releases/download/v${PKGX_INSTALLER_VERSION}/installer.sh"
curl -Ssf ${PKGX_INSTALLER_URL} | sh
command -v pkgx || export PATH="/usr/local/bin:${PATH}"
pkgx gum style --foreground 212 --border-foreground 212 --border double --align center --width 50 --margin '1 2' --padding '3 4' 'Installing versioned commands'

bash: line 15: pkgx: command not found

3.1.0

PKGX_INSTALLER_VERSION='3.1.0'
PKGX_INSTALLER_URL="https://github.com/pkgxdev/setup/releases/download/v${PKGX_INSTALLER_VERSION}/installer.sh"
curl -Ssf ${PKGX_INSTALLER_URL} | sh
command -v pkgx || export PATH="/usr/local/bin:${PATH}"
pkgx gum style --foreground 212 --border-foreground 212 --border double --align center --width 50 --margin '1 2' --padding '3 4' 'Installing versioned commands'

bash: line 15: pkgx: command not found

there seems to be unversioned part of the install workflow.

[olekristensen]

The GitHub actions were overwriting the install.sh script in the AWS bucket with the windows script.
I've corrected this in PR #269

[mxcl]

oops, my bad

[tannevaled]

should it be possible to have versioned archive download path to avoid this problem?

[tannevaled]

presently using

curl -Ssf https://pkgx.sh/$(uname)/$(uname -m).tgz | sudo tar xz -C /usr/local/bin

i do not get pkgm

[mxcl]

should it be possible to have versioned archive download path to avoid this problem?

I fail to see how that would have avoided this typo bug.

Oh OK, I see your earlier post. You are downloading the versioned installer script which is completely separate from the mechanism that is the bug here. If your script was also effected by this bug then I suggest that your script is not working how you think. Downloading the script from github can not be affected by this bug. We have no control over how github delivers sources.

i do not get pkgm

The instructions for installing pkgm are at the pkgm page. This tarball does not contain pkgm nor do we claim it does anywhere.

[mxcl]

Fixed. Thanks @olekristensen

[tannevaled]

should it be possible to have versioned archive download path to avoid this problem?

I fail to see how that would have avoided this typo bug.

Oh OK, I see your earlier post. You are downloading the versioned installer script which is completely separate from the mechanism that is the bug here. If your script was also effected by this bug then I suggest that your script is not working how you think. Downloading the script from github can not be affected by this bug. We have no control over how github delivers sources.

i do not get pkgm

The instructions for installing pkgm are at the pkgm page. This tarball does not contain pkgm nor do we claim it does anywhere.

strange
some days ago i used to

curl -Ssf https://pkgx.sh | sh

and got both pkgx and pkgm

[mxcl]

curl -Ssf https://pkgx.sh | sh installs pkgm as well yes, you said you were using: curl -Ssf https://pkgx.sh/$(uname)/$(uname -m).tgz | sudo tar xz -C /usr/local/bin which only contains pkgx.

[tannevaled]

curl -Ssf https://pkgx.sh | sh installs pkgm as well yes, you said you were using: curl -Ssf https://pkgx.sh/$(uname)/$(uname -m).tgz | sudo tar xz -C /usr/local/bin which only contains pkgx.

i saw. as the installer bug broke all my CI stacks, i quickly tried a way to install even with a broken script and naively thought the archive contained both as with a regular pkgx package.

[mxcl]

yeah sorry for the breakage. I will endeavor to figure out how to write some test for preventing such a thing again.

[tannevaled]

no problem. it just make me think to a way to version even this step in my CI to be able to pin to an installer version.