Skip to content

Detects Microsoft WSL kernel and installs python3-dev - #111

Merged
sarun87 merged 1 commit into
platform9:masterfrom
sirredbeard:master
Jan 11, 2021
Merged

Detects Microsoft WSL kernel and installs python3-dev#111
sarun87 merged 1 commit into
platform9:masterfrom
sirredbeard:master

Conversation

@sirredbeard

Copy link
Copy Markdown
Contributor

Closes#107, provides python3-dev needed for building netifaces extension. Tested by hand on Ubuntu on WSL.

Closes#107, provides python3-dev needed for building netifaces extension. Tested by hand on Ubuntu on WSL.
@sarun87

Copy link
Copy Markdown
Contributor

Wonder if there is a specific field we can look at rather than a blanked grep. It does fix the issue quickly, so lgtm.
/lgtm
/approve

@sirredbeard

Copy link
Copy Markdown
ContributorAuthor

There really isn't a great way to detect if you are running inside WSL other than to check for microsoft in the WSL1 "kernel" or WSL2 kernel uname string. The next best alternative is attempting to run a Windows .exe as a test, something like cmd.exe /C "echo" and checking the exit code.

See the extensive discussion here microsoft/WSL#423

@sarun87
sarun87 merged commit 3af42b6 into platform9:masterJan 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation of Platform9 CLI Failed on WSL: "netifaces.c:1:10: fatal error: Python.h: No such file or directory"

2 participants

@sirredbeard@sarun87