Adds dash system dependency - #42
Conversation
Summary of ChangesHello @vgpopov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Dockerfile to include the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the dash system dependency to the Dockerfile. My review finds that this dependency is likely redundant, as dash is the default shell on the Debian-based r-base image and should already be present. I've recommended removing this unnecessary package installation to keep the Dockerfile clean.
|
|
||
| # Install system dependencies required for R packages | ||
| RUN apt-get update && apt-get install -y \ | ||
| dash \ |
There was a problem hiding this comment.
Pin catalog deps with ~ prefix, bump package-builder
…l race Single-pass renv::restore() with default Ncpus runs installs in parallel, which races on dependencies like ggplot2 needing tibble first. PR #42 in differential-clonotype-abundance fixed this with a two-pass: parallel attempt (errors tolerated), then sequential rerun with clean=TRUE. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
No description provided.