Skip to content

Switch to cmd.yml - #757

Merged
mergify[bot] merged 5 commits into
playframework:mainfrom
mkurz:cmd.yml
May 6, 2022
Merged

Switch to cmd.yml#757
mergify[bot] merged 5 commits into
playframework:mainfrom
mkurz:cmd.yml

Conversation

@mkurz

@mkurz mkurz commented May 3, 2022

Copy link
Copy Markdown
Member

@mkurz
mkurz marked this pull request as ready for review May 3, 2022 21:58
@mkurz
mkurz marked this pull request as draft May 3, 2022 21:59
@mkurz mkurz closed this May 3, 2022
@mkurz mkurz reopened this May 3, 2022
@mkurz

mkurz commented May 3, 2022

Copy link
Copy Markdown
Member Author

I have no idea why GitHub action test workflow isn't running for this PR...

@BillyAutrey

Copy link
Copy Markdown
Member

I have no idea why GitHub action test workflow isn't running for this PR...

Found the error here - https://github.com/playframework/play-json/actions/runs/2266633506/workflow#L34

If you click on Checks for a PR that doesn't run checks, you can see which step has an error on the left. It shows up as a text box with an exclamation point.

From there, it says:

Invalid workflow file: .github/workflows/build-test.yml#L34
invalid value workflow reference: workflow file should have either a '.yml' or '.yaml' file extension

Clicking in on that error takes me to the first link. Seems it doesn't like the format of that command file, because it thinks playframework/.github/.github/workflows/contact@playframework.com isn't a proper yaml.

Comment thread .github/workflows/build-test.yml Outdated
@BillyAutrey

Copy link
Copy Markdown
Member

Changed the file, and now it works. :)

@mkurz

mkurz commented May 4, 2022

Copy link
Copy Markdown
Member Author

If you click on Checks for a PR that doesn't run checks, you can see which step has an error on the left. It shows up as a text box with an exclamation point.

Actually I do know that and used those error messages a lot when I worked on all that GitHub actions stuff. However yesterday it was different; I had the feeling the check actually did not even run, like the workflow file did not get parsed at all (yet). Like there was not even the check showing up. Maybe there was no free vm from GitHub to pick the workflow or whatever. Anyway, thanks!

@mkurz
mkurz marked this pull request as ready for review May 6, 2022 09:50
@mergify
mergify Bot merged commit b446f4e into playframework:main May 6, 2022
@mkurz
mkurz deleted the cmd.yml branch May 6, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants