Uh oh!
There was an error while loading. Please reload this page.
docs: note the library is on crates.io as code-search-please - #54
Conversation
The library crate is now on crates.io as code-search-please (the short name csp was taken); the library name stays csp, so users depend on code-search-please but write use csp::.... Add a [dependencies] snippet and update the bilingual 'publishing planned' note to reflect it's live.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughBoth ChangesREADME Documentation Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Add a crates.io version badge for code-search-please next to the existing npm badge (relabeled npm package -> npm); kept README.md and README.ko.md in sync.
Add a coverage badge linking to the codecov dashboard, alongside the npm and crates.io badges; README.md and README.ko.md kept in sync.
There was a problem hiding this comment.
Code Review
This pull request updates the English and Korean README files to document that the Rust library crate is published on crates.io as code-search-please and adds a TOML dependency snippet. The review feedback suggests improving link consistency in both files by linking the package name code-search-please directly instead of the platform name crates.io, and also proposes a minor phrasing improvement in the Korean translation.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Up to standards ✅🟢 Issues |
Add the Socket.dev badge for @pleaseai/csp alongside npm, crates.io, and coverage; README.md and README.ko.md kept in sync.
Link the package name code-search-please (not the 'crates.io' text) in the Library section for consistency with the note below, and smooth the Korean phrasing (선점되어 -> 선점되어 있어). (gemini)
Uh oh!
There was an error while loading. Please reload this page.
The "Sync Cargo.lock" step ran `cargo update -p csp -p csp-cli`, but `csp` stopped being a package name once the library crate was renamed to code-search-please (crates.io publish, #53/#54) and csp-node was added (#56). `-p csp` now errors with "package ID specification `csp` did not match any packages", failing the step — so the release PR never synced the lockfile and v0.1.5 shipped a stale 0.1.4 Cargo.lock. The release build's `cargo build --locked` then fails: cannot update Cargo.lock. Use `cargo update --workspace`, which re-locks every local member by its real package name without bumping external deps, and refresh the stale lockfile (members 0.1.4 -> 0.1.5) on main. Typed `fix:` (not `ci:`) on purpose: v0.1.5 is a dud release (its tag points at the stale-lock commit, so it can never be rebuilt), and a `ci:` commit would not make release-please cut a new version. `fix:` triggers the 0.1.6 patch release that actually ships binaries with the corrected lockfile sync.
The "Sync Cargo.lock" step ran `cargo update -p csp -p csp-cli`, but `csp` stopped being a package name once the library crate was renamed to code-search-please (crates.io publish, #53/#54) and csp-node was added (#56). `-p csp` now errors with "package ID specification `csp` did not match any packages", failing the step — so the release PR never synced the lockfile and v0.1.5 shipped a stale 0.1.4 Cargo.lock. The release build's `cargo build --locked` then fails: cannot update Cargo.lock. Use `cargo update --workspace`, which re-locks every local member by its real package name without bumping external deps, and refresh the stale lockfile (members 0.1.4 -> 0.1.5) on main. Typed `fix:` (not `ci:`) on purpose: v0.1.5 is a dud release (its tag points at the stale-lock commit, so it can never be rebuilt), and a `ci:` commit would not make release-please cut a new version. `fix:` triggers the 0.1.6 patch release that actually ships binaries with the corrected lockfile sync.
Reflects PR #53 / the crates.io bootstrap: the library is published as
code-search-please(the short namecspwas taken), with library namecsppreserved.code-search-pleasepackage name +use csp::..., add a[dependencies]snippet.Summary by cubic
Update both READMEs to show the Rust crate is on crates.io as
code-search-pleasewhile the library name remainscsp(depend oncode-search-please, import withuse csp::...).Adds a
[dependencies]snippet, replaces the “publishing planned” note with a live link, relabels the npm badge to “npm”, adds crates.io/Codecov/Socket.dev badges, and tweaks link text and Korean phrasing for clarity.Written for commit 40d3be7. Summary will update on new commits.
Summary by CodeRabbit