Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions connectors/gmail/src/gmail-api.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
import { describe, expect, it } from "vitest";
import {
stripQuotedReply,
transformGmailThread,
type GmailMessage,
type GmailMessagePart,
type GmailThread,
} from "./gmail-api";

// Gmail API returns part bodies as base64url. Encode fixtures the same way the
// real API does so `extractBody`'s atob/replace decode path is exercised.
function b64url(s: string): string {
return Buffer.from(s, "utf8")
.toString("base64")
.replace(/\+/g, "-")
.replace(/\//g, "_");
}

function part(
mimeType: string,
opts: {
data?: string;
parts?: GmailMessagePart[];
headers?: Array<[string, string]>;
filename?: string;
} = {}
): GmailMessagePart {
return {
mimeType,
filename: opts.filename,
headers: (opts.headers ?? []).map(([name, value]) => ({ name, value })),
body:
opts.data !== undefined
? { size: opts.data.length, data: b64url(opts.data) }
: undefined,
parts: opts.parts,
};
}

function thread(opts: {
from: string;
to?: string;
subject?: string;
snippet?: string;
payload: GmailMessagePart;
}): GmailThread {
const headers = [
{ name: "From", value: opts.from },
...(opts.to ? [{ name: "To", value: opts.to }] : []),
...(opts.subject ? [{ name: "Subject", value: opts.subject }] : []),
];
const message: GmailMessage = {
id: "msg-1",
threadId: "thread-1",
labelIds: ["INBOX"],
snippet: opts.snippet ?? "snippet-without-body-marker",
historyId: "1",
internalDate: "1700000000000",
payload: { ...opts.payload, headers: [...headers, ...opts.payload.headers] },
sizeEstimate: 1000,
};
return { id: "thread-1", historyId: "1", messages: [message] };
}

function firstNoteContent(t: GmailThread): string {
const result = transformGmailThread(t);
return result.notes?.[0]?.content ?? "";
}

describe("forwarded email body extraction", () => {
it("keeps the body of an inline HTML forward (Gmail wraps it in gmail_quote)", () => {
// Gmail's "Forward" composes the original inside <div class="gmail_quote">,
// the SAME wrapper it uses for reply quotes — so the reply-stripper wrongly
// deletes the forwarded content, leaving an empty note.
const html =
'<div dir="ltr"><br>' +
'<div class="gmail_quote gmail_quote_container">' +
'<div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>' +
"From: <strong>Porter Airlines</strong> &lt;flyporter@notifications.flyporter.com&gt;<br>" +
"Date: Wed, Aug 19, 2026<br>Subject: Booking details<br>To: Kris<br></div><br>" +
"<div>Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123. Gate at YYZ.</div>" +
"</div></div>";
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"---------- Forwarded message ---------\r\nFrom: Porter Airlines\r\n\r\n" +
"Your booking is confirmed. Confirmation code: BOOKINGCONFIRM123.",
}),
part("text/html", { data: html }),
],
}),
});
expect(firstNoteContent(t)).toContain("BOOKINGCONFIRM123");
});

it("keeps the body of a plain-text forward", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
// Exact 10/10-dash separator that the strip path matches literally.
payload: part("text/plain", {
data:
"---------- Forwarded message ----------\r\n" +
"From: Porter Airlines\r\nSubject: Booking details\r\n\r\n" +
"Your booking is confirmed. Confirmation code: PLAINFWD456.",
}),
});
expect(firstNoteContent(t)).toContain("PLAINFWD456");
});

it("keeps the body of a forward attached as message/rfc822", () => {
const t = thread({
from: "Forwarder <fwd@example.com>",
to: "kris@plot.day",
subject: "Fwd: Booking details",
payload: part("multipart/mixed", {
parts: [
part("text/plain", { data: "" }), // forwarder added no note
part("message/rfc822", {
parts: [
part("multipart/alternative", {
parts: [
part("text/plain", {
data:
"Your booking is confirmed. Confirmation code: RFC822FWD789.",
}),
part("text/html", {
data:
"<div>Your booking is confirmed. Confirmation code: RFC822FWD789.</div>",
}),
],
}),
],
}),
],
}),
});
expect(firstNoteContent(t)).toContain("RFC822FWD789");
});

it("still strips quoted replies (regression guard — HTML)", () => {
const html =
'<div dir="ltr">Thanks, that works for me!' +
'<div class="gmail_quote">' +
'<div dir="ltr" class="gmail_attr">On Mon, Jun 1, 2026 at 9:00 AM Bob &lt;bob@example.com&gt; wrote:<br></div>' +
'<blockquote class="gmail_quote">SECRETQUOTEDREPLY must be stripped</blockquote>' +
"</div></div>";
const t = thread({
from: "Bob <bob@example.com>",
to: "kris@plot.day",
subject: "Re: lunch",
payload: part("text/html", { data: html }),
});
const content = firstNoteContent(t);
expect(content).toContain("Thanks, that works for me!");
expect(content).not.toContain("SECRETQUOTEDREPLY");
});

it("still strips quoted replies (regression guard — plain text)", () => {
const reply = stripQuotedReply(
"My answer is yes.\r\nOn Mon, Jun 1, 2026, Bob wrote:\r\n> old message text",
"text"
);
expect(reply).toContain("My answer is yes.");
expect(reply).not.toContain("old message text");
});
});
94 changes: 59 additions & 35 deletions connectors/gmail/src/gmail-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,39 +416,47 @@ export function getHeader(message: GmailMessage, name: string): string | null {
* Returns raw content with its type so HTML can be converted server-side.
*/
function extractBody(part: GmailMessagePart): { content: string; contentType: "text" | "html" } {
// If this part has a body with data, return it
if (part.body?.data) {
// Gmail API returns base64url-encoded data — decode as UTF-8
const binaryString = atob(part.body.data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
const decoded = new TextDecoder("utf-8").decode(bytes);
const contentType = part.mimeType === "text/html" ? "html" as const : "text" as const;
return { content: decoded, contentType };
}
// Prefer HTML over plain text — server-side conversion produces cleaner output.
// Search the WHOLE MIME tree, not just immediate children: forwarded messages
// nest the real body inside a `message/rfc822` part (or a deeper multipart),
// which the old immediate-children-only `find` missed, yielding an empty note.
const html = findPartContent(part, "text/html");
if (html) return { content: html, contentType: "html" };

// If multipart, recursively search parts
if (part.parts) {
// Prefer HTML over plain text — server-side conversion produces cleaner output
const htmlPart = part.parts.find((p) => p.mimeType === "text/html");
if (htmlPart) {
return extractBody(htmlPart);
}
const text = findPartContent(part, "text/plain");
if (text) return { content: text, contentType: "text" };

const textPart = part.parts.find((p) => p.mimeType === "text/plain");
if (textPart) {
return extractBody(textPart);
}
return { content: "", contentType: "text" };
}

// Try first part as fallback
if (part.parts.length > 0) {
return extractBody(part.parts[0]);
/**
* Recursively finds the first non-empty body of the given MIME type in a Gmail
* payload tree. Descends through multipart/* containers AND `message/rfc822`
* parts (a forwarded email attached inline carries its original payload there).
* Skips real attachments, whose bodies are binary and fetched separately.
*/
function findPartContent(part: GmailMessagePart, mimeType: string): string | null {
const isAttachment = !!part.filename && !!part.body?.attachmentId;
if (!isAttachment && part.mimeType === mimeType && part.body?.data) {
return decodeBase64Url(part.body.data);
}
if (part.parts) {
for (const child of part.parts) {
const found = findPartContent(child, mimeType);
if (found) return found;
}
}
return null;
}

return { content: "", contentType: "text" };
/** Decodes Gmail's base64url-encoded part data as UTF-8. */
function decodeBase64Url(data: string): string {
const binaryString = atob(data.replace(/-/g, "+").replace(/_/g, "/"));
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder("utf-8").decode(bytes);
}

/**
Expand DownExpand Up@@ -487,6 +495,13 @@ export function stripQuotedReply(
): string {
if (!content) return content;

// Forwarded messages: the forwarded email IS the content the user wants to
// read. Gmail/Apple Mail wrap a forward in the same quote container Gmail uses
// for reply quotes, so the reply-stripping below would delete the whole body
// and leave an empty note. Keep the content as-is when it's a forward whose
// marker precedes any reply boundary.
if (isForwardedMessage(content)) return content;

if (contentType === "html") {
// Gmail wraps quoted replies in <div class="gmail_quote">
// Remove it and everything after it
Expand DownExpand Up@@ -573,19 +588,28 @@ export function stripQuotedReply(
.trim();
}
}

// Forwarded message separator
if (line === "---------- Forwarded message ----------") {
return lines
.slice(0, i)
.join("\n")
.trim();
}
}

return content;
}

/**
* Detects a forwarded message so {@link stripQuotedReply} can preserve it.
* Matches Gmail's dashed "---------- Forwarded message ---------" marker and
* Apple Mail's "Begin forwarded message:". Returns false when a reply boundary
* ("On … wrote:") precedes the forward marker — that's a reply quoting a
* forward, which the reply-stripper should still trim.
*/
function isForwardedMessage(content: string): boolean {
const fwdIdx = content.search(
/(-{2,}\s*Forwarded message\s*-{2,}|Begin forwarded message:)/i
);
if (fwdIdx === -1) return false;
const replyIdx = content.search(/On\s[\s\S]{0,200}?\swrote:/i);
if (replyIdx !== -1 && replyIdx < fwdIdx) return false;
return true;
}

/**
* Recursively collects attachment parts from a Gmail message payload.
* An attachment part has a non-empty filename and a body.attachmentId.
Expand Down
Loading