Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/integrations-save-custom-emoji.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@plotday/twister": minor
---

Added: `Integrations.saveCustomEmoji(emoji: NewCustomEmoji[])` — connectors can populate Plot's custom-emoji cache so workspace emoji (e.g. Slack `:party_parrot:`) render as images and round-trip as reactions. New `NewCustomEmoji` type exported.
53 changes: 42 additions & 11 deletions connectors/slack/src/slack-api.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -254,6 +254,18 @@ export class SlackApi {
}
}

/** Lists workspace custom emoji. Values are an image URL or `alias:<name>`. */
public async listEmoji(cursor?: string): Promise<{
emoji: Record<string, string>;
nextCursor?: string;
}> {
const data = await this.call("emoji.list", cursor ? { cursor } : {});
return {
emoji: (data.emoji as Record<string, string>) || {},
nextCursor: data.response_metadata?.next_cursor || undefined,
};
}

public async getConversationHistory(
channelId: string,
cursor?: string,
Expand DownExpand Up@@ -576,26 +588,38 @@ export function formatSlackText(text: string): string {
}

/**
* Extract per-message Slack reactions as Plot reactions. Unmapped
* shortcodes are skipped; deduplication is by source.accountId so
* repeated reactors don't double-count.
* Extract per-message Slack reactions as Plot reactions. Standard shortcodes
* map to their Unicode emoji. A shortcode that isn't standard but IS a known
* workspace custom emoji (passed via `teamId` + `customEmojiNames`) becomes a
* `slack:<teamId>/<name>` ref so Plot can render and round-trip it. Truly
* unknown names are dropped. Deduplication is by source.accountId so repeated
* reactors don't double-count.
*/
function extractSlackMessageReactions(
export function extractSlackMessageReactions(
msg: SlackMessage,
userInfos?: SlackUserInfoMap
userInfos?: SlackUserInfoMap,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewReactions | undefined {
if (!msg.reactions || msg.reactions.length === 0) return undefined;
const byEmoji = new Map<string, NewActor[]>();

for (const reaction of msg.reactions) {
const unicode = slackNameToUnicode(reaction.name);
if (!unicode) continue;
let key = slackNameToUnicode(reaction.name);
if (!key) {
// Strip any ::skin-tone suffix Slack can't apply to custom emoji.
const base = reaction.name.split("::")[0];
if (teamId && customEmojiNames?.has(base)) {
key = `slack:${teamId}/${base}`;
}
}
if (!key) continue; // truly unknown — drop

const actors = reaction.users.map((userId) =>
slackUserToNewActor(userId, userInfos?.get(userId))
);
const existing = byEmoji.get(unicode) ?? [];
byEmoji.set(unicode, [...existing, ...actors]);
const existing = byEmoji.get(key) ?? [];
byEmoji.set(key, [...existing, ...actors]);
}

if (byEmoji.size === 0) return undefined;
Expand All@@ -621,7 +645,9 @@ export function transformSlackThread(
messages: SlackMessage[],
channelId: string,
userInfos?: SlackUserInfoMap,
initialSync?: boolean
initialSync?: boolean,
teamId?: string,
customEmojiNames?: ReadonlySet<string>
): NewLinkWithNotes {
const parentMessage = messages[0];

Expand DownExpand Up@@ -664,7 +690,12 @@ export function transformSlackThread(
if (!userId) continue; // Skip messages without user

const text = formatSlackText(message.text);
const reactions = extractSlackMessageReactions(message, userInfos);
const reactions = extractSlackMessageReactions(
message,
userInfos,
teamId,
customEmojiNames
);

// Build fileRef actions for any files attached to this message
const actions: Action[] = (message.files ?? []).map((f) => ({
Expand Down
265 changes: 265 additions & 0 deletions connectors/slack/src/slack.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
import { describe, expect, it, vi } from "vitest";
import { AuthProvider, type Authorization } from "@plotday/twister/tools/integrations";
import { Slack } from "./slack";
import {
extractSlackMessageReactions,
type SlackMessage,
} from "./slack-api";

/**
* In-memory store backing `this.get` / `this.set` (which delegate to
Expand DownExpand Up@@ -123,3 +127,264 @@ describe("setupChannelWebhook", () => {
expect(createWebhook).not.toHaveBeenCalled();
});
});

describe("syncCustomEmoji", () => {
/** Build a Slack with the tool set needed by syncCustomEmoji. */
function makeEmojiSlack(opts: {
store: ReturnType<typeof makeStore>;
integrationsGet: ReturnType<typeof vi.fn>;
saveCustomEmoji: ReturnType<typeof vi.fn>;
}) {
const create = vi.fn(async () => ({ token: "cb" }) as never);
const runTask = vi.fn(async () => "task-token");
const tools = {
store: opts.store,
integrations: {
get: opts.integrationsGet,
saveCustomEmoji: opts.saveCustomEmoji,
},
network: { createWebhook: vi.fn() },
files: {},
callbacks: { create },
tasks: { runTask },
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);
return { slack, create, runTask };
}

/** Mock global.fetch to answer one `emoji.list` call with `emoji`. */
function mockEmojiListFetch(emoji: Record<string, string>) {
return vi.fn(async () =>
({
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true, emoji }),
}) as never
);
}

it("saves refs with alias resolution and caches the name set", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["emoji:read"],
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({
party_parrot: "https://e/pp.gif",
pp2: "alias:party_parrot",
});
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).toHaveBeenCalledTimes(1);
const saved = saveCustomEmoji.mock.calls[0][0] as Array<{
id: string;
imageUrl: string | null;
aliasOf: string | null;
name: string;
workspace: string;
provider: string;
}>;
const parrot = saved.find((e) => e.id === "slack:T0/party_parrot")!;
expect(parrot).toBeDefined();
expect(parrot.imageUrl).toBe("https://e/pp.gif");
expect(parrot.aliasOf).toBeNull();
expect(parrot.provider).toBe("slack");
expect(parrot.workspace).toBe("T0");
const alias = saved.find((e) => e.id === "slack:T0/pp2")!;
expect(alias).toBeDefined();
expect(alias.imageUrl).toBeNull();
expect(alias.aliasOf).toBe("slack:T0/party_parrot");

// Name set cached for the inbound transform.
expect(store.map.get("custom_emoji_T0")).toEqual(["party_parrot", "pp2"]);
});

it("no-ops when emoji:read is not granted", async () => {
const store = makeStore({});
const integrationsGet = vi.fn().mockResolvedValue({
token: "xoxp-test",
scopes: ["channels:history"], // no emoji:read
provider: { team_id: "T0" },
});
const saveCustomEmoji = vi.fn().mockResolvedValue(undefined);
const { slack } = makeEmojiSlack({ store, integrationsGet, saveCustomEmoji });

const fetchMock = mockEmojiListFetch({ party_parrot: "https://e/pp.gif" });
vi.stubGlobal("fetch", fetchMock);
try {
await (slack as unknown as {
syncCustomEmoji: (c: string) => Promise<void>;
}).syncCustomEmoji("C1");
} finally {
vi.unstubAllGlobals();
}

expect(saveCustomEmoji).not.toHaveBeenCalled();
expect(fetchMock).not.toHaveBeenCalled();
expect(store.map.has("custom_emoji_T0")).toBe(false);
});
});

describe("extractSlackMessageReactions (custom emoji)", () => {
it("emits a slack: ref for a known workspace custom emoji", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot", users: ["U1", "U2"], count: 2 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
expect(result!["slack:T0/party_parrot"]).toHaveLength(2);
});

it("strips a ::skin-tone suffix before matching the custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "party_parrot::skin-tone-3", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeDefined();
expect(Object.keys(result!)).toEqual(["slack:T0/party_parrot"]);
});

it("still drops a truly-unknown name (not standard, not custom)", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "not_a_real_emoji_xyz", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(
msg,
undefined,
"T0",
new Set(["party_parrot"])
);

expect(result).toBeUndefined();
});

it("maps a standard unicode reaction without a custom set", () => {
const msg = {
ts: "1.0",
user: "U1",
reactions: [{ name: "thumbsup", users: ["U1"], count: 1 }],
} as unknown as SlackMessage;

const result = extractSlackMessageReactions(msg);
expect(result).toBeDefined();
// Standard mapping resolves to a unicode key (not a slack: ref).
expect(Object.keys(result!)[0]?.startsWith("slack:")).toBe(false);
});
});

describe("onNoteReactionChanged (custom emoji outbound)", () => {
it("unwraps a slack: ref to the bare name for reactions.add", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const calls: Array<{ method: string; params: URLSearchParams }> = [];
const fetchMock = vi.fn(async (url: string, init: { body: string }) => {
calls.push({
method: String(url).split("/api/")[1] ?? String(url),
params: new URLSearchParams(init.body),
});
return {
ok: true,
status: 200,
headers: { get: () => null },
json: async () => ({ ok: true }),
} as never;
});
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"slack:T0/party_parrot",
true
);
} finally {
vi.unstubAllGlobals();
}

const add = calls.find((c) => c.method.startsWith("reactions.add"));
expect(add).toBeDefined();
expect(add!.params.get("name")).toBe("party_parrot");
expect(add!.params.get("channel")).toBe("C1");
expect(add!.params.get("timestamp")).toBe("111.000");
});

it("drops an unknown custom emoji ref with no Slack equivalent", async () => {
const store = makeStore({ sync_enabled_C1: true });
const integrationsGet = vi.fn().mockResolvedValue({ token: "xoxp-test" });
const tools = {
store,
integrations: { get: integrationsGet },
network: { createWebhook: vi.fn() },
files: {},
};
const slack = new Slack(
"twist-instance-1" as never,
{ getTools: () => tools } as never
);

const fetchMock = vi.fn();
vi.stubGlobal("fetch", fetchMock);
try {
await slack.onNoteReactionChanged(
{ key: "111.000" } as never,
{ meta: { channelId: "C1" } } as never,
{ id: "actor-1" } as never,
"not-a-mappable-emoji",
true
);
} finally {
vi.unstubAllGlobals();
}

expect(fetchMock).not.toHaveBeenCalled();
});
});
Loading
Loading