fix(google): treat HTTP 204 No Content as success in GoogleApi.call

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }

connectors/google-calendar/package.json

@@ -25,14 +25,16 @@
  "build": "tsc",
  "clean": "rm -rf dist",
  "deploy": "plot deploy",
- "lint": "plot lint"
+ "lint": "plot lint",
+ "test": "vitest run"
  },
  "dependencies": {
  "@plotday/connector-google-contacts": "workspace:^",
  "@plotday/twister": "workspace:^"
  },
  "devDependencies": {
- "typescript": "^5.9.3"
+ "typescript": "^5.9.3",
+ "vitest": "^2.1.8"
  },
  "repository": {
  "type": "git",

connectors/google-calendar/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/calendar/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ items: [{ id: "cal-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/calendar/v3/users/me/calendarList"
+ );
+
+ expect(result).toEqual({ items: [{ id: "cal-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /HTTP 500/
+ );
+ });
+});

connectors/google-calendar/src/google-api.ts

@@ -130,9 +130,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(`HTTP ${response.status}: ${await response.text()}`);
  }
  }

connectors/google-calendar/vitest.config.ts

@@ -0,0 +1,10 @@
+import { defineConfig } from "vitest/config";
+
+export default defineConfig({
+ resolve: {
+ // Resolve workspace connector packages from their TypeScript source
+ // using the @plotday/connector export condition (same as the build path).
+ conditions: ["@plotday/connector", "default"],
+ },
+ test: {},
+});

connectors/google-drive/src/google-api.test.ts

@@ -0,0 +1,70 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+
+import { GoogleApi } from "./google-api";
+
+/**
+ * Stub the global `fetch` with a single canned Response and return the spy so
+ * tests can assert on what was sent.
+ */
+function stubFetch(response: Response) {
+ const spy = vi.fn(async () => response);
+ vi.stubGlobal("fetch", spy);
+ return spy;
+}
+
+describe("GoogleApi.call", () => {
+ afterEach(() => {
+ vi.unstubAllGlobals();
+ });
+
+ it("treats 204 No Content as success (channels/stop)", async () => {
+ // Google's channels/stop endpoint returns 204 with an empty body on
+ // success. The call must NOT throw — a 204 is success, not an error.
+ stubFetch(new Response(null, { status: 204 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "POST",
+ "https://www.googleapis.com/drive/v3/channels/stop",
+ undefined,
+ { id: "watch-id", resourceId: "resource-id" }
+ );
+
+ expect(result).toBeNull();
+ });
+
+ it("treats 200 with a JSON body as success and returns the parsed body", async () => {
+ stubFetch(
+ new Response(JSON.stringify({ files: [{ id: "file-1" }] }), {
+ status: 200,
+ headers: { "Content-Type": "application/json" },
+ })
+ );
+
+ const api = new GoogleApi("token");
+ const result = await api.call(
+ "GET",
+ "https://www.googleapis.com/drive/v3/files"
+ );
+
+ expect(result).toEqual({ files: [{ id: "file-1" }] });
+ });
+
+ it("returns null for 410 Gone", async () => {
+ stubFetch(new Response("gone", { status: 410 }));
+
+ const api = new GoogleApi("token");
+ const result = await api.call("GET", "https://example.com");
+
+ expect(result).toBeNull();
+ });
+
+ it("throws on a genuine server error", async () => {
+ stubFetch(new Response("boom", { status: 500 }));
+
+ const api = new GoogleApi("token");
+ await expect(api.call("GET", "https://example.com")).rejects.toThrow(
+ /boom/
+ );
+ });
+});

connectors/google-drive/src/google-api.ts

@@ -109,9 +109,15 @@ export class GoogleApi {
  throw new Error("Authentication failed - token may be expired");
  case 410:
  return null;
- case 200:
- return await response.json();
  default:
+ if (response.ok) {
+ // 204 No Content / 205 Reset Content carry no body — e.g.
+ // channels/stop returns 204 on success. Don't try to parse JSON.
+ if (response.status === 204 || response.status === 205) {
+ return null;
+ }
+ return await response.json();
+ }
  throw new Error(await response.text());
  }
  }